From d5e8dd3e521b9e3d42e8f19504ba8321b44692ea Mon Sep 17 00:00:00 2001 From: "propr-dev[bot]" <1316198+propr-dev[bot]@users.noreply.github.com> Date: Sun, 15 Nov 2026 09:34:35 +0000 Subject: [PATCH 1/2] =?UTF-8?q?I=20changed=20the=20review=20score=20in=20P?= =?UTF-8?q?R=20titles=20from=20the=20=E2=91=A0=E2=80=93=E2=91=A9=20circled?= =?UTF-8?q?=20digits=20to=20the=20Dingbats=20circled=20digits=20=E2=9E=80?= =?UTF-8?q?=E2=80=93=E2=9E=89,=20so=20`=E2=9A=A0=EF=B8=8F=E2=91=A5=20[41?= =?UTF-8?q?=20by=20=E2=80=A6]`=20is=20now=20written=20as=20`=E2=9A=A0?= =?UTF-8?q?=EF=B8=8F=E2=9E=85=20[41=20by=20=E2=80=A6]`.=20I=20couldn't=20r?= =?UTF-8?q?eproduce=20the=20sideways=20=E2=91=A5=20here,=20so=20I=20don't?= =?UTF-8?q?=20know=20yet=20whether=20this=20fixes=20it.=20This=20container?= =?UTF-8?q?=20only=20has=20DejaVu=20fonts,=20and=20they=20draw=20both=20ve?= =?UTF-8?q?rsions=20upright.=20The=20sideways=20glyph=20probably=20comes?= =?UTF-8?q?=20from=20whatever=20font=20your=20system=20uses=20for=20?= =?UTF-8?q?=E2=91=A5;=20it's=20worth=20checking=20an=20updated=20title=20o?= =?UTF-8?q?n=20the=20machine=20where=20you=20saw=20it.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit What changed - Writing the score: `packages/shared/src/prTitleStatusSlot.ts` now writes ➀ (U+2780) to ➉ (U+2789). The sideways problem is one character in a different part of Unicode, so moving to another block avoids that font. - Existing titles: titles that already show ①–⑩ are still recognised. Their score switches to the new digit the next time ProPR renames the title, and they stay stripped from the ProPR UI and merge commit titles as before. - Tests and docs: I updated the expected digits in the shared, core, root, API and UI tests, and in `docs/docs/features/pr-status.md`, which now also explains the older digits. A new test checks that all 10 scores use the new digits and that old ①–⑩ titles are still read, stripped and replaced. Tests - The shared slot test file passes (10 tests). - The core, root and API tests that touch titles pass (217 tests), and the shared package typechecks cleanly. - The UI title tests pass (42 tests). Preview: there isn't one. The change only shows in GitHub PR titles, because the ProPR UI strips the score. The preview manifest instead suggests adding macOS or Windows fonts so a later capture could show the difference. If ➅ still shows sideways on your system, the other options are a plain digit (`⚠️6`) or a different symbol for the score. Sources: - [Unicode variation selectors chart (UFE00.pdf)](https://www.unicode.org/Public/draft/charts/PDF/UFE00.pdf) - [Text vs Emoji Presentation Selectors](https://emojifyi.com/stories/text-vs-emoji-presentation/) --- docs/docs/features/pr-status.md | 8 ++-- .../api/test/mcpMergePreconditions.test.ts | 2 +- .../core/test/pullRequestStatusTitle.test.ts | 18 ++++---- packages/shared/src/prTitleStatusSlot.ts | 19 +++++--- .../shared/test/prTitleStatusSlot.test.ts | 43 ++++++++++++------- .../components/Dashboard/workTitle.test.ts | 2 +- .../src/components/Dashboard/workTitle.ts | 2 +- .../src/components/TaskList/rowModel.test.ts | 2 +- .../TaskList/utils.statusSlot.test.ts | 2 +- propr-ui/src/components/TaskList/utils.tsx | 2 +- propr-ui/src/components/headerUtils.ts | 2 +- test/autoMergeOperations.test.ts | 2 +- test/checkRunHandler.test.ts | 2 +- test/prTaskTitleHelpers.test.ts | 4 +- 14 files changed, 64 insertions(+), 46 deletions(-) diff --git a/docs/docs/features/pr-status.md b/docs/docs/features/pr-status.md index cc64db0d2..ea9401d73 100644 --- a/docs/docs/features/pr-status.md +++ b/docs/docs/features/pr-status.md @@ -54,16 +54,16 @@ GitHub's pull request list shows only titles, labels and a check icon, so ProPR | State | Title | | --- | --- | | `working` | `🔨 [3475 by Claude Opus 5.5] Let an automation run when a plan issue is blocked` | -| `needs_attention` | `⚠️⑥ [3475 by Claude Opus 5.5] …`, with the latest review score (① to ⑩) when there is one | -| `ready` | `✅⑧ [3510 by Claude Opus 5.5] Apply library extensions automatically…`, with the latest review score when there is one | +| `needs_attention` | `⚠️➅ [3475 by Claude Opus 5.5] …`, with the latest review score (➀ to ➉) when there is one | +| `ready` | `✅➇ [3510 by Claude Opus 5.5] Apply library extensions automatically…`, with the latest review score when there is one | -The slot is one emoji, the score beside ⚠️ and ✅, then a single space and the title exactly as it was. An epic pull request follows the emoji with its progress, and shows a pie circle in place of 🔨 while it is working; see [Epic pull requests](#epic-pull-requests). A `none` pull request has no slot. +The slot is one emoji, the score beside ⚠️ and ✅, then a single space and the title exactly as it was. The score uses the Dingbats circled digits ➀ to ➉. A title still showing an older ① to ⑩ score is recognised and gets the new digit on its next rename. An epic pull request follows the emoji with its progress, and shows a pie circle in place of 🔨 while it is working; see [Epic pull requests](#epic-pull-requests). A `none` pull request has no slot. Every title change adds a "changed the title" entry to the timeline, so the title changes far less often than the body line: - A new pull request is created with `🔨` already in its title, so creation costs no rename. - The title changes only when the state changes, or when the score beside ⚠️ or ✅ changes. Activity inside `working` (a review starting, the next Ultrafix cycle, waiting for CI) never renames the pull request; that detail is in the body line. -- ProPR writes ⚠️ or ✅ only once the state has held for about 30 seconds and nothing for the pull request is queued or about to start. The short gap between an Ultrafix review and its fix, or between a failed check and its CI follow-up, costs no rename. Going back to `🔨` (for example when you post a follow-up on a `✅⑧` pull request) is immediate. +- ProPR writes ⚠️ or ✅ only once the state has held for about 30 seconds and nothing for the pull request is queued or about to start. The short gap between an Ultrafix review and its fix, or between a failed check and its CI follow-up, costs no rename. Going back to `🔨` (for example when you post a follow-up on a `✅➇` pull request) is immediate. - No change is sent when the title is already right. When ProPR changes both the body line and the title, it does so in one update. - ProPR only ever replaces the slot it recognises at the start of the title. Your edits to the rest of the title are kept. If you remove the slot, it stays off until the state changes. ProPR also leaves the title alone when adding the slot would take it past GitHub's 256-character limit. - When the pull request is merged or closed, ProPR removes the slot: one final rename, so closed pull request lists and release notes stay clean. diff --git a/packages/api/test/mcpMergePreconditions.test.ts b/packages/api/test/mcpMergePreconditions.test.ts index 3d452f02c..ec7882b41 100644 --- a/packages/api/test/mcpMergePreconditions.test.ts +++ b/packages/api/test/mcpMergePreconditions.test.ts @@ -185,7 +185,7 @@ test('executeTool persists specific PR state failures and get_operation returns if (route === 'GET /repos/{owner}/{repo}/pulls/{pull_number}') { requestedPull = Number(args.pull_number); if (requestedPull === 43) return { data: rest({ number: 43, state: 'closed', closed_at: '2026-09-27T12:00:00Z' }) }; - if (requestedPull === 45) return { data: rest({ number: 45, title: '✅⑧ [12 by Claude Opus 5.5] Add retries' } as PullRequestStateSource) }; + if (requestedPull === 45) return { data: rest({ number: 45, title: '✅➇ [12 by Claude Opus 5.5] Add retries' } as PullRequestStateSource) }; if ([44, 46, 47, 48, 49].includes(requestedPull)) return { data: rest({ number: requestedPull }) }; if (requestedPull === 50) throw Object.assign(new Error('Server Error'), { name: 'HttpError', status: 502, response: { status: 502, headers: {}, data: { message: 'Server Error' } }, diff --git a/packages/core/test/pullRequestStatusTitle.test.ts b/packages/core/test/pullRequestStatusTitle.test.ts index 0ffdf3097..f41508bdc 100644 --- a/packages/core/test/pullRequestStatusTitle.test.ts +++ b/packages/core/test/pullRequestStatusTitle.test.ts @@ -203,7 +203,7 @@ test('creation costs no rename, and a full Ultrafix loop to the goal with passin await syncSettled(); await syncSettled(); - assert.deepEqual(github.renames, [`✅⑧ ${TITLE}`]); + assert.deepEqual(github.renames, [`✅➇ ${TITLE}`]); }); test('checks pending keep 🔨; a failure without follow-up shows ⚠️, passing checks show ✅', async () => { @@ -218,12 +218,12 @@ test('checks pending keep 🔨; a failure without follow-up shows ⚠️, passin assert.equal(github.pull.title, `🔨 ${TITLE}`, '⚠️ is held until it settles'); await new Promise(resolve => setTimeout(resolve, SETTLE_MS + 10)); await sync(); - assert.equal(github.pull.title, `⚠️⑧ ${TITLE}`); + assert.equal(github.pull.title, `⚠️➇ ${TITLE}`); github.checkRuns = [{ name: 'unit', status: 'completed', conclusion: 'success' }]; await syncSettled(); - assert.equal(github.pull.title, `✅⑧ ${TITLE}`); - assert.deepEqual(github.renames, [`⚠️⑧ ${TITLE}`, `✅⑧ ${TITLE}`]); + assert.equal(github.pull.title, `✅➇ ${TITLE}`); + assert.deepEqual(github.renames, [`⚠️➇ ${TITLE}`, `✅➇ ${TITLE}`]); }); test('a brief ⚠️ between a failed check and its queued follow-up costs no rename', async () => { @@ -245,7 +245,7 @@ test('a follow-up on a ✅ pull request renames it to 🔨 at once and back only await addTask('issue', 'completed'); await addScore(8); await syncSettled(); - assert.equal(github.pull.title, `✅⑧ ${TITLE}`); + assert.equal(github.pull.title, `✅➇ ${TITLE}`); const followUp = await addTask('pr-comment', 'processing', { comments: [{ commandMode: 'default' }] }); await sync(); @@ -256,8 +256,8 @@ test('a follow-up on a ✅ pull request renames it to 🔨 at once and back only assert.equal(github.pull.title, `🔨 ${TITLE}`, 'still 🔨 while the checks of the follow-up run'); github.checkRuns = [{ name: 'unit', status: 'completed', conclusion: 'success' }]; await syncSettled(); - assert.equal(github.pull.title, `✅⑧ ${TITLE}`); - assert.deepEqual(github.renames, [`✅⑧ ${TITLE}`, `🔨 ${TITLE}`, `✅⑧ ${TITLE}`]); + assert.equal(github.pull.title, `✅➇ ${TITLE}`); + assert.deepEqual(github.renames, [`✅➇ ${TITLE}`, `🔨 ${TITLE}`, `✅➇ ${TITLE}`]); }); test('a person\'s edit to the rest of the title survives later state changes', async () => { @@ -267,7 +267,7 @@ test('a person\'s edit to the rest of the title survives later state changes', a await setTaskState(implementation, 'completed'); await addScore(9); await syncSettled(); - assert.equal(github.pull.title, '✅⑨ [12 by Claude Opus 5.5] A better title, by a person'); + assert.equal(github.pull.title, '✅➈ [12 by Claude Opus 5.5] A better title, by a person'); }); test('a slot a person removed comes back on the next state change, not before', async () => { @@ -403,7 +403,7 @@ test('the edited webhook of a ProPR rename causes no further write or work', asy }); test('[Epic] detection accepts titles with and without the slot', () => { - for (const slot of ['', '🔨 ', '⚠️⑥ ', '⚠ ', '✅⑧ ', '🔨 3/5 ', '○ 0/5 ', '◔ 1/5 ', '◑ 3/5 ', '◕ 4/5 ', '⚠️ 4/5 ', '✅ 5/5 ']) assert.equal(isEpicPullRequestTitle(`${slot}[Epic] Plan`), true, slot); + for (const slot of ['', '🔨 ', '⚠️➅ ', '⚠ ', '✅➇ ', '🔨 3/5 ', '○ 0/5 ', '◔ 1/5 ', '◑ 3/5 ', '◕ 4/5 ', '⚠️ 4/5 ', '✅ 5/5 ']) assert.equal(isEpicPullRequestTitle(`${slot}[Epic] Plan`), true, slot); assert.equal(isEpicPullRequestTitle('Not an [Epic]'), false); assert.equal(isEpicPullRequestTitle(null), false); }); diff --git a/packages/shared/src/prTitleStatusSlot.ts b/packages/shared/src/prTitleStatusSlot.ts index ce3cf29d9..479e978ca 100644 --- a/packages/shared/src/prTitleStatusSlot.ts +++ b/packages/shared/src/prTitleStatusSlot.ts @@ -4,8 +4,8 @@ * review score as one circled digit), then a single space, then the title. * * 🔨 [3475 by Claude Opus 5.5] Let an automation run when … - * ⚠️⑥ [3475 by Claude Opus 5.5] … - * ✅⑧ [3510 by Claude Opus 5.5] Apply library extensions automatically … + * ⚠️➅ [3475 by Claude Opus 5.5] … + * ✅➇ [3510 by Claude Opus 5.5] Apply library extensions automatically … * * An epic pull request follows its emoji with how many of its issues are * merged into the epic branch, and shows no score. While it is working, a pie @@ -47,16 +47,21 @@ const EPIC_NONE = '\u25CB'; const EPIC_QUARTER = '\u25D4'; const EPIC_HALF = '\u25D1'; const EPIC_THREE_QUARTERS = '\u25D5'; -/** ① (U+2460) to ⑩ (U+2469). */ -const CIRCLED_ONE = 0x2460; +/** + * The score is written with the Dingbats circled sans-serif digits ➀ (U+2780) + * to ➉ (U+2789). The Enclosed Alphanumerics ① (U+2460) to ⑩ (U+2469) that + * titles used before are drawn sideways by some platform fonts (#3576); they + * are still read, so an older title gets the new digit on its next update. + */ +const CIRCLED_ONE = 0x2780; /** * The slot, anchored at the start of the title and followed by exactly one * space. ⚠ is accepted with and without its variation selector. The score is - * only recognised beside ⚠️ and ✅. An epic's ` merged/total` may follow; a - * working epic's circle is recognised only with it. + * only recognised beside ⚠️ and ✅, as ➀–➉ or the older ①–⑩. An epic's + * ` merged/total` may follow; a working epic's circle is recognised only with it. */ -export const PR_TITLE_STATUS_SLOT_PATTERN = /^(?:(?:\u{1F528}|(?:⚠️?|✅)[①-⑩]?)(?: \d{1,6}\/\d{1,6})?|[\u25CB\u25D4\u25D1\u25D5] \d{1,6}\/\d{1,6}) /u; +export const PR_TITLE_STATUS_SLOT_PATTERN = /^(?:(?:\u{1F528}|(?:⚠️?|✅)[①-⑩➀-➉]?)(?: \d{1,6}\/\d{1,6})?|[\u25CB\u25D4\u25D1\u25D5] \d{1,6}\/\d{1,6}) /u; /** The circle a working epic shows for `merged` of `total` issues merged. */ function epicWorkingCircle(merged: number, total: number): string { diff --git a/packages/shared/test/prTitleStatusSlot.test.ts b/packages/shared/test/prTitleStatusSlot.test.ts index e5399ae2a..e9057ee83 100644 --- a/packages/shared/test/prTitleStatusSlot.test.ts +++ b/packages/shared/test/prTitleStatusSlot.test.ts @@ -8,34 +8,47 @@ const TITLE = '[3475 by Claude Opus 5.5] Let an automation run when a plan issue test('renders one slot per persistent state, with the score beside ⚠️ and ✅', () => { assert.equal(renderStatusSlot({ state: 'working', score: 8 }), '🔨'); - assert.equal(renderStatusSlot({ state: 'needs_attention', score: 6 }), '⚠️⑥'); - assert.equal(renderStatusSlot({ state: 'ready', score: 8 }), '✅⑧'); - assert.equal(renderStatusSlot({ state: 'ready', score: 10 }), '✅⑩'); - assert.equal(renderStatusSlot({ state: 'ready', score: 1 }), '✅①'); + assert.equal(renderStatusSlot({ state: 'needs_attention', score: 6 }), '⚠️➅'); + assert.equal(renderStatusSlot({ state: 'ready', score: 8 }), '✅➇'); + assert.equal(renderStatusSlot({ state: 'ready', score: 10 }), '✅➉'); + assert.equal(renderStatusSlot({ state: 'ready', score: 1 }), '✅➀'); assert.equal(renderStatusSlot({ state: 'ready', score: null }), '✅'); assert.equal(renderStatusSlot({ state: 'needs_attention', score: 0 }), '⚠️', 'no circled digit outside 1 to 10'); - assert.equal(renderStatusSlot({ state: 'ready', score: 7.6 }), '✅⑧'); + assert.equal(renderStatusSlot({ state: 'ready', score: 7.6 }), '✅➇'); assert.equal(renderStatusSlot(null), null); }); test('sets, replaces and removes only the slot', () => { assert.equal(withStatusSlot(TITLE, { state: 'working' }), `🔨 ${TITLE}`); - assert.equal(withStatusSlot(`🔨 ${TITLE}`, { state: 'ready', score: 8 }), `✅⑧ ${TITLE}`); - assert.equal(withStatusSlot(`✅⑧ ${TITLE}`, { state: 'needs_attention', score: 6 }), `⚠️⑥ ${TITLE}`); - assert.equal(withStatusSlot(`⚠️⑥ ${TITLE}`, null), TITLE); - assert.equal(withStatusSlot(`✅⑧ ${TITLE}`, { state: 'working' }), `🔨 ${TITLE}`); + assert.equal(withStatusSlot(`🔨 ${TITLE}`, { state: 'ready', score: 8 }), `✅➇ ${TITLE}`); + assert.equal(withStatusSlot(`✅➇ ${TITLE}`, { state: 'needs_attention', score: 6 }), `⚠️➅ ${TITLE}`); + assert.equal(withStatusSlot(`⚠️➅ ${TITLE}`, null), TITLE); + assert.equal(withStatusSlot(`✅➇ ${TITLE}`, { state: 'working' }), `🔨 ${TITLE}`); assert.equal(withStatusSlot('', { state: 'working' }), '🔨 '); }); test('accepts ⚠ with and without the variation selector', () => { - assert.equal(readStatusSlot(`⚠️⑥ ${TITLE}`), '⚠️⑥'); - assert.equal(readStatusSlot(`⚠⑥ ${TITLE}`), '⚠⑥'); + assert.equal(readStatusSlot(`⚠️➅ ${TITLE}`), '⚠️➅'); + assert.equal(readStatusSlot(`⚠➅ ${TITLE}`), '⚠➅'); assert.equal(stripStatusSlot(`⚠ ${TITLE}`), TITLE); - assert.equal(withStatusSlot(`⚠⑥ ${TITLE}`, { state: 'ready', score: 9 }), `✅⑨ ${TITLE}`); + assert.equal(withStatusSlot(`⚠➅ ${TITLE}`, { state: 'ready', score: 9 }), `✅➈ ${TITLE}`); +}); + +test('writes the score as a Dingbats circled digit and still reads the older ①–⑩ slot (#3576)', () => { + for (let score = 1; score <= 10; score += 1) { + const slot = renderStatusSlot({ state: 'ready', score }) as string; + assert.equal(slot.codePointAt(1), 0x2780 + score - 1, `score ${score}`); + } + for (const legacy of ['①', '⑥', '⑩']) { + assert.equal(readStatusSlot(`⚠️${legacy} ${TITLE}`), `⚠️${legacy}`); + assert.equal(stripStatusSlot(`✅${legacy} ${TITLE}`), TITLE); + assert.equal(withStatusSlot(`⚠️${legacy} ${TITLE}`, { state: 'needs_attention', score: 6 }), `⚠️➅ ${TITLE}`); + } + assert.equal(hasStatusSlot(`🔨⑥ ${TITLE}`), false, 'no score beside 🔨 in either form'); }); test('recognises only a strict slot anchored at the start', () => { - for (const title of [TITLE, `x 🔨 ${TITLE}`, `🔨${TITLE}`, `🔨⑧ ${TITLE}`, `⑧ ${TITLE}`, ` 🔨 ${TITLE}`, `🔧 ${TITLE}`]) { + for (const title of [TITLE, `x 🔨 ${TITLE}`, `🔨${TITLE}`, `🔨➇ ${TITLE}`, `➇ ${TITLE}`, ` 🔨 ${TITLE}`, `🔧 ${TITLE}`]) { assert.equal(hasStatusSlot(title), false, title); assert.equal(stripStatusSlot(title), title, title); } @@ -47,13 +60,13 @@ test('recognises only a strict slot anchored at the start', () => { test('leaves the title unchanged when the slot would exceed the 256 character limit', () => { const long = 'a'.repeat(254); assert.equal(withStatusSlot(long, { state: 'working' }), long); - assert.equal(withStatusSlot(`🔨 ${'b'.repeat(250)}`, { state: 'ready', score: 8 }), `✅⑧ ${'b'.repeat(250)}`); + assert.equal(withStatusSlot(`🔨 ${'b'.repeat(250)}`, { state: 'ready', score: 8 }), `✅➇ ${'b'.repeat(250)}`); const exact = 'c'.repeat(253); assert.equal(withStatusSlot(exact, { state: 'working' }).length, 256); }); test('merge commit titles carry no slot', () => { - assert.deepEqual(mergeCommitTitleFields({ number: 3510, title: `✅⑧ ${TITLE}` }, 'squash'), { commit_title: `${TITLE} (#3510)` }); + assert.deepEqual(mergeCommitTitleFields({ number: 3510, title: `✅➇ ${TITLE}` }, 'squash'), { commit_title: `${TITLE} (#3510)` }); assert.deepEqual(mergeCommitTitleFields({ number: 3510, title: TITLE }, 'squash'), { commit_title: `${TITLE} (#3510)` }); assert.deepEqual(mergeCommitTitleFields({ number: 7, title: `🔨 ${TITLE}`, headLabel: 'integry:feature' }, 'merge'), { commit_title: 'Merge pull request #7 from integry/feature', commit_message: TITLE }); diff --git a/propr-ui/src/components/Dashboard/workTitle.test.ts b/propr-ui/src/components/Dashboard/workTitle.test.ts index 8802339d1..4cd47106c 100644 --- a/propr-ui/src/components/Dashboard/workTitle.test.ts +++ b/propr-ui/src/components/Dashboard/workTitle.test.ts @@ -3,7 +3,7 @@ import { splitWorkTitle } from './workTitle'; describe('splitWorkTitle', () => { it('parses titles with and without the PR status slot', () => { - for (const slot of ['', '🔨 ', '⚠️⑥ ', '\u26A0⑥ ', '✅⑧ ', '✅ ']) { + for (const slot of ['', '🔨 ', '⚠️➅ ', '\u26A0➅ ', '✅➇ ', '✅ ']) { expect(splitWorkTitle(`${slot}[3475 by Claude Opus 5.5] Let an automation run`, 'issue')) .toEqual({ type: 'Implement', title: 'Let an automation run' }); expect(splitWorkTitle(`Fix PR #3510: ${slot}[3510 by Claude Opus 5.5] Apply library extensions`, 'pr-comment')) diff --git a/propr-ui/src/components/Dashboard/workTitle.ts b/propr-ui/src/components/Dashboard/workTitle.ts index eb06d230a..4b8c44ccd 100644 --- a/propr-ui/src/components/Dashboard/workTitle.ts +++ b/propr-ui/src/components/Dashboard/workTitle.ts @@ -63,7 +63,7 @@ function taskTypeLabel(taskType: string | null | undefined): string | null { } export function splitWorkTitle(title: string | null | undefined, taskType?: string | null): WorkTitle { - // A PR title may lead with its status slot (`✅⑧ `); older task titles copied it after the prefix. + // A PR title may lead with its status slot (`✅➇ `); older task titles copied it after the prefix. let rest = stripStatusSlot((title ?? '').trim()); let type: string | null = null; diff --git a/propr-ui/src/components/TaskList/rowModel.test.ts b/propr-ui/src/components/TaskList/rowModel.test.ts index 1010dd4f8..be5588848 100644 --- a/propr-ui/src/components/TaskList/rowModel.test.ts +++ b/propr-ui/src/components/TaskList/rowModel.test.ts @@ -11,7 +11,7 @@ const image = (index: number) => ({ type: 'image', title: `Preview ${index}`, ur describe('sanitizeTaskTitle', () => { it('drops the PR status slot and the model tag, with or without the slot', () => { - for (const slot of ['', '🔨 ', '⚠️⑥ ', '✅⑧ ']) { + for (const slot of ['', '🔨 ', '⚠️➅ ', '✅➇ ']) { expect(sanitizeTaskTitle(`Ultrafix PR #2664: ${slot}[2659 by GPT-6 Astra] Stop work when intent is withdrawn`)) .toEqual({ type: 'Ultrafix', title: 'Stop work when intent is withdrawn', fullTitle: 'Stop work when intent is withdrawn' }); expect(sanitizeTaskTitle(`PR #2664: ${slot}Stop work`).title).toBe('Stop work'); diff --git a/propr-ui/src/components/TaskList/utils.statusSlot.test.ts b/propr-ui/src/components/TaskList/utils.statusSlot.test.ts index 4586796ba..973c9e870 100644 --- a/propr-ui/src/components/TaskList/utils.statusSlot.test.ts +++ b/propr-ui/src/components/TaskList/utils.statusSlot.test.ts @@ -3,7 +3,7 @@ import { getCleanDocumentTitle } from './utils.tsx'; import { cleanHeaderTaskTitle } from '../headerUtils'; describe('title parsers and the PR status slot', () => { - for (const slot of ['', '🔨 ', '⚠️⑥ ', '⚠ ', '✅⑧ ']) { + for (const slot of ['', '🔨 ', '⚠️➅ ', '⚠ ', '✅➇ ']) { it(`getCleanDocumentTitle reads the [N by Model] prefix with slot "${slot}"`, () => { expect(getCleanDocumentTitle(`${slot}[3475 by Claude Opus 5.5] Let an automation run`)).toBe('3475: Let an automation run'); expect(getCleanDocumentTitle(`Followup: ${slot}[870 by Claude Opus] Update checkout`)).toBe('870: Update checkout'); diff --git a/propr-ui/src/components/TaskList/utils.tsx b/propr-ui/src/components/TaskList/utils.tsx index bd2b43743..625a56a53 100644 --- a/propr-ui/src/components/TaskList/utils.tsx +++ b/propr-ui/src/components/TaskList/utils.tsx @@ -20,7 +20,7 @@ export const shouldDimTask = (task: Task): boolean => { * @returns Clean title in format "issueId: title" or the original title if no pattern matches */ /** - * The title without a PR status slot (`🔨 `, `✅⑧ `), at its start or right + * The title without a PR status slot (`🔨 `, `✅➇ `), at its start or right * after a `Followup:` / `New Issue:` prefix. */ const withoutStatusSlot = (title: string): string => { diff --git a/propr-ui/src/components/headerUtils.ts b/propr-ui/src/components/headerUtils.ts index daa14255b..386e4a114 100644 --- a/propr-ui/src/components/headerUtils.ts +++ b/propr-ui/src/components/headerUtils.ts @@ -42,7 +42,7 @@ export const formatRelativeTime = (dateString: string): string => { /** * A task title for the header's task list: without the `Followup:` prefix, a - * PR status slot (`🔨 `, `✅⑧ `) or the leading `[N by Model]` tag. + * PR status slot (`🔨 `, `✅➇ `) or the leading `[N by Model]` tag. */ export function cleanHeaderTaskTitle(title?: string): string { if (!title) return ''; diff --git a/test/autoMergeOperations.test.ts b/test/autoMergeOperations.test.ts index 559d5076d..151adb0d0 100644 --- a/test/autoMergeOperations.test.ts +++ b/test/autoMergeOperations.test.ts @@ -61,7 +61,7 @@ test('GitHub refusing to arm at all is reported as unavailable so callers merge test('the merge commit headline carries no title status slot', async () => { graphql.mock.resetCalls(); - currentPullRequest = { node_id: 'PR_node', title: '✅⑧ [12 by Claude Opus 5.5] Add retries', head: { sha: 'evaluated-head', label: 'acme:feature' }, base: { ref: 'main' } }; + currentPullRequest = { node_id: 'PR_node', title: '✅➇ [12 by Claude Opus 5.5] Add retries', head: { sha: 'evaluated-head', label: 'acme:feature' }, base: { ref: 'main' } }; await enableAutoMerge({ owner: 'acme', repoName: 'repo', prNumber: 7, mergeMethod: 'SQUASH', expectedHead }); assert.equal(graphql.mock.calls[0].arguments[1].commitHeadline, '[12 by Claude Opus 5.5] Add retries (#7)'); assert.equal(graphql.mock.calls[0].arguments[1].commitBody, null); diff --git a/test/checkRunHandler.test.ts b/test/checkRunHandler.test.ts index 90f83f182..928d573da 100644 --- a/test/checkRunHandler.test.ts +++ b/test/checkRunHandler.test.ts @@ -3091,7 +3091,7 @@ describe('auto_merge.require_up_to_date sweep retries', () => { test('ProPR\'s own merge passes a commit title without the title status slot', async () => { resetMocks(); useUpToDatePolicy(); - mockCurrentPR({ title: '✅⑧ [12 by Claude Opus 5.5] Add retries' }); + mockCurrentPR({ title: '✅➇ [12 by Claude Opus 5.5] Add retries' }); await handleCheckRunEvent(createMockCheckRunPayload({ headSha: 'abc123sha' }), 'test-correlation-id'); assert.equal(mergeCalls().length, 1); const params = mergeCalls()[0].arguments[1] as Record; diff --git a/test/prTaskTitleHelpers.test.ts b/test/prTaskTitleHelpers.test.ts index 031df55ce..25eab0a3f 100644 --- a/test/prTaskTitleHelpers.test.ts +++ b/test/prTaskTitleHelpers.test.ts @@ -618,12 +618,12 @@ describe('prTaskTitleHelpers merge conflict diff context', () => { describe('PR task titles and the title status slot', () => { test('a task built from a PR title with a slot has no emoji in its title', () => { - for (const slot of ['🔨 ', '⚠️⑥ ', '✅⑧ ', '']) { + for (const slot of ['🔨 ', '⚠️➅ ', '✅➇ ', '']) { assert.strictEqual( buildPrTaskTitle({ workflow: 'followup', pullRequestNumber: 3510, prTitle: `${slot}[3510 by Claude Opus 5.5] Apply library extensions` }), 'Follow-up PR #3510: [3510 by Claude Opus 5.5] Apply library extensions', ); } - assert.strictEqual(buildPrTaskTitle({ workflow: 'fix', pullRequestNumber: 7, prTitle: '✅⑧ [Epic] Plan' }), 'Fix PR #7: [Epic] Plan'); + assert.strictEqual(buildPrTaskTitle({ workflow: 'fix', pullRequestNumber: 7, prTitle: '✅➇ [Epic] Plan' }), 'Fix PR #7: [Epic] Plan'); }); }); From 6baa317be0082dc89a85260ee92b435fefa0f718 Mon Sep 17 00:00:00 2001 From: "propr-dev[bot]" <1316198+propr-dev[bot]@users.noreply.github.com> Date: Sun, 15 Nov 2026 09:55:14 +0000 Subject: [PATCH 2/2] =?UTF-8?q?feat(ai):=20I=20fixed=20the=20Shard=203/4?= =?UTF-8?q?=20failure.=20It=20was=20a=20real=20bug=20from=20this=20PR's=20?= =?UTF-8?q?=E2=9E=80=E2=80=93=E2=9E=89=20change.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I fixed the Shard 3/4 failure. It was a real bug from this PR's ➀–➉ change. **Cause:** the one failing test was `apps/desktop/scripts/macos-window-chrome.test.mjs`. The desktop renderer reads its bundle as Latin-1 instead of UTF-8, so the score digits in the title-matching regex become different characters. The old `[①-⑩]` range happened to stay valid after that. The new `➀-➉` range didn't: the last byte of ➀ turns into `€`, which sorts after `â`. The renderer then failed with `Invalid regular expression … Range out of order in character class` and never showed its first screen. That is the "Choose an instance" timeout in the log. **Fix:** in `packages/shared/src/prTitleStatusSlot.ts`, the regex now uses `\u` escapes instead of literal characters. That covers both score ranges (`\u2460-\u2469\u2780-\u2789`) and the ⚠️ and ✅ emoji (`\u26A0\uFE0F?`, `\u2705`). It matches exactly the same titles, but no longer depends on how the file is read. A short comment explains why. **Verification:** - The macOS window-chrome test fails on this branch with the same error as CI, and passes with the fix. - The other tests this branch touched all pass: - the shared slot tests (10) - the root and core title tests (48) - the UI title tests (42) I didn't rerun the whole shard. The desktop test bundles the built copy of the shared package, so I rebuilt it locally before rerunning; CI rebuilds it on its own. There's no preview, because nothing changes on screen. PR: #3577 Comment by: @propr-dev[bot] (ID: 6892573872) Model: Claude Opus 5.5 --- packages/shared/src/prTitleStatusSlot.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/shared/src/prTitleStatusSlot.ts b/packages/shared/src/prTitleStatusSlot.ts index 479e978ca..f98f99078 100644 --- a/packages/shared/src/prTitleStatusSlot.ts +++ b/packages/shared/src/prTitleStatusSlot.ts @@ -60,8 +60,10 @@ const CIRCLED_ONE = 0x2780; * space. ⚠ is accepted with and without its variation selector. The score is * only recognised beside ⚠️ and ✅, as ➀–➉ or the older ①–⑩. An epic's * ` merged/total` may follow; a working epic's circle is recognised only with it. + * Every non-ASCII character is escaped: the desktop renderer can decode the + * bundle as Latin-1, where a literal ➀ turns into an out-of-order range. */ -export const PR_TITLE_STATUS_SLOT_PATTERN = /^(?:(?:\u{1F528}|(?:⚠️?|✅)[①-⑩➀-➉]?)(?: \d{1,6}\/\d{1,6})?|[\u25CB\u25D4\u25D1\u25D5] \d{1,6}\/\d{1,6}) /u; +export const PR_TITLE_STATUS_SLOT_PATTERN = /^(?:(?:\u{1F528}|(?:\u26A0\uFE0F?|\u2705)[\u2460-\u2469\u2780-\u2789]?)(?: \d{1,6}\/\d{1,6})?|[\u25CB\u25D4\u25D1\u25D5] \d{1,6}\/\d{1,6}) /u; /** The circle a working epic shows for `merged` of `total` issues merged. */ function epicWorkingCircle(merged: number, total: number): string {