From 69abdd165708cfe3e3b5df2583b812178808aada Mon Sep 17 00:00:00 2001 From: Rinalds Uzkalns Date: Sat, 14 Nov 2026 10:13:46 +0000 Subject: [PATCH] ci: pin hosted Linux jobs to ubuntu-24.04 GitHub moved ubuntu-latest to Ubuntu 26.04. rpmbuild there fails the desktop RPM build (%install cannot find the staged usr/ directory), so rpm-maker.test.ts and rpm-signing.test.mjs fail in every full test suite run. Co-Authored-By: Claude Fable 5.2 --- .github/workflows/cli-node-compatibility.yml | 8 ++++---- .github/workflows/codeql.yml | 2 +- .github/workflows/dependency-review.yml | 2 +- .../desktop-connect-discovery-guard.yml | 4 ++-- .github/workflows/desktop-release-guard.yml | 14 +++++++------- .github/workflows/docker-images.yml | 10 +++++----- .github/workflows/hosted-ui-deploy.yml | 2 +- .github/workflows/pr-build-check.yml | 14 +++++++------- .github/workflows/pr-preview.yml | 2 +- .github/workflows/pr-test-on-label.yml | 14 +++++++------- .github/workflows/test-nightly.yml | 6 +++--- CHANGELOG.md | 4 ++++ .../scripts/linux-preview-workflow.test.mjs | 2 +- docs/ci-runners.md | 9 +++++++++ test/ciFullSuiteSelection.test.mjs | 2 +- test/ciHostedCapacity.test.mjs | 4 ++-- test/ciRunnerRouting.test.mjs | 16 ++++++++-------- 17 files changed, 64 insertions(+), 51 deletions(-) diff --git a/.github/workflows/cli-node-compatibility.yml b/.github/workflows/cli-node-compatibility.yml index 55baf901aa..730bae728d 100644 --- a/.github/workflows/cli-node-compatibility.yml +++ b/.github/workflows/cli-node-compatibility.yml @@ -12,7 +12,7 @@ concurrency: jobs: classify: name: Classify changed surfaces - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 permissions: contents: read @@ -40,7 +40,7 @@ jobs: route: name: Select PR check runners if: ${{ vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 5 permissions: contents: read @@ -71,7 +71,7 @@ jobs: # leaves the output empty, which runs the matrix. if: ${{ !cancelled() && needs.classify.outputs.cli != 'false' }} # Rootless opt-in (always, or overflow when hosted runners are saturated); approval-based trust, not strict admission control. See docs/ci-runners.md. - runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-latest"]') }} + runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-24.04"]') }} strategy: fail-fast: false matrix: @@ -168,7 +168,7 @@ jobs: name: CLI Node Compatibility Guard needs: [classify, project-options] if: ${{ !cancelled() }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 5 permissions: contents: read diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index e0217807f5..7cffc1d3e0 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -20,7 +20,7 @@ concurrency: jobs: analyze: name: Analyze JavaScript and TypeScript - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 30 steps: diff --git a/.github/workflows/dependency-review.yml b/.github/workflows/dependency-review.yml index a838d899f5..ea969715da 100644 --- a/.github/workflows/dependency-review.yml +++ b/.github/workflows/dependency-review.yml @@ -14,7 +14,7 @@ concurrency: jobs: review: name: Review dependency changes - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 steps: diff --git a/.github/workflows/desktop-connect-discovery-guard.yml b/.github/workflows/desktop-connect-discovery-guard.yml index d38ca8c29d..cb968fcf17 100644 --- a/.github/workflows/desktop-connect-discovery-guard.yml +++ b/.github/workflows/desktop-connect-discovery-guard.yml @@ -27,7 +27,7 @@ concurrency: jobs: classify: name: Classify changed surfaces - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 permissions: contents: read @@ -191,7 +191,7 @@ jobs: name: Packaged Connect Discovery Guard needs: [classify, packaged-connect-discovery] if: ${{ !cancelled() }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 5 permissions: contents: read diff --git a/.github/workflows/desktop-release-guard.yml b/.github/workflows/desktop-release-guard.yml index e82ad3db02..6f39f5839f 100644 --- a/.github/workflows/desktop-release-guard.yml +++ b/.github/workflows/desktop-release-guard.yml @@ -35,7 +35,7 @@ jobs: classify: name: Classify changed surfaces if: github.event_name == 'pull_request' - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 permissions: contents: read @@ -108,7 +108,7 @@ jobs: if: >- ${{ !cancelled() && github.event_name != 'push' && needs.classify.outputs.desktop != 'false' }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 outputs: version: ${{ steps.version.outputs.version }} release_sha: ${{ github.sha }} @@ -639,7 +639,7 @@ jobs: name: Finalize unsigned validation checksums if: ${{ !cancelled() && github.event_name != 'push' }} needs: [classify, validation-version, package] - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 15 steps: - name: Resolve desktop packaging applicability @@ -710,7 +710,7 @@ jobs: preflight: name: Protected read-only trusted release preflight if: github.event_name == 'push' && github.ref_type == 'tag' && startsWith(github.ref_name, 'desktop-v') - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 environment: name: desktop-release-preflight permissions: @@ -1099,7 +1099,7 @@ jobs: name: Revalidate production architectures and finalize checksums if: needs.preflight.result == 'success' needs: [preflight, release-package] - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 15 steps: - name: Checkout exact immutable release SHA @@ -1142,7 +1142,7 @@ jobs: name: Sign trusted update metadata if: needs.preflight.result == 'success' needs: [preflight, release-finalize] - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 15 environment: name: desktop-release @@ -1204,7 +1204,7 @@ jobs: name: Publish new immutable desktop release if: needs.preflight.result == 'success' needs: [preflight, sign] - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 15 permissions: contents: write diff --git a/.github/workflows/docker-images.yml b/.github/workflows/docker-images.yml index aa7f43f412..acbe542c79 100644 --- a/.github/workflows/docker-images.yml +++ b/.github/workflows/docker-images.yml @@ -31,7 +31,7 @@ permissions: jobs: validate-release: name: Validate Release - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 # The unsharded full server and UI suites alone exceed an hour on a hosted # runner (945 units); 60 minutes cancelled the v0.9.0 release mid-suite. timeout-minutes: 150 @@ -118,7 +118,7 @@ jobs: prepare-cli: name: Build and Smoke Test CLI needs: validate-release - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 30 permissions: contents: read @@ -165,7 +165,7 @@ jobs: preflight-cli: name: Preflight npm Release Artifact needs: [validate-release, prepare-cli] - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 15 permissions: contents: read @@ -340,7 +340,7 @@ jobs: name: Publish CLI with provenance if: github.ref_type == 'tag' || github.event_name == 'workflow_dispatch' needs: [validate-release, prepare-cli, build-smoke-and-push] - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 30 permissions: contents: read @@ -395,7 +395,7 @@ jobs: name: Publish GitHub release if: github.ref_type == 'tag' || github.event_name == 'workflow_dispatch' needs: [validate-release, build-smoke-and-push, publish-cli] - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 30 permissions: contents: write diff --git a/.github/workflows/hosted-ui-deploy.yml b/.github/workflows/hosted-ui-deploy.yml index 52038612f3..b884f136eb 100644 --- a/.github/workflows/hosted-ui-deploy.yml +++ b/.github/workflows/hosted-ui-deploy.yml @@ -25,7 +25,7 @@ permissions: jobs: deploy: name: Deploy ${{ inputs.release_tag }} to app.propr.dev - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 30 # The Cloudflare token lives only in this protected environment, so no # build, PR or other release job can read it. Its deployment policy allows diff --git a/.github/workflows/pr-build-check.yml b/.github/workflows/pr-build-check.yml index d8a47e57c7..2a6b3ba20e 100644 --- a/.github/workflows/pr-build-check.yml +++ b/.github/workflows/pr-build-check.yml @@ -14,7 +14,7 @@ jobs: # test/ciChangeClassification.test.mjs; nothing in this file restates them. classify: name: Classify changed surfaces - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 permissions: contents: read @@ -45,7 +45,7 @@ jobs: route: name: Select PR check runners if: ${{ vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 5 permissions: contents: read @@ -77,7 +77,7 @@ jobs: # superseded-run cancellation intact. if: ${{ !cancelled() && needs.classify.outputs.cli != 'false' }} # Rootless opt-in (always, or overflow when hosted runners are saturated); approval-based trust, not strict admission control. See docs/ci-runners.md. - runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-latest"]') }} + runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-24.04"]') }} timeout-minutes: 30 permissions: contents: read @@ -204,7 +204,7 @@ jobs: name: CLI Agent Skill (Linux x64, glibc 2.31, Node 22) needs: classify if: ${{ !cancelled() && needs.classify.outputs.cli != 'false' }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 container: image: node:22.22.3-bullseye-slim@sha256:f81e523790f0a2c86827ff6356a28fad2edbe0fe36bc3c4275a4d1e16304bf43 permissions: @@ -446,7 +446,7 @@ jobs: needs: route if: ${{ !cancelled() }} # Rootless opt-in (always, or overflow when hosted runners are saturated); approval-based trust, not strict admission control. See docs/ci-runners.md. - runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-latest"]') }} + runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-24.04"]') }} env: ACTIONLINT_IMAGE: rhysd/actionlint@sha256:b1934ee5f1c509618f2508e6eb47ee0d3520686341fec936f3b79331f9315667 permissions: @@ -1169,7 +1169,7 @@ jobs: if: >- ${{ always() && needs.validate.result == 'failure' && github.event.pull_request.head.repo.full_name == github.repository }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 permissions: contents: read pull-requests: write @@ -1229,7 +1229,7 @@ jobs: - windows-connect-discovery - connect-authority-darwin if: ${{ !cancelled() }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 5 permissions: contents: read diff --git a/.github/workflows/pr-preview.yml b/.github/workflows/pr-preview.yml index 1b37f1a4fa..e671d7e459 100644 --- a/.github/workflows/pr-preview.yml +++ b/.github/workflows/pr-preview.yml @@ -25,7 +25,7 @@ jobs: # repo before running PR code on the self-hosted runner. Fail-closed. authorize: name: Authorize label actor - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 if: >- github.event.action == 'labeled' && github.event.label.name == 'preview-env' && diff --git a/.github/workflows/pr-test-on-label.yml b/.github/workflows/pr-test-on-label.yml index 463a096525..487a6b145f 100644 --- a/.github/workflows/pr-test-on-label.yml +++ b/.github/workflows/pr-test-on-label.yml @@ -32,7 +32,7 @@ jobs: classify: name: Classify changed surfaces if: ${{ github.event_name == 'pull_request' && !github.event.pull_request.draft }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 permissions: contents: read @@ -61,7 +61,7 @@ jobs: route: name: Select PR check runners if: ${{ vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 5 permissions: contents: read @@ -96,7 +96,7 @@ jobs: needs: route if: ${{ !cancelled() && (github.event_name == 'workflow_dispatch' || !github.event.pull_request.draft) }} # Rootless opt-in (always, or overflow when hosted runners are saturated); approval-based trust, not strict admission control. See docs/ci-runners.md. - runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-latest"]') }} + runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-24.04"]') }} timeout-minutes: 45 permissions: contents: read @@ -306,7 +306,7 @@ jobs: (github.event_name == 'workflow_dispatch' || !github.event.pull_request.draft) && needs.classify.outputs.docs != 'false' }} # Rootless opt-in (always, or overflow when hosted runners are saturated); approval-based trust, not strict admission control. See docs/ci-runners.md. - runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-latest"]') }} + runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-24.04"]') }} timeout-minutes: 30 permissions: contents: read @@ -412,7 +412,7 @@ jobs: ${{ !cancelled() && (github.event_name == 'workflow_dispatch' || !github.event.pull_request.draft) && needs.classify.outputs.desktop != 'false' }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 20 permissions: contents: read @@ -467,7 +467,7 @@ jobs: if: >- ${{ !cancelled() && (github.event_name == 'workflow_dispatch' || !github.event.pull_request.draft) }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 permissions: contents: read @@ -577,7 +577,7 @@ jobs: ${{ always() && !cancelled() && github.event_name == 'pull_request' && needs.test.result == 'failure' && github.event.pull_request.head.repo.full_name == github.repository }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 permissions: contents: read pull-requests: write diff --git a/.github/workflows/test-nightly.yml b/.github/workflows/test-nightly.yml index 9bf0424f08..e1a588fc3f 100644 --- a/.github/workflows/test-nightly.yml +++ b/.github/workflows/test-nightly.yml @@ -253,7 +253,7 @@ jobs: native-electron: name: Nightly Native Electron (hosted) # The self-hosted runner does not provide the native sandbox/session contract. - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 20 permissions: contents: read @@ -320,7 +320,7 @@ jobs: name: Nightly desktop download needs: [full-tests, e2e-tests, native-electron, desktop-package, desktop-connect] if: ${{ !cancelled() }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 30 permissions: contents: read @@ -412,7 +412,7 @@ jobs: name: Nightly test health needs: [full-tests, e2e-tests, native-electron, desktop-package, desktop-connect, desktop-nightly-download] if: ${{ !cancelled() }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 permissions: contents: read diff --git a/CHANGELOG.md b/CHANGELOG.md index 9bac087166..7b7a543e1a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -186,6 +186,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed +- **CI runs on Ubuntu 24.04 again**: hosted Linux jobs name `ubuntu-24.04` + instead of `ubuntu-latest`, which GitHub moved to Ubuntu 26.04. The desktop + RPM build fails under that image's `rpmbuild`, so two desktop tests failed + in every full test suite run. - **MCP-created plans open in Studio at Review**: `create_plan` called with plan items stored the draft as `draft`, so Studio opened it at Define and showed no issues until it was published. A draft created or updated with diff --git a/apps/desktop/scripts/linux-preview-workflow.test.mjs b/apps/desktop/scripts/linux-preview-workflow.test.mjs index 2da6a2c720..d28aa830c2 100644 --- a/apps/desktop/scripts/linux-preview-workflow.test.mjs +++ b/apps/desktop/scripts/linux-preview-workflow.test.mjs @@ -151,7 +151,7 @@ test('regular desktop PR validation requires disposable-key and real RPM tests', const block = guard.slice(start, guard.indexOf('\n renderer-axe-boundary:', start)); assert.match(block, /github.event_name != 'push'/); assert.match(block, /needs.classify.outputs.desktop != 'false'/); - assert.match(block, /runs-on: ubuntu-latest/); + assert.match(block, /runs-on: ubuntu-24.04/); assert.match(block, /sudo apt-get install --yes rpm gnupg cpio/); assert.match(block, /PROPR_REQUIRE_RPM_TESTS: '1'/); assert.match(block, /node --test apps\/desktop\/scripts\/rpm-signing.test.mjs/); diff --git a/docs/ci-runners.md b/docs/ci-runners.md index b4f66b068d..6012f07d30 100644 --- a/docs/ci-runners.md +++ b/docs/ci-runners.md @@ -494,3 +494,12 @@ ProPR admits issues only by its configured trigger labels (`AI` by default) and ignores comments on issues that are not pull requests. The script refuses to apply `AI` or `llm-*` labels, so the health issue never enters ProPR's queue. Adding a trigger label by hand would still start an agent task. + +## Hosted runner image + +Hosted Linux jobs name `ubuntu-24.04` and not `ubuntu-latest`. When GitHub +moved `ubuntu-latest` to Ubuntu 26.04, `rpmbuild` there stopped building the +desktop RPM from the `electron-installer-redhat` spec (`%install` no longer +runs in the staged directory), so `apps/desktop/src/rpm-maker.test.ts` and +`apps/desktop/scripts/rpm-signing.test.mjs` failed on every run. Move to a +newer image in one change, together with the RPM packaging fix. diff --git a/test/ciFullSuiteSelection.test.mjs b/test/ciFullSuiteSelection.test.mjs index d019736e04..4597889b04 100644 --- a/test/ciFullSuiteSelection.test.mjs +++ b/test/ciFullSuiteSelection.test.mjs @@ -488,7 +488,7 @@ describe('Full Test Suite job selection', () => { assert.match(classify, /fetch-depth: 0\n/); assert.match(classify, /persist-credentials: false\n/); assert.match(classify, /permissions:\n\s+contents: read\n\s+outputs:/); - assert.match(classify, /\n {4}runs-on: ubuntu-latest\n/); + assert.match(classify, /\n {4}runs-on: ubuntu-24.04\n/); }); }); diff --git a/test/ciHostedCapacity.test.mjs b/test/ciHostedCapacity.test.mjs index 8c15443662..e17bdf56c9 100644 --- a/test/ciHostedCapacity.test.mjs +++ b/test/ciHostedCapacity.test.mjs @@ -10,7 +10,7 @@ import { decideOverflow } from '../scripts/ci-hosted-capacity.mjs'; const SCRIPT = fileURLToPath(new URL('../scripts/ci-hosted-capacity.mjs', import.meta.url)); const now = Date.parse('2026-09-28T12:00:00Z'); const ago = seconds => new Date(now - seconds * 1000).toISOString(); -const running = (count, labels = ['ubuntu-latest']) => Array.from({ length: count }, () => ({ status: 'in_progress', labels, created_at: ago(300) })); +const running = (count, labels = ['ubuntu-24.04']) => Array.from({ length: count }, () => ({ status: 'in_progress', labels, created_at: ago(300) })); describe('hosted capacity overflow decision', () => { test('stays hosted while running and planned jobs fit below the limit minus the reserve', () => { @@ -28,7 +28,7 @@ describe('hosted capacity overflow decision', () => { }); test('overflows as soon as a hosted Linux job has waited for a runner', () => { - const waiting = { status: 'queued', labels: ['ubuntu-latest'], created_at: ago(90) }; + const waiting = { status: 'queued', labels: ['ubuntu-24.04'], created_at: ago(90) }; assert.equal(decideOverflow({ jobs: [waiting], now, planned: 1 }).overflow, true); assert.equal(decideOverflow({ jobs: [{ ...waiting, created_at: ago(10) }], now, planned: 1 }).overflow, false, 'a job that was just queued is normal'); assert.equal(decideOverflow({ jobs: [{ ...waiting, labels: ['macos-15'] }], now, planned: 1 }).overflow, false, 'macOS has its own limit'); diff --git a/test/ciRunnerRouting.test.mjs b/test/ciRunnerRouting.test.mjs index 56d8e44bd0..d071aa6562 100644 --- a/test/ciRunnerRouting.test.mjs +++ b/test/ciRunnerRouting.test.mjs @@ -586,7 +586,7 @@ describe('PR check routing', () => { ]; for (const [vars, context, needs, selfHosted] of [...cases.map(([vars, context, selfHosted]) => [vars, context, {}, selfHosted]), ...overflowCases]) { assert.deepEqual(evaluate(vars, context, needs, JSON.parse, (pattern, value) => pattern.replace('{0}', value)), - selfHosted ? ['self-hosted', 'Linux', 'X64', 'propr-rootless'] : ['ubuntu-latest'], JSON.stringify({ vars, context, needs })); + selfHosted ? ['self-hosted', 'Linux', 'X64', 'propr-rootless'] : ['ubuntu-24.04'], JSON.stringify({ vars, context, needs })); } }); @@ -597,7 +597,7 @@ describe('PR check routing', () => { const workflow = readWorkflow(file); const route = jobBlock(workflow, 'route'); assert.match(route, /\n {4}if: \$\{\{ vars\.PROPR_ROOTLESS_PR_CHECKS == 'overflow' \}\}\n/, `${file} checks capacity only in overflow mode`); - assert.match(route, /\n {4}runs-on: ubuntu-latest\n/, file); + assert.match(route, /\n {4}runs-on: ubuntu-24.04\n/, file); assert.match(route, /permissions:\n\s+contents: read\n\s+actions: read\n\s+outputs:/, `${file} reads Actions data only`); assert.match(route, /persist-credentials: false/, file); assert.match(route, /run: node scripts\/ci-hosted-capacity\.mjs\n/, file); @@ -627,7 +627,7 @@ describe('PR check routing', () => { // gated on the shared classifier; test/ciFullSuiteSelection.test.mjs // evaluates the full condition. assert.match(jobBlock(fullSuite, 'docs'), /\n {10}\(github\.event_name == 'workflow_dispatch' \|\| !github\.event\.pull_request\.draft\) &&\n/); - for (const job of ['classify', 'route', 'native-electron', 'test', 'comment']) assert.match(jobBlock(fullSuite, job), /\n {4}runs-on: ubuntu-latest\n/); + for (const job of ['classify', 'route', 'native-electron', 'test', 'comment']) assert.match(jobBlock(fullSuite, job), /\n {4}runs-on: ubuntu-24.04\n/); assert.doesNotMatch(fullSuite, /run-local-shards|LOCAL_SHARD/, 'no nested local shard coordinator'); assert.ok(!existsSync(join(REPOSITORY, 'scripts', 'run-local-shards.mjs'))); assert.doesNotMatch(fullSuite, /pull_request_target/); @@ -847,15 +847,15 @@ describe('PR check routing', () => { assert.match(container, /--network none --memory 1g --memory-swap 1g --cpus 1 --pids-limit 256/, 'tool containers retain individual limits in addition to the per-user cap'); } const expected = { - 'cli-agent-skill-glibc-231': 'ubuntu-latest', + 'cli-agent-skill-glibc-231': 'ubuntu-24.04', 'cli-agent-skill-darwin': 'macos-15', 'windows-connect-discovery': 'windows-2025', 'connect-authority-darwin': 'macos-15', - comment: 'ubuntu-latest', + comment: 'ubuntu-24.04', // Selection and its fail-closed aggregate are cheap hosted jobs. - classify: 'ubuntu-latest', - route: 'ubuntu-latest', - 'compatibility-guard': 'ubuntu-latest', + classify: 'ubuntu-24.04', + route: 'ubuntu-24.04', + 'compatibility-guard': 'ubuntu-24.04', }; assert.deepEqual(jobNames(buildCheck).sort(), [...Object.keys(expected), 'validate', 'cli-node-matrix'].sort()); for (const [job, runner] of Object.entries(expected)) {