Skip to content

Add better supports for warnings #128

Description

@depryf

The framework supports running translated metafile edits.

But it doesn't handle warnings well.

Ultimately, an edit either passes or fails. This framework doesn't allow a "in-between" state for warning.

By default, warnings are ignored; they have no effect on the results of the edits and they are not reported at all.

The MetafileContextFunctions class does support toggle to report the warnings as errors.

But that means warnings are reported as errors; the resulting failures don't know if they fail because of an error or if they fail because of a warning.

It would be nice to have that in the edit results.

There is also one other thing that doesn't work: translated edits can return WARN. It's not a pass or a fail result, it's an in-between. The translation itself always returns true, which is fine. But it needs to add a call to a metho in MetafileContextFunctions that sets a flag indicating the method returned as a warning...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions