Drop slat tilt angle characteristics from custom min/max

The Home app shows no control for the Slat service, so a custom range
cannot be verified there.

Author: Eugen

CHANGES.md

@@ -1,5 +1,5 @@
 # HAP-Java 2.0.10
-* Add constructors with custom min/max to the tilt angle characteristics [#162](https://github.com/hap-java/HAP-Java/issues/162)
+* Add constructors with custom min/max to the window covering tilt angle characteristics [#162](https://github.com/hap-java/HAP-Java/issues/162)
 
 # HAP-Java 2.0.9
 * Fix Set Duration and Remaining Duration characteristics to advertise format `uint32` instead of `int` [#202](https://github.com/hap-java/HAP-Java/issues/202)

src/main/java/io/github/hapjava/characteristics/impl/slat/CurrentTiltAngleCharacteristic.java

@@ -11,31 +11,20 @@
 /** This characteristic describe current tilt angle (between -90 and 90) */
 public class CurrentTiltAngleCharacteristic extends IntegerCharacteristic
     implements EventableCharacteristic {
-  public static final int DEFAULT_MIN_VALUE = -90;
-  public static final int DEFAULT_MAX_VALUE = 90;
 
   public CurrentTiltAngleCharacteristic(
-      int minValue,
-      int maxValue,
       Supplier<CompletableFuture<Integer>> getter,
       Consumer<HomekitCharacteristicChangeCallback> subscriber,
       Runnable unsubscriber) {
     super(
         "000000C1-0000-1000-8000-0026BB765291",
         "current tilt angle",
-        minValue,
-        maxValue,
+        -90,
+        90,
         "arcdegrees",
         Optional.of(getter),
         Optional.empty(),
         Optional.of(subscriber),
         Optional.of(unsubscriber));
   }
-
-  public CurrentTiltAngleCharacteristic(
-      Supplier<CompletableFuture<Integer>> getter,
-      Consumer<HomekitCharacteristicChangeCallback> subscriber,
-      Runnable unsubscriber) {
-    this(DEFAULT_MIN_VALUE, DEFAULT_MAX_VALUE, getter, subscriber, unsubscriber);
-  }
 }

src/main/java/io/github/hapjava/characteristics/impl/slat/TargetTiltAngleCharacteristic.java

@@ -12,33 +12,21 @@
 /** This characteristic describes the target angle of slats. */
 public class TargetTiltAngleCharacteristic extends IntegerCharacteristic
     implements EventableCharacteristic {
-  public static final int DEFAULT_MIN_VALUE = -90;
-  public static final int DEFAULT_MAX_VALUE = 90;
 
   public TargetTiltAngleCharacteristic(
-      int minValue,
-      int maxValue,
       Supplier<CompletableFuture<Integer>> getter,
       ExceptionalConsumer<Integer> setter,
       Consumer<HomekitCharacteristicChangeCallback> subscriber,
       Runnable unsubscriber) {
     super(
         "000000C2-0000-1000-8000-0026BB765291",
         "target tilt angle",
-        minValue,
-        maxValue,
+        -90,
+        90,
         "arcdegrees",
         Optional.of(getter),
         Optional.of(setter),
         Optional.of(subscriber),
         Optional.of(unsubscriber));
   }
-
-  public TargetTiltAngleCharacteristic(
-      Supplier<CompletableFuture<Integer>> getter,
-      ExceptionalConsumer<Integer> setter,
-      Consumer<HomekitCharacteristicChangeCallback> subscriber,
-      Runnable unsubscriber) {
-    this(DEFAULT_MIN_VALUE, DEFAULT_MAX_VALUE, getter, setter, subscriber, unsubscriber);
-  }
 }

src/test/java/io/github/hapjava/characteristics/impl/CustomTiltAngleRangeTest.java

@@ -3,8 +3,6 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import io.github.hapjava.characteristics.Characteristic;
-import io.github.hapjava.characteristics.impl.slat.CurrentTiltAngleCharacteristic;
-import io.github.hapjava.characteristics.impl.slat.TargetTiltAngleCharacteristic;
 import io.github.hapjava.characteristics.impl.windowcovering.CurrentHorizontalTiltAngleCharacteristic;
 import io.github.hapjava.characteristics.impl.windowcovering.CurrentVerticalTiltAngleCharacteristic;
 import io.github.hapjava.characteristics.impl.windowcovering.TargetHorizontalTiltAngleCharacteristic;
@@ -22,14 +20,6 @@ public void defaultConstructorsKeepTheirSerializedOutput() {
     // Serialized output captured before custom ranges were added.
     for (Case c :
         Arrays.asList(
-            Case.of(
-                new CurrentTiltAngleCharacteristic(
-                    () -> CompletableFuture.completedFuture(50), cb -> {}, () -> {}),
-                "{\"iid\":7,\"type\":\"C1\",\"perms\":[\"pr\",\"ev\"],\"format\":\"int\",\"value\":50,\"minValue\":-90,\"maxValue\":90,\"minStep\":1,\"unit\":\"arcdegrees\"}"),
-            Case.of(
-                new TargetTiltAngleCharacteristic(
-                    () -> CompletableFuture.completedFuture(50), v -> {}, cb -> {}, () -> {}),
-                "{\"iid\":7,\"type\":\"C2\",\"perms\":[\"pr\",\"pw\",\"ev\"],\"format\":\"int\",\"value\":50,\"minValue\":-90,\"maxValue\":90,\"minStep\":1,\"unit\":\"arcdegrees\"}"),
             Case.of(
                 new CurrentHorizontalTiltAngleCharacteristic(
                     () -> CompletableFuture.completedFuture(50), cb -> {}, () -> {}),
@@ -56,10 +46,6 @@ public void defaultConstructorsKeepTheirSerializedOutput() {
   public void customRangeIsAdvertised() {
     for (Characteristic c :
         Arrays.<Characteristic>asList(
-            new CurrentTiltAngleCharacteristic(
-                0, 90, () -> CompletableFuture.completedFuture(50), cb -> {}, () -> {}),
-            new TargetTiltAngleCharacteristic(
-                0, 90, () -> CompletableFuture.completedFuture(50), v -> {}, cb -> {}, () -> {}),
             new CurrentHorizontalTiltAngleCharacteristic(
                 0, 90, () -> CompletableFuture.completedFuture(50), cb -> {}, () -> {}),
             new TargetHorizontalTiltAngleCharacteristic(