From 4dd1c706860e27bd2e7f55a0908829cc4b9f268a Mon Sep 17 00:00:00 2001 From: dlarocque Date: Fri, 4 Sep 2026 15:49:54 -0400 Subject: [PATCH] chore(firestore): add `--exit` flag to `test-only` and `conformance` Pass `--exit` to mocha in test-only and conformance to ensure Node terminates once tests complete. This prevents test runner from hanging on open grpc streams and background timer handles in modern node versions. --- handwritten/firestore/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/handwritten/firestore/package.json b/handwritten/firestore/package.json index fb08366175f..79fc0e8ca7d 100644 --- a/handwritten/firestore/package.json +++ b/handwritten/firestore/package.json @@ -51,8 +51,8 @@ "system-test:nightly": "FIRESTORE_TARGET_BACKEND=nightly FIRESTORE_DATABASE_ID=enterprise RUN_ENTERPRISE_TESTS=yes GCLOUD_PROJECT=firestore-sdk-nightly mocha build/system-test --timeout 1200000", "system-test:emulator": "concurrently -p \"[{name}]\" -n \"grpc,rest,enterprise-grpc,enterprise-rest\" -c \"cyan,magenta,blue,yellow\" \"npm:system-test:emulator:grpc\" \"npm:system-test:emulator:rest\" \"npm:system-test:enterprise:emulator:grpc\" \"npm:system-test:enterprise:emulator:rest\"", "presystem-test": "npm run compile", - "conformance": "mocha build/conformance", - "test-only": "c8 mocha build/test", + "conformance": "mocha build/conformance --exit", + "test-only": "c8 mocha build/test --exit", "pretest": "npm run compile", "test": "npm run test-only && npm run conformance", "lint": "gts check",