From 8761d8214f4d534d2280a22b533b8f846e08b53c Mon Sep 17 00:00:00 2001 From: Anton Karpov Date: Sat, 8 Aug 2026 01:30:30 +0300 Subject: [PATCH] doc(oauth2): name the constructor parameter these classes actually take The four credential constructors document a rest_client and a current_time_fn. Neither has existed since the client factory replaced them, so Doxygen drops the description and client_factory is left undocumented. --- google/cloud/internal/oauth2_authorized_user_credentials.h | 4 ++-- google/cloud/internal/oauth2_compute_engine_credentials.h | 6 +++--- .../oauth2_impersonate_service_account_credentials.h | 5 +++-- google/cloud/internal/oauth2_service_account_credentials.h | 6 ++---- 4 files changed, 10 insertions(+), 11 deletions(-) diff --git a/google/cloud/internal/oauth2_authorized_user_credentials.h b/google/cloud/internal/oauth2_authorized_user_credentials.h index 6364a0ffc1d89..bb435c395d987 100644 --- a/google/cloud/internal/oauth2_authorized_user_credentials.h +++ b/google/cloud/internal/oauth2_authorized_user_credentials.h @@ -71,8 +71,8 @@ class AuthorizedUserCredentials : public Credentials { /** * Creates an instance of AuthorizedUserCredentials. * - * @param rest_client a dependency injection point. It makes it possible to - * mock internal REST types. This should generally not be overridden + * @param client_factory a dependency injection point. It makes it possible + * to mock internal REST types. This should generally not be overridden * except for testing. */ explicit AuthorizedUserCredentials(AuthorizedUserCredentialsInfo info, diff --git a/google/cloud/internal/oauth2_compute_engine_credentials.h b/google/cloud/internal/oauth2_compute_engine_credentials.h index 786320f71280b..fb3137b7bf7d9 100644 --- a/google/cloud/internal/oauth2_compute_engine_credentials.h +++ b/google/cloud/internal/oauth2_compute_engine_credentials.h @@ -83,9 +83,9 @@ class ComputeEngineCredentials : public Credentials { /** * Creates an instance of ComputeEngineCredentials. * - * @param rest_client a dependency injection point. It makes it possible to - * mock internal libcurl wrappers. This should generally not be overridden - * except for testing. + * @param client_factory a dependency injection point. It makes it possible + * to mock internal libcurl wrappers. This should generally not be + * overridden except for testing. */ explicit ComputeEngineCredentials(std::string service_account_email, Options options, diff --git a/google/cloud/internal/oauth2_impersonate_service_account_credentials.h b/google/cloud/internal/oauth2_impersonate_service_account_credentials.h index bd8a392fadf17..120407aa2f907 100644 --- a/google/cloud/internal/oauth2_impersonate_service_account_credentials.h +++ b/google/cloud/internal/oauth2_impersonate_service_account_credentials.h @@ -49,8 +49,9 @@ class ImpersonateServiceAccountCredentials /** * Creates an instance of ImpersonateServiceAccountCredentials. * - * @param current_time_fn a dependency injection point to fetch the current - * time. This should generally not be overridden except for testing. + * @param client_factory a dependency injection point. It makes it possible + * to mock internal REST types. This should generally not be overridden + * except for testing. */ explicit ImpersonateServiceAccountCredentials( google::cloud::internal::ImpersonateServiceAccountConfig const& config, diff --git a/google/cloud/internal/oauth2_service_account_credentials.h b/google/cloud/internal/oauth2_service_account_credentials.h index 70763278dde7a..322c9a072a446 100644 --- a/google/cloud/internal/oauth2_service_account_credentials.h +++ b/google/cloud/internal/oauth2_service_account_credentials.h @@ -252,11 +252,9 @@ class ServiceAccountCredentials : public oauth2_internal::Credentials { /** * Creates an instance of ServiceAccountCredentials. * - * @param rest_client a dependency injection point. It makes it possible to - * mock internal REST types. This should generally not be overridden + * @param client_factory a dependency injection point. It makes it possible + * to mock internal REST types. This should generally not be overridden * except for testing. - * @param current_time_fn a dependency injection point to fetch the current - * time. This should generally not be overridden except for testing. */ explicit ServiceAccountCredentials(ServiceAccountCredentialsInfo info, Options options,