From bfff733483847be0e9df4a4edf1a5c9bcb2b7325 Mon Sep 17 00:00:00 2001 From: Pau Peinado Date: Tue, 24 Mar 2026 12:25:44 +0100 Subject: [PATCH 1/2] fix PHP 8.5 compatibility --- src/Google/AdsApi/Common/AdsSoapClient.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Google/AdsApi/Common/AdsSoapClient.php b/src/Google/AdsApi/Common/AdsSoapClient.php index 1e07b20f9..91e3be3e3 100644 --- a/src/Google/AdsApi/Common/AdsSoapClient.php +++ b/src/Google/AdsApi/Common/AdsSoapClient.php @@ -94,10 +94,11 @@ public function __doRequest( $location, $action, $version, - $one_way = 0 + $one_way = 0, + ?string $uriParserClass = null ) { $request = SoapRequests::replaceReferences($request); - $response = parent::__doRequest($request, $location, $action, $version, $one_way); + $response = parent::__doRequest($request, $location, $action, $version, $one_way, $uriParserClass); return $response; } From f6d1a8273d5fdc6761e9db1e5413774771d5479b Mon Sep 17 00:00:00 2001 From: Pau Peinado Date: Wed, 10 Jun 2026 17:15:33 +0200 Subject: [PATCH 2/2] make change compatible with previous PHP versions (8.0 - 8.4) --- src/Google/AdsApi/Common/AdsSoapClient.php | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/src/Google/AdsApi/Common/AdsSoapClient.php b/src/Google/AdsApi/Common/AdsSoapClient.php index 91e3be3e3..8b7033ea7 100644 --- a/src/Google/AdsApi/Common/AdsSoapClient.php +++ b/src/Google/AdsApi/Common/AdsSoapClient.php @@ -86,6 +86,9 @@ public function __construct($wsdl, array $options = null) } /** + * The $uriParserClass parameter only exists on the parent method as of + * PHP 8.5, so it must not be forwarded on earlier versions. + * * @see SoapClient::__doRequest */ #[\ReturnTypeWillChange] @@ -98,9 +101,24 @@ public function __doRequest( ?string $uriParserClass = null ) { $request = SoapRequests::replaceReferences($request); - $response = parent::__doRequest($request, $location, $action, $version, $one_way, $uriParserClass); + if (PHP_VERSION_ID >= 80500) { + return parent::__doRequest( + $request, + $location, + $action, + $version, + $one_way, + $uriParserClass + ); + } - return $response; + return parent::__doRequest( + $request, + $location, + $action, + $version, + $one_way + ); } /**