Skip to content

Commit a1ccba8

Browse files
authored
Merge pull request #1723 from gooddata/PJE/F1-2435
refactor: remove support for Greenplum
2 parents 91a45e3 + 60e8b58 commit a1ccba8

13 files changed

Lines changed: 0 additions & 71 deletions

File tree

docs/content/en/latest/data/data-source/_index.md

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -154,24 +154,6 @@ CatalogDataSourceBigQuery(
154154
parameters=[{"name": "projectId", "value": "abc"}],
155155
)
156156
```
157-
### Greenplum
158-
159-
```python
160-
CatalogDataSourceGreenplum(
161-
id=data_source_id,
162-
name=data_source_name,
163-
db_specific_attributes=GreenplumAttributes(
164-
host=os.environ["GREENPLUM_HOST"],
165-
db_name=os.environ["GREENPLUM_DBNAME"]
166-
),
167-
schema=os.environ["GREENPLUM_SCHEMA"],
168-
credentials=BasicCredentials(
169-
username=os.environ["GREENPLUM_USER"],
170-
password=os.environ["GREENPLUM_PASSWORD"],
171-
),
172-
)
173-
```
174-
175157
### Microsoft SQL Server
176158

177159
```python

gooddata-api-client/gooddata_api_client/model/declarative_data_source.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ class DeclarativeDataSource(ModelNormal):
7373
'PRESTO': "PRESTO",
7474
'DREMIO': "DREMIO",
7575
'DRILL': "DRILL",
76-
'GREENPLUM': "GREENPLUM",
7776
'AZURESQL': "AZURESQL",
7877
'SYNAPSESQL': "SYNAPSESQL",
7978
'DATABRICKS': "DATABRICKS",

gooddata-api-client/gooddata_api_client/model/json_api_data_source_identifier_out_attributes.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ class JsonApiDataSourceIdentifierOutAttributes(ModelNormal):
6767
'PRESTO': "PRESTO",
6868
'DREMIO': "DREMIO",
6969
'DRILL': "DRILL",
70-
'GREENPLUM': "GREENPLUM",
7170
'AZURESQL': "AZURESQL",
7271
'SYNAPSESQL': "SYNAPSESQL",
7372
'DATABRICKS': "DATABRICKS",

gooddata-api-client/gooddata_api_client/model/json_api_data_source_in_attributes.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ class JsonApiDataSourceInAttributes(ModelNormal):
7171
'PRESTO': "PRESTO",
7272
'DREMIO': "DREMIO",
7373
'DRILL': "DRILL",
74-
'GREENPLUM': "GREENPLUM",
7574
'AZURESQL': "AZURESQL",
7675
'SYNAPSESQL': "SYNAPSESQL",
7776
'DATABRICKS': "DATABRICKS",

gooddata-api-client/gooddata_api_client/model/json_api_data_source_out_attributes.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ class JsonApiDataSourceOutAttributes(ModelNormal):
7171
'PRESTO': "PRESTO",
7272
'DREMIO': "DREMIO",
7373
'DRILL': "DRILL",
74-
'GREENPLUM': "GREENPLUM",
7574
'AZURESQL': "AZURESQL",
7675
'SYNAPSESQL': "SYNAPSESQL",
7776
'DATABRICKS': "DATABRICKS",

gooddata-api-client/gooddata_api_client/model/json_api_data_source_patch_attributes.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ class JsonApiDataSourcePatchAttributes(ModelNormal):
8181
'PRESTO': "PRESTO",
8282
'DREMIO': "DREMIO",
8383
'DRILL': "DRILL",
84-
'GREENPLUM': "GREENPLUM",
8584
'AZURESQL': "AZURESQL",
8685
'SYNAPSESQL': "SYNAPSESQL",
8786
'DATABRICKS': "DATABRICKS",

gooddata-api-client/gooddata_api_client/model/test_definition_request.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ class TestDefinitionRequest(ModelNormal):
7171
'PRESTO': "PRESTO",
7272
'DREMIO': "DREMIO",
7373
'DRILL': "DRILL",
74-
'GREENPLUM': "GREENPLUM",
7574
'AZURESQL': "AZURESQL",
7675
'SYNAPSESQL': "SYNAPSESQL",
7776
'DATABRICKS': "DATABRICKS",

packages/gooddata-sdk/src/gooddata_sdk/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
CatalogDataSourceBigQuery,
4545
CatalogDataSourceDatabricks,
4646
CatalogDataSourceGdStorage,
47-
CatalogDataSourceGreenplum,
4847
CatalogDataSourceMariaDb,
4948
CatalogDataSourceMotherDuck,
5049
CatalogDataSourceMsSql,
@@ -54,7 +53,6 @@
5453
CatalogDataSourceSnowflake,
5554
CatalogDataSourceVertica,
5655
DatabricksAttributes,
57-
GreenplumAttributes,
5856
MariaDbAttributes,
5957
MotherDuckAttributes,
6058
MsSqlAttributes,

packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/entity_model/data_source.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -166,11 +166,6 @@ class VerticaAttributes(PostgresAttributes):
166166
port: str = "5433"
167167

168168

169-
@define(kw_only=True)
170-
class GreenplumAttributes(PostgresAttributes):
171-
pass
172-
173-
174169
@define(kw_only=True)
175170
class MySqlAttributes(DatabaseAttributes):
176171
host: str
@@ -230,12 +225,6 @@ class CatalogDataSourceBigQuery(CatalogDataSource):
230225
type: str = "BIGQUERY"
231226

232227

233-
@define(kw_only=True)
234-
class CatalogDataSourceGreenplum(CatalogDataSourcePostgres):
235-
type: str = "GREENPLUM"
236-
db_vendor: str = "postgresql"
237-
238-
239228
@define(kw_only=True)
240229
class MsSqlAttributes(DatabaseAttributes):
241230
host: str

packages/gooddata-sdk/tests/catalog/test_catalog_data_source.py

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -769,28 +769,6 @@ def test_scan_sql_without_preview(test_config: dict):
769769
assert response.data_preview is None
770770

771771

772-
"""
773-
# TODO: commented because Greenplum is supported only for Cloud and it cannot be tested using Docker image.
774-
@gd_vcr.use_cassette(str(_fixtures_dir / "greenplum.yaml"))
775-
def test_catalog_create_data_source_greenplum_spec(test_config):
776-
sdk = GoodDataSdk.create(host_=test_config["host"], token_=test_config["token"])
777-
_create_delete_ds(
778-
sdk=sdk,
779-
data_source=CatalogDataSourceGreenplum(
780-
id="test",
781-
name="Test",
782-
db_specific_attributes=GreenplumAttributes(host="greenplum", db_name="demo"),
783-
schema="demo",
784-
credentials=BasicCredentials(
785-
username="demouser",
786-
password="demopass",
787-
),
788-
url_params=[("autosave", "true")],
789-
),
790-
)
791-
"""
792-
793-
794772
def test_allowed_data_source_type(test_config):
795773
allowed_types = JsonApiDataSourceInAttributes.allowed_values.get(("type",))
796774
for t in allowed_types.values():

0 commit comments

Comments
 (0)