From 71bed475c86637e4b10038086aa7621099e9ddc5 Mon Sep 17 00:00:00 2001 From: tannevaled Date: Wed, 21 Oct 2026 08:58:00 +0200 Subject: [PATCH] Bump the conformance guard to docs v0.4.0, where its flag became --root MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The tool this step runs moved to cobra in go-embedded-ruby/docs#36, so its flags are POSIX --long now. ⛔ THE VERSION AND THE FLAG MOVE TOGETHER, and that is the point. `-root` is not a shorter spelling of `--root`: pflag reads it as the cluster -r -o -o -t, and the step fails with conformancefigure: unknown shorthand flag: 'r' in -root A bump that changed only the version would have met that during some later upgrade with nothing to do with it -- which is the worst shape for a breaking change, silent until an unrelated routine touch. docs#33 was filed to make this wave deliberate instead. VERIFIED BEFORE BUMPING, not after: the tool at that version was run against this repository's layouts/ and reads this page's phrasing -- 4 current claim(s) checked against the gate's 23511 which matters because the vocabulary it uses was EXTENDED for this page's HTML style ("23,511 … examples passing"), and a vocabulary that stops matching reports no disagreement, exactly like a page with no stale figures. The same reason is why conformancefigure keeps its vocabulary control INSIDE the tool rather than moving it to a _test.go as its sibling did: this consumer runs `go run …@vX` and never runs that module's tests, so a control living only in a test would have silently stopped protecting this page. The pin stays a TAG. The comment above it already says why -- @main is whatever the proxy last cached, and that lag once failed a branch whose figures were right. Co-Authored-By: Claude Opus 5 --- .github/workflows/deploy-pages.yml | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/.github/workflows/deploy-pages.yml b/.github/workflows/deploy-pages.yml index b3c25f7..a48a163 100644 --- a/.github/workflows/deploy-pages.yml +++ b/.github/workflows/deploy-pages.yml @@ -77,8 +77,21 @@ jobs: # The first version of this step used @main and failed on a branch whose # figures were right, because the tool it ran was nine minutes old and # could not yet see this page's phrasing. A tag resolves deterministically. + # + # ⛔ THE FLAG IS `--root` SINCE docs v0.4.0, where the tool moved to cobra. + # `-root` is not a shorter spelling of it: pflag reads it as the cluster + # -r -o -o -t and the step fails with "unknown shorthand flag: 'r' in + # -root". The two are bumped TOGETHER for that reason -- a later bump that + # changed only the version would have met this during an upgrade that had + # nothing to do with it. + # + # Verified before bumping: the tool at that version reads THIS page's + # phrasing, 4 current claims against the gate's 23511. The vocabulary + # control still runs inside the tool on every invocation rather than only + # under `go test`, precisely because this consumer never runs that + # module's tests. - name: The stated conformance total matches rbgo's gate - run: go run github.com/go-embedded-ruby/docs/tools/conformancefigure@v0.1.0 -root layouts + run: go run github.com/go-embedded-ruby/docs/tools/conformancefigure@v0.4.0 --root layouts - name: Build landing page run: hugo --minify --baseURL "${{ steps.pages.outputs.base_url }}/"