From b0edd04782fc95cb8db125108d9bd90608a1dbe6 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon, 7 Sep 2026 08:52:16 +0000 Subject: [PATCH] docs: fix CompilerExtension default impl and missing container_runtime.rs entry - docs/ir.md showed CompilerExtension::declarations() as a required method with no body, contradicting docs/extending.md and the actual trait in src/compile/extensions/mod.rs, which gives it a default implementation returning Ok(Declarations::default()). - AGENTS.md's architecture tree omitted src/compile/extensions/container_runtime.rs, an existing module (typed Docker runtime config for MCPG stdio servers). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- AGENTS.md | 1 + docs/ir.md | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/AGENTS.md b/AGENTS.md index d4fee67a..42c7e313 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -99,6 +99,7 @@ fail-closed and only pauses when the agent actually proposed a reviewed output. │ │ │ ├── github.rs # Always-on GitHub MCP extension │ │ │ ├── safe_outputs.rs # Always-on SafeOutputs MCP extension │ │ │ ├── ado_script.rs # Always-on ado-script extension (gate evaluator + runtime-import resolver + execution-context precomputes, per-job downloads) +│ │ │ ├── container_runtime.rs # Typed Docker runtime configuration for MCPG stdio servers (mount modes, container args) │ │ │ ├── exec_context/ # Always-on execution-context extension (issue #860) │ │ │ │ ├── mod.rs # ExecContextExtension; CompilerExtension impl; contributor fan-out │ │ │ │ ├── contributor.rs # Internal ContextContributor trait + Contributor enum diff --git a/docs/ir.md b/docs/ir.md index 1c9263de..3135391a 100644 --- a/docs/ir.md +++ b/docs/ir.md @@ -224,7 +224,11 @@ The extension trait lives in `src/compile/extensions/mod.rs` and now has exactly pub trait CompilerExtension { fn name(&self) -> &str; fn phase(&self) -> ExtensionPhase; - fn declarations(&self, ctx: &CompileContext) -> Result; + /// Default returns `Ok(Declarations::default())` — override when the + /// extension contributes steps, hosts, tools, or other signals. + fn declarations(&self, ctx: &CompileContext) -> Result { + Ok(Declarations::default()) + } } ```