Simplify addition

knewbury01 · knewbury01 · commit ae19736b1026 · 2025-10-22T17:15:59.000-04:00
diff --git a/javascript/ql/lib/semmle/javascript/frameworks/React.qll b/javascript/ql/lib/semmle/javascript/frameworks/React.qll
@@ -806,10 +806,9 @@ private class ReactRouterLocationSource extends DOM::LocationSource::Range {
 
 private class UseRefDomValueSource extends DOM::DomValueSource::Range {
   UseRefDomValueSource() {
-    exists(DataFlow::PropRead current, UseRefStep step, string prop | current = this |
+    exists(DataFlow::PropRead current, UseRefStep step | current = this |
       step.step(_, current) and
-      current.mayHavePropertyName(prop) and
-      prop = "current"
+      current.mayHavePropertyName("current")
     )
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -806,10 +806,9 @@ private class ReactRouterLocationSource extends DOM::LocationSource::Range {`
`806`	`806`
`807`	`807`	`private class UseRefDomValueSource extends DOM::DomValueSource::Range {`
`808`	`808`	`UseRefDomValueSource() {`
`809`		`- exists(DataFlow::PropRead current, UseRefStep step, string prop \| current = this \|`
	`809`	`+ exists(DataFlow::PropRead current, UseRefStep step \| current = this \|`
`810`	`810`	`step.step(_, current) and`
`811`		`- current.mayHavePropertyName(prop) and`
`812`		`- prop = "current"`
	`811`	`+ current.mayHavePropertyName("current")`
`813`	`812`	`)`
`814`	`813`	`}`
`815`	`814`	`}`