C#: Address some review comments.

Author: michaelnebel

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependabotProxy.cs

@@ -88,15 +88,20 @@ private DependabotProxy(IDependabotProxyConfiguration config, ILogger logger, Te
                 return null;
             }
 
-            return MakeAux(new DependabotProxyConfiguration(), logger, diagnosticsWriter, tempWorkingDirectory);
+            return Make(new DependabotProxyConfiguration(), logger, diagnosticsWriter, tempWorkingDirectory);
         }
 
-        internal static IDependabotProxy? MakeAux(
+        /// <summary>
+        /// Creates an instance of the Dependabot proxy using the specified configuration.
+        /// Returns null if the proxy cannot be created.
+        /// This overload is exposed primarily to enable platform-independent unit testing.
+        /// </summary>
+        internal static IDependabotProxy? Make(
             IDependabotProxyConfiguration proxyConfig, ILogger logger, IDiagnosticsWriter diagnosticsWriter, TemporaryDirectory tempWorkingDirectory)
         {
             if (string.IsNullOrWhiteSpace(proxyConfig.Host) || string.IsNullOrWhiteSpace(proxyConfig.Port))
             {
-                logger.LogInfo("No Dependabot proxy credentials are configured.");
+                logger.LogDebug("No Dependabot proxy credentials are configured.");
                 return null;
             }
 

csharp/extractor/Semmle.Extraction.Tests/DependabotProxy.cs

@@ -34,13 +34,13 @@ public void TestDependabotProxyCreation1()
             // Setup
             var config = new DependabotConfigurationStub
             {
-                Host = "my.private.server",
+                Host = "localhost",
                 Port = "",
             };
 
             // Execute
             using var tempWorkingDirectory = MakeTemporaryDirectory();
-            using var proxy = DependabotProxy.MakeAux(config, new LoggerStub(), new DiagnosticsWriterStub(), tempWorkingDirectory);
+            using var proxy = DependabotProxy.Make(config, new LoggerStub(), new DiagnosticsWriterStub(), tempWorkingDirectory);
 
             // Verify
             Assert.Null(proxy);
@@ -57,7 +57,7 @@ public void TestDependabotProxyCreation2()
 
             // Execute
             using var tempWorkingDirectory = MakeTemporaryDirectory();
-            using var proxy = DependabotProxy.MakeAux(config, new LoggerStub(), new DiagnosticsWriterStub(), tempWorkingDirectory);
+            using var proxy = DependabotProxy.Make(config, new LoggerStub(), new DiagnosticsWriterStub(), tempWorkingDirectory);
 
             // Verify
             Assert.Null(proxy);
@@ -103,17 +103,17 @@ public void TestDependabotProxyCertificate()
             var config = new DependabotConfigurationStub
             {
                 Port = "8080",
-                Host = "my.private.server",
+                Host = "localhost",
                 Certificate = ExampleCertificate
             };
 
             // Execute
             using var tempWorkingDirectory = MakeTemporaryDirectory();
-            using var proxy = DependabotProxy.MakeAux(config, new LoggerStub(), new DiagnosticsWriterStub(), tempWorkingDirectory);
+            using var proxy = DependabotProxy.Make(config, new LoggerStub(), new DiagnosticsWriterStub(), tempWorkingDirectory);
 
             // Verify
             Assert.NotNull(proxy);
-            Assert.Equal("http://my.private.server:8080", proxy.Address);
+            Assert.Equal("http://localhost:8080", proxy.Address);
             Assert.NotNull(proxy.Certificate);
             Assert.NotNull(proxy.CertificatePath);
         }
@@ -125,13 +125,13 @@ public void TestDependabotRegistryUrls1()
             var config = new DependabotConfigurationStub
             {
                 Port = "8080",
-                Host = "my.private.server",
+                Host = "localhost",
                 RegistryURLs = "Doesn't parse as a JSON list"
             };
 
             // Execute
             using var tempWorkingDirectory = MakeTemporaryDirectory();
-            using var proxy = DependabotProxy.MakeAux(config, new LoggerStub(), new DiagnosticsWriterStub(), tempWorkingDirectory);
+            using var proxy = DependabotProxy.Make(config, new LoggerStub(), new DiagnosticsWriterStub(), tempWorkingDirectory);
 
             // Verify
             Assert.NotNull(proxy);
@@ -145,13 +145,13 @@ public void TestDependabotRegistryUrls2()
             var config = new DependabotConfigurationStub
             {
                 Port = "8080",
-                Host = "my.private.server",
+                Host = "localhost",
                 RegistryURLs = "[ { \"type\": \"nuget_feed\", \"url\": \"https://nuget.pkg.github.com/org/index.json\" } ]"
             };
 
             // Execute
             using var tempWorkingDirectory = MakeTemporaryDirectory();
-            using var proxy = DependabotProxy.MakeAux(config, new LoggerStub(), new DiagnosticsWriterStub(), tempWorkingDirectory);
+            using var proxy = DependabotProxy.Make(config, new LoggerStub(), new DiagnosticsWriterStub(), tempWorkingDirectory);
 
             // Verify
             Assert.NotNull(proxy);
@@ -167,13 +167,13 @@ public void TestDependabotRegistryUrls3()
             var config = new DependabotConfigurationStub
             {
                 Port = "8080",
-                Host = "my.private.server",
+                Host = "localhost",
                 RegistryURLs = "[ { \"type\": \"nuget_feed\", \"url\": \"https://example.com/org/index.json\" }, { \"type\": \"wrong_type\", \"url\": \"https://nuget.pkg.github.com/org/index.json\" } ]"
             };
 
             // Execute
             using var tempWorkingDirectory = MakeTemporaryDirectory();
-            using var proxy = DependabotProxy.MakeAux(config, new LoggerStub(), new DiagnosticsWriterStub(), tempWorkingDirectory);
+            using var proxy = DependabotProxy.Make(config, new LoggerStub(), new DiagnosticsWriterStub(), tempWorkingDirectory);
 
             // Verify
             Assert.NotNull(proxy);