OTEL metrics

[r34son]

Do you have any plans migrating metrics api also to otel?
https://opentelemetry.io/docs/specs/otel/metrics/

This is my nextjs instrumentation logic:

import { init } from '@sentry/nextjs';
import { SENTRY_CAPTURE_RATE, SENTRY_DSN } from 'sentry.constants.mjs';

export async function register() {
  if (process.env.NEXT_RUNTIME === 'nodejs') {
    // https://github.com/getsentry/sentry-javascript/issues/11823
    const { nodeProfilingIntegration } = await import('@sentry/profiling-node');
    init({
      dsn: SENTRY_DSN,
      tracesSampleRate: SENTRY_CAPTURE_RATE,
      profilesSampleRate: SENTRY_CAPTURE_RATE,
      integrations: [nodeProfilingIntegration()],
    });

    const {
      Resource,
      detectResourcesSync,
      envDetector,
      hostDetector,
      processDetector,
    } = await import('@opentelemetry/resources');
    const { SEMRESATTRS_SERVICE_NAME, SEMRESATTRS_SERVICE_VERSION } =
      await import('@opentelemetry/semantic-conventions');
    const { registerInstrumentations } = await import(
      '@opentelemetry/instrumentation'
    );
    const { RuntimeNodeInstrumentation } = await import(
      '@opentelemetry/instrumentation-runtime-node'
    );
    const { MeterProvider } = await import('@opentelemetry/sdk-metrics');
    const { HostMetrics } = await import('@opentelemetry/host-metrics');
    const { PrometheusExporter } = await import(
      '@opentelemetry/exporter-prometheus'
    );

    const { endpoint, port } = PrometheusExporter.DEFAULT_OPTIONS;

    const exporter = new PrometheusExporter({}, () => {
      console.log(
        `prometheus scrape endpoint: http://localhost:${port}${endpoint}`,
      );
    });

    const customResources = new Resource({
      [SEMRESATTRS_SERVICE_NAME]: 'next-app',
      [SEMRESATTRS_SERVICE_VERSION]: process.env.SENTRY_RELEASE,
    });

    const detectedResources = detectResourcesSync({
      detectors: [envDetector, processDetector, hostDetector],
    });

    const resource = detectedResources.merge(customResources);

    const meterProvider = new MeterProvider({ readers: [exporter], resource });

    registerInstrumentations({
      meterProvider,
      instrumentations: [new RuntimeNodeInstrumentation()],
    });

    const hostMetrics = new HostMetrics({
      meterProvider,
      name: 'host-metrics',
    });

    hostMetrics.start();
  }
  if (process.env.NEXT_RUNTIME === 'edge') {
    init({
      dsn: SENTRY_DSN,
      tracesSampleRate: SENTRY_CAPTURE_RATE,
    });
  }
}

It would be great if sentry SDK can abstract some metrics overhead for me

[r34son]

Also you are exposing function to add custom instrumentations https://github.com/getsentry/sentry-javascript/blob/develop/packages/opentelemetry/src/instrumentation.ts
It would be good to have ability to pass meterProvider option to registerInstrumentations from @opentelemetry/instrumentation. After that you can have all metrics collected from all possible instrumentations

[mitsuhiko]

The current line of thinking is that we will support Otel metrics API but it’s unclear if we will make it the recommended API. We currently pay close attention to what’s going on there. We definitely want to support it, but our approach to trace correlation is a bit different so we gotta figure that part out first.