Skip to content

Inconsistency on tags formatting (patchman-client.conf) #850

Description

@macrotex

In patchman-client.conf I see this

# Space delimited tags to send
tags="Server"

However, in the patchman-client shell script I see this:

# Convert tags to JSON array
    local tags_json="[]"
    if [ ! -z "${tags}" ] && [ "${tags}" != "Default" ] ; then
        tags_json=$(echo "${tags}" | tr ',' '\n' | jq -R . | jq -s .)
    fi

Thus, the client is expecting the tags to be in comma-delimited format, at least for JSON responses. When using protocol the tags value used is whatever is defined in the conf file with no parsing.

Which is correct: space-delimited or comma-delimited?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions