From bb0587cdb786ac00ec0bc48d59e2cac11404ef8a Mon Sep 17 00:00:00 2001 From: Alex Castillo Date: Thu, 5 Nov 2026 12:20:10 -0400 Subject: [PATCH] fix(kf-tensorflow): handle RunPolicy without clean_pod_policy _convert_run_policy dereferenced clean_pod_policy.value even though the field defaults to None, so any RunPolicy that omitted it (e.g. only setting ttl_seconds_after_finished) raised AttributeError at serialization time. Guard it like the kf-pytorch and kf-mpi plugins do. Signed-off-by: Alex Castillo --- .../flytekitplugins/kftensorflow/task.py | 4 +++- .../tests/test_tensorflow_task.py | 17 +++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/plugins/flytekit-kf-tensorflow/flytekitplugins/kftensorflow/task.py b/plugins/flytekit-kf-tensorflow/flytekitplugins/kftensorflow/task.py index 60cd0b8472..00fc231b52 100644 --- a/plugins/flytekit-kf-tensorflow/flytekitplugins/kftensorflow/task.py +++ b/plugins/flytekit-kf-tensorflow/flytekitplugins/kftensorflow/task.py @@ -182,7 +182,9 @@ def _convert_replica_spec( def _convert_run_policy(self, run_policy: RunPolicy) -> kubeflow_common.RunPolicy: return kubeflow_common.RunPolicy( - clean_pod_policy=run_policy.clean_pod_policy.value if run_policy.clean_pod_policy.value else None, + clean_pod_policy=run_policy.clean_pod_policy.value + if run_policy.clean_pod_policy and run_policy.clean_pod_policy.value + else None, ttl_seconds_after_finished=run_policy.ttl_seconds_after_finished, active_deadline_seconds=run_policy.active_deadline_seconds, backoff_limit=run_policy.backoff_limit, diff --git a/plugins/flytekit-kf-tensorflow/tests/test_tensorflow_task.py b/plugins/flytekit-kf-tensorflow/tests/test_tensorflow_task.py index 0ae32439d7..b1b253faeb 100644 --- a/plugins/flytekit-kf-tensorflow/tests/test_tensorflow_task.py +++ b/plugins/flytekit-kf-tensorflow/tests/test_tensorflow_task.py @@ -254,3 +254,20 @@ def my_tensorflow_task(x: int, y: str) -> int: assert my_tensorflow_task.resources.limits == Resources() assert my_tensorflow_task.resources.requests == Resources(cpu="1") assert my_tensorflow_task.task_type == "tensorflow" + + +def test_tensorflow_task_run_policy_without_clean_pod_policy(serialization_settings: SerializationSettings): + task_config = TfJob( + worker=Worker(replicas=1), + ps=PS(replicas=0), + chief=Chief(replicas=0), + evaluator=Evaluator(replicas=0), + run_policy=RunPolicy(ttl_seconds_after_finished=100), + ) + + @task(task_config=task_config, requests=Resources(cpu="1")) + def my_tensorflow_task(x: int) -> int: + return x + + custom = my_tensorflow_task.get_custom(serialization_settings) + assert custom["runPolicy"] == {"ttlSecondsAfterFinished": 100}