From 2f986ccca50439882ab089760578ae367c48859b Mon Sep 17 00:00:00 2001 From: Shizuo Fujita Date: Thu, 15 Oct 2026 18:51:15 +0900 Subject: [PATCH] Fall back to REXML when nokogiri is not installed A bare rescue only catches StandardError, so the LoadError from require 'nokogiri' escaped and configure failed with the default 'parser auto'. With 'parser nokogiri', the intended ConfigError was never raised either. Co-Authored-By: Claude Opus 5.5 Signed-off-by: Shizuo Fujita --- lib/fluent/plugin/parser_winevt_sax.rb | 2 +- lib/fluent/plugin/parser_winevt_xml.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/fluent/plugin/parser_winevt_sax.rb b/lib/fluent/plugin/parser_winevt_sax.rb index 382740e..c3a10ca 100644 --- a/lib/fluent/plugin/parser_winevt_sax.rb +++ b/lib/fluent/plugin/parser_winevt_sax.rb @@ -19,7 +19,7 @@ def configure(conf) require 'nokogiri' require 'fluent/plugin/winevt_sax_document_nokogiri' @use_nokogiri = true - rescue + rescue LoadError => e if @parser == :nokogiri raise Fluent::ConfigError, "Nokogiri is required when 'parser nokogiri' is specified, but it isn't installed. " \ diff --git a/lib/fluent/plugin/parser_winevt_xml.rb b/lib/fluent/plugin/parser_winevt_xml.rb index 0c68952..4b2dde2 100644 --- a/lib/fluent/plugin/parser_winevt_xml.rb +++ b/lib/fluent/plugin/parser_winevt_xml.rb @@ -18,7 +18,7 @@ def configure(conf) begin require 'nokogiri' @use_nokogiri = true - rescue + rescue LoadError => e if @parser == :nokogiri raise Fluent::ConfigError, "Nokogiri is required when 'parser nokogiri' is specified, but it isn't installed. " \