From 6223ef414c3e0f7c82ba4d7514d931b49adfffc6 Mon Sep 17 00:00:00 2001 From: Evan Teran Date: Mon, 13 Jul 2026 00:11:49 -0400 Subject: [PATCH] a handful of more signal/slot modernization --- plugins/BinaryInfo/BinaryInfo.cpp | 2 +- src/DialogMemoryRegions.cpp | 22 +++++++++++----------- src/RecentFileManager.cpp | 6 +++--- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/plugins/BinaryInfo/BinaryInfo.cpp b/plugins/BinaryInfo/BinaryInfo.cpp index 08cb28ff1..0fb9fe758 100644 --- a/plugins/BinaryInfo/BinaryInfo.cpp +++ b/plugins/BinaryInfo/BinaryInfo.cpp @@ -72,7 +72,7 @@ QMenu *BinaryInfo::menu(QWidget *parent) { if (!menu_) { menu_ = new QMenu(tr("Binary Info"), parent); - menu_->addAction(tr("&Explore Binary Header"), this, SLOT(exploreHeader())); + menu_->addAction(tr("&Explore Binary Header"), this, &BinaryInfo::exploreHeader); } return menu_; diff --git a/src/DialogMemoryRegions.cpp b/src/DialogMemoryRegions.cpp index 410617a32..efb63d51b 100644 --- a/src/DialogMemoryRegions.cpp +++ b/src/DialogMemoryRegions.cpp @@ -48,20 +48,20 @@ void DialogMemoryRegions::on_regions_table_customContextMenuRequested(const QPoi QMenu menu; auto access_menu = new QMenu(tr("Set Access"), this); - access_menu->addAction(tr("No Access"), this, SLOT(setAccessNone())); // --- - access_menu->addAction(tr("Read Only"), this, SLOT(setAccessR())); // r-- - access_menu->addAction(tr("Write Only"), this, SLOT(setAccessW())); // -w- - access_menu->addAction(tr("Execute Only"), this, SLOT(setAccessX())); // --x - access_menu->addAction(tr("Read/Write"), this, SLOT(setAccessRW())); // rw- - access_menu->addAction(tr("Read/Execute"), this, SLOT(setAccessRX())); // r-x - access_menu->addAction(tr("Write/Execute"), this, SLOT(setAccessWX())); // -wx - access_menu->addAction(tr("Full Access"), this, SLOT(setAccessRWX())); // rwx + access_menu->addAction(tr("No Access"), this, &DialogMemoryRegions::setAccessNone); // --- + access_menu->addAction(tr("Read Only"), this, &DialogMemoryRegions::setAccessR); // r-- + access_menu->addAction(tr("Write Only"), this, &DialogMemoryRegions::setAccessW); // -w- + access_menu->addAction(tr("Execute Only"), this, &DialogMemoryRegions::setAccessX); // --x + access_menu->addAction(tr("Read/Write"), this, &DialogMemoryRegions::setAccessRW); // rw- + access_menu->addAction(tr("Read/Execute"), this, &DialogMemoryRegions::setAccessRX); // r-x + access_menu->addAction(tr("Write/Execute"), this, &DialogMemoryRegions::setAccessWX); // -wx + access_menu->addAction(tr("Full Access"), this, &DialogMemoryRegions::setAccessRWX); // rwx menu.addMenu(access_menu); menu.addSeparator(); - menu.addAction(tr("View in &CPU"), this, SLOT(viewInCpu())); - menu.addAction(tr("View in &Stack"), this, SLOT(viewInStack())); - menu.addAction(tr("View in &Dump"), this, SLOT(viewInDump())); + menu.addAction(tr("View in &CPU"), this, &DialogMemoryRegions::viewInCpu); + menu.addAction(tr("View in &Stack"), this, &DialogMemoryRegions::viewInStack); + menu.addAction(tr("View in &Dump"), this, &DialogMemoryRegions::viewInDump); menu.exec(ui.regions_table->mapToGlobal(pos)); } diff --git a/src/RecentFileManager.cpp b/src/RecentFileManager.cpp index d4ad2c649..199738cd2 100644 --- a/src/RecentFileManager.cpp +++ b/src/RecentFileManager.cpp @@ -87,7 +87,7 @@ void RecentFileManager::clear() { if (menu_) { menu_->clear(); menu_->addSeparator(); - menu_->addAction(tr("Clear &Menu"), this, SLOT(clear())); + menu_->addAction(tr("Clear &Menu"), this, &RecentFileManager::clear); } } @@ -129,13 +129,13 @@ void RecentFileManager::update() { menu_->clear(); for (const auto &file : files_) { - if (QAction *const action = menu_->addAction(formatEntry(file), this, SLOT(itemSelected()))) { + if (QAction *const action = menu_->addAction(formatEntry(file), this, &RecentFileManager::itemSelected)) { action->setData(QVariant::fromValue(file)); } } menu_->addSeparator(); - menu_->addAction(tr("Clear &Menu"), this, SLOT(clear())); + menu_->addAction(tr("Clear &Menu"), this, &RecentFileManager::clear); } }