Skip to content

swt-unselected-tabs-color always takes the gradient path, even for a flat colour #4274

Description

@vogella

CSSPropertyUnselectedTabsSWTHandler.applyCSSProperty:

  • CssPrimitive → renderer.setUnselectedTabsColor(color) + folder.setBackground(color) — solid path
  • CssList → renderer.setUnselectedTabsColor(colors, percents) + folder.setBackground(colors, percents, true) — gradient path

The platform themes always write two stops (css/dark/e4-dark_tabstyle.css:34, css/light/e4-light_tabstyle.css:27 and :39), so they always take the gradient path, in the dark theme the stops are #49484C / #48484C, i.e. visually flat.

This leads to an image creation in SWT which is wasteful. We should use just one color in our CSS files and support that in the handler.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions