Consider using Microsoft.CodeAnalysis 4.x or later

[Youssef1313]

We have some analyzer projects using 3.3.1. We should consider if we want to unify to the same 4.x version.

aspnetcore/eng/Versions.props

Lines 101 to 109 in 92b8fe3

	<!--
	Versions of Microsoft.CodeAnalysis packages referenced by analyzers shipped in the SDK.
	This need to be pinned since they're used in 3.1 apps and need to be loadable in VS 2019.
	-->
	<Analyzer_MicrosoftCodeAnalysisCSharpVersion>3.3.1</Analyzer_MicrosoftCodeAnalysisCSharpVersion>
	<Analyzer_MicrosoftCodeAnalysisCSharpWorkspacesVersion>3.3.1</Analyzer_MicrosoftCodeAnalysisCSharpWorkspacesVersion>
	<!-- Pin the version of the M.CA dependencies that we utilize with a custom version property $(MicrosoftCodeAnalysisVersion_LatestVS) to avoid automatically
	consuming the newest version of the packages when using the $(MicrosoftCodeAnalysisCSharpVersion) properties in source-build. -->
	<MicrosoftCodeAnalysisVersion_LatestVS>4.13.0-3.24613.7</MicrosoftCodeAnalysisVersion_LatestVS>

[Youssef1313]

@marcpopMSFT Do you know if we could end up somehow running these analyzers in older VS versions or on older compiler versions? Or should it be safe to update?

cc @wtgodbe

[marcpopMSFT]

The 3.* analyzers are from 16.*, correct? Current 10 sdks require 18.0 or newer to load so won't load into older VS versions so can't run with the older compilers if that's what you're asking.