Skip to content

Commit c4f3c76

Browse files
ai: apply changes for #870 (2 review threads)
Addresses: - #3600313097 at .github/workflows/engineer-bot-followup.yml:155 - #3600313099 at .github/workflows/engineer-bot.yml:88 Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent b93b527 commit c4f3c76

2 files changed

Lines changed: 18 additions & 3 deletions

File tree

.bot/prompts/engineer/system.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,17 @@ warehouse connection env is set. Run tests through poetry:
7878
- Your E2E test (fastest loop): `poetry run python -m pytest tests/e2e/<file> -k <name>`
7979
- A unit test: `poetry run python -m pytest tests/unit/<file> -k <name>`
8080

81+
**This runner installs `--all-extras`, so the REAL `databricks-sql-kernel` wheel
82+
is present.** The unit suite fakes `databricks_sql_kernel` in `sys.modules`
83+
(`tests/unit/test_kernel_client.py`), which shadows the real wheel in a shared
84+
session — and the `@pytest.mark.realkernel` routing test
85+
(`tests/unit/test_session.py::TestUseKernelRoutesThroughRealWheel`) `pytest.fail`s
86+
loudly when it detects that shadowing. So whenever you run a BROADER unit
87+
selection than a single `-k` test — a whole file, or `tests/unit` — append
88+
`-m "not realkernel"` (matching how `.github/workflows/code-coverage.yml` guards
89+
the same `--all-extras` install). Skipping this produces a confusing false red
90+
that has nothing to do with your fix.
91+
8192
**Always `-k`-filter to your own test** — do NOT run the whole `tests/e2e` suite:
8293
this job provides a live connection but does not seed the full per-run fixture set
8394
the broader suite expects, so unrelated E2E tests would fail or skip and that noise

.github/workflows/engineer-bot-followup.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,13 @@ jobs:
148148
TRIGGER_COMMENT_ID: ${{ github.event.comment.id }}
149149
MODEL_ENDPOINT: https://${{ secrets.DATABRICKS_HOST }}/serving-endpoints/databricks-claude-opus-4-8/invocations
150150
DATABRICKS_TOKEN: ${{ secrets.DATABRICKS_TOKEN }}
151-
# Live-warehouse connection env so a followup fixup can also run the
152-
# REQUIRED E2E repro/verification test (see engineer/system.md). Mirrors
153-
# the author run + code-coverage.yml; job is in `environment: azure-prod`.
151+
# Live-warehouse connection env, provisioned for parity with the author
152+
# run + code-coverage.yml (job is in `environment: azure-prod`). NOTE:
153+
# unlike the author phase, the followup prompt
154+
# (.bot/prompts/engineer-followup/system.md) tells the agent to run only
155+
# the mocked `tests/unit` suite and NOT tests/e2e. These vars are wired
156+
# for consistency with the author run, not an E2E step the followup runs;
157+
# if followups should ever repair/run E2E repros, update that prompt too.
154158
DATABRICKS_SERVER_HOSTNAME: ${{ secrets.DATABRICKS_HOST }}
155159
DATABRICKS_HTTP_PATH: ${{ secrets.TEST_PECO_WAREHOUSE_HTTP_PATH }}
156160
DATABRICKS_CATALOG: peco

0 commit comments

Comments
 (0)