Skip to content

Commit b385dc9

Browse files
ai: apply changes for #862 (1 review thread)
Addresses: - #3599032772 at .github/actions/bot-prelude/action.yml:27
1 parent 800934b commit b385dc9

5 files changed

Lines changed: 20 additions & 19 deletions

File tree

.github/actions/bot-prelude/action.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,13 @@ inputs:
2525
description: 'Bot App private key (PEM) for the same App.'
2626
required: true
2727
engine-ref:
28+
# SINGLE SOURCE OF TRUTH for the engine pin. All four bot workflows route
29+
# through this composite, so the SHA lives here once (overridable per-caller)
30+
# instead of being duplicated — and drifting — across the callers. Bump this
31+
# value to move every bot to a new engine commit; never @main.
2832
description: 'Engine commit SHA (full 40-char) to install.'
29-
required: true
33+
required: false
34+
default: 'd9cb1e63dc31eed550194a29d1cfd7de9c9c793b'
3035
engine-repo:
3136
description: 'owner/name of the engine repo.'
3237
required: false

.github/workflows/engineer-bot-followup.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,10 +102,9 @@ jobs:
102102
with:
103103
app-id: ${{ secrets.ENGINEER_BOT_APP_ID }}
104104
private-key: ${{ secrets.ENGINEER_BOT_APP_PRIVATE_KEY }}
105-
# Pinned engine SHA. DUPLICATED in all four bot workflows
106-
# (engineer-bot{,-followup}.yml, reviewer-bot{,-followup}.yml) — bump
107-
# them in LOCKSTEP or the bots silently run different engine versions.
108-
engine-ref: d9cb1e63dc31eed550194a29d1cfd7de9c9c793b
105+
# Engine pin lives in ONE place: bot-prelude's `engine-ref` default.
106+
# Bump it there to move all four bots in lockstep; override here only
107+
# to run this workflow against a different engine commit.
109108

110109
# Run the follow-up. Inlines the engine's bot-run env contract for
111110
# engineer:followup, plus the authenticated push remote bot-run would set

.github/workflows/engineer-bot.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,9 @@ jobs:
9090
with:
9191
app-id: ${{ secrets.ENGINEER_BOT_APP_ID }}
9292
private-key: ${{ secrets.ENGINEER_BOT_APP_PRIVATE_KEY }}
93-
# Pinned engine SHA. DUPLICATED in all four bot workflows
94-
# (engineer-bot{,-followup}.yml, reviewer-bot{,-followup}.yml) — bump
95-
# them in LOCKSTEP or the bots silently run different engine versions.
96-
engine-ref: d9cb1e63dc31eed550194a29d1cfd7de9c9c793b
93+
# Engine pin lives in ONE place: bot-prelude's `engine-ref` default.
94+
# Bump it there to move all four bots in lockstep; override here only
95+
# to run this workflow against a different engine commit.
9796

9897
- name: Resolve issue + gather context
9998
id: ctx

.github/workflows/reviewer-bot-followup.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,9 @@ jobs:
7777
with:
7878
app-id: ${{ secrets.REVIEW_BOT_APP_ID }}
7979
private-key: ${{ secrets.REVIEW_BOT_APP_PRIVATE_KEY }}
80-
# Pinned engine SHA. DUPLICATED in all four bot workflows
81-
# (engineer-bot{,-followup}.yml, reviewer-bot{,-followup}.yml) — bump
82-
# them in LOCKSTEP or the bots silently run different engine versions.
83-
engine-ref: d9cb1e63dc31eed550194a29d1cfd7de9c9c793b
80+
# Engine pin lives in ONE place: bot-prelude's `engine-ref` default.
81+
# Bump it there to move all four bots in lockstep; override here only
82+
# to run this workflow against a different engine commit.
8483

8584
- name: Run reviewer follow-up
8685
env:

.github/workflows/reviewer-bot.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
# checkout, Setup Python, and the run; bot-prelude mints tokens + Node + installs
99
# the engine.
1010
#
11-
# Engine pin: the SHA below (in bot-prelude's engine-ref input) is the engine
12-
# commit installed; bump it deliberately, never @main.
11+
# Engine pin: the engine commit installed is bot-prelude's `engine-ref` default
12+
# (single source of truth for all four bots); bump it there, never @main.
1313
#
1414
# Auth: PAT-free — bot-prelude mints a short-lived, engine-scoped App token for
1515
# the install (no stored BOT_ENGINE_PAT).
@@ -82,10 +82,9 @@ jobs:
8282
with:
8383
app-id: ${{ secrets.REVIEW_BOT_APP_ID }}
8484
private-key: ${{ secrets.REVIEW_BOT_APP_PRIVATE_KEY }}
85-
# Pinned engine SHA. DUPLICATED in all four bot workflows
86-
# (engineer-bot{,-followup}.yml, reviewer-bot{,-followup}.yml) — bump
87-
# them in LOCKSTEP or the bots silently run different engine versions.
88-
engine-ref: d9cb1e63dc31eed550194a29d1cfd7de9c9c793b
85+
# Engine pin lives in ONE place: bot-prelude's `engine-ref` default.
86+
# Bump it there to move all four bots in lockstep; override here only
87+
# to run this workflow against a different engine commit.
8988

9089
- name: Resolve trigger inputs
9190
id: inputs

0 commit comments

Comments
 (0)