Skip to content

Commit a1b86e3

Browse files
ai: apply changes for #870 (2 review threads)
Addresses: - #3600243617 at .github/workflows/engineer-bot.yml:194 - #3600243618 at .bot/prompts/engineer/system.md:48 Signed-off-by: peco-engineer-bot[bot] <peco-engineer-bot[bot]@users.noreply.github.com>
1 parent e8874df commit a1b86e3

3 files changed

Lines changed: 22 additions & 5 deletions

File tree

.bot/prompts/engineer/system.md

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,16 @@ server should Y"), do NOT infer the expected behavior from the current connector
4545
code — that's how a plausible-but-wrong fix gets a test written to agree with it.
4646
Instead anchor the expected value in an external authority, in this order:
4747
1. the issue's stated expectation and any spec/PEP (e.g. DB-API) it cites;
48-
2. the **reference driver** — for parity questions, `fetch_context_repo
49-
databricks-jdbc` then `grep_context_repo` / `read_context_repo` for the
50-
class/method the issue names, and mirror how the official JDBC driver behaves
51-
(it's the parity ground truth for retry/metadata/type/error semantics). The
52-
clone is lazy + read-only; fetch only when you need it.
48+
2. the **reference driver** — for parity questions, IF a `databricks-jdbc`
49+
context repo is listed as available in your `fetch_context_repo` tool
50+
description, `fetch_context_repo databricks-jdbc` then `grep_context_repo` /
51+
`read_context_repo` for the class/method the issue names, and mirror how the
52+
official JDBC driver behaves (it's the parity ground truth for
53+
retry/metadata/type/error semantics). The clone is lazy + read-only; fetch
54+
only when you need it. If no such context repo is listed as available, do
55+
NOT attempt the fetch — fall back to the issue's stated expectation and any
56+
cited spec, and if parity genuinely can't be resolved without the reference
57+
driver, report `blocked` saying so.
5358
Your E2E test must assert *that* externally-grounded behavior, not the output your
5459
fix happens to produce.
5560

.github/workflows/engineer-bot-followup.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,12 @@ jobs:
9999
uses: ./.github/actions/setup-poetry
100100
with:
101101
python-version: '3.11'
102+
# Match code-coverage.yml's e2e job: install optional extras (notably
103+
# pyarrow, declared optional=true behind the `pyarrow` extra) so the
104+
# agent's REQUIRED live E2E repro test runs against the same runtime as
105+
# the e2e suite it mirrors. Without this, arrow-touching e2e tests
106+
# ModuleNotFoundError/skip instead of failing red-for-the-right-reason.
107+
install-args: "--all-extras"
102108

103109
# setup-poetry runs `poetry lock` (to reconcile the lock with the internal
104110
# JFrog source it injects), which REWRITES tracked poetry.lock / pyproject.toml

.github/workflows/engineer-bot.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,12 @@ jobs:
8080
uses: ./.github/actions/setup-poetry
8181
with:
8282
python-version: '3.11'
83+
# Match code-coverage.yml's e2e job: install optional extras (notably
84+
# pyarrow, declared optional=true behind the `pyarrow` extra) so the
85+
# agent's REQUIRED live E2E repro test runs against the same runtime as
86+
# the e2e suite it mirrors. Without this, arrow-touching e2e tests
87+
# ModuleNotFoundError/skip instead of failing red-for-the-right-reason.
88+
install-args: "--all-extras"
8389

8490
# setup-poetry runs `poetry lock` (to reconcile the lock with the internal
8591
# JFrog source it injects), which REWRITES tracked poetry.lock / pyproject.toml

0 commit comments

Comments
 (0)