feat(bots): select author flow from issue Type; bump engine to d24ca21

Adopt the engine's Issue-Type flow selection (engine PR #107, merged) instead of
running a fixed config-default flow:

- engineer-bot.yml ctx step: fetch the issue via `gh api repos/{o}/{r}/issues/{n}`
  (REST carries `.type.name`; `gh issue view --json type` does not), reject PR
  numbers via `.pull_request`, and derive `--flow` from a pinned Type→flow case
  (`Bug` ⇒ bug-fix, `Feature` ⇒ enhancement; any other/none ⇒ omit).
- author step: pass `--flow` only when derived (empty would fail the CLI's
  `choices`); omitting it keeps the `.bot/config.yaml` `flow: bug-fix` default.
- Bump the pinned engine SHA b6205fb → d24ca21 (includes #107) across all four
  bot workflows so the consumer runs the engine version that ships this behavior.

Note: Issue Types are org-level; databricks-sql-python is org-owned, so this
works. A no-type / other-type issue falls through to the bug-fix config default.

Co-authored-by: Isaac
Signed-off-by: eric-wang-1990 <e.wang@databricks.com>

Author: eric-wang-1990

.github/workflows/engineer-bot-followup.yml

@@ -101,7 +101,7 @@ jobs:
         with:
           app-id: ${{ secrets.ENGINEER_BOT_APP_ID }}
           private-key: ${{ secrets.ENGINEER_BOT_APP_PRIVATE_KEY }}
-          engine-ref: b6205fb502566d617a456ccf3c37f3e4e3072ccd
+          engine-ref: d24ca2171d191a652a67f4f43995f0959c9a5791
 
       # Run the follow-up. Inlines the engine's bot-run env contract for
       # engineer:followup, plus the authenticated push remote bot-run would set

.github/workflows/engineer-bot.yml

@@ -1,8 +1,12 @@
-# Engineer Bot — author (bug-fix).
+# Engineer Bot — author.
 #
-# A maintainer labels a bug-report ISSUE with `engineer-bot`; the bot reproduces
-# the bug with a failing test, fixes the connector code, and opens a PR. Driven
-# by the bug-fix flow + this repo's .bot/ (config + prompts).
+# A maintainer labels an ISSUE with `engineer-bot`; the bot addresses it and opens
+# a PR. The author FLOW is chosen from the issue's TYPE (a GitHub org-level Issue
+# Type): `Bug` ⇒ bug-fix (reproduce with a failing test, then fix); `Feature` ⇒
+# enhancement (smallest correct change); any other type / none ⇒ the repo's
+# .bot/config.yaml `flow:` default. Set the Type BEFORE `engineer-bot` — it's read
+# live when the run starts. Driven by the selected flow + this repo's .bot/
+# (config + prompts).
 #
 # The engineer builds and runs THIS repo's tests, so it needs the connector's
 # deps installed (via setup-poetry) in addition to the engine. Shared setup
@@ -85,7 +89,7 @@ jobs:
         with:
           app-id: ${{ secrets.ENGINEER_BOT_APP_ID }}
           private-key: ${{ secrets.ENGINEER_BOT_APP_PRIVATE_KEY }}
-          engine-ref: b6205fb502566d617a456ccf3c37f3e4e3072ccd
+          engine-ref: d24ca2171d191a652a67f4f43995f0959c9a5791
 
       - name: Resolve issue + gather context
         id: ctx
@@ -104,40 +108,72 @@ jobs:
         run: |
           if [ "$EVENT_NAME" = "workflow_dispatch" ]; then RAW="$INPUT_ISSUE"; else RAW="$EVENT_ISSUE"; fi
           [[ "$RAW" =~ ^[0-9]+$ ]] || { echo "::error::Invalid issue number '$RAW'"; exit 1; }
-          gh issue view "$RAW" --repo "$REPO" --json number,title,url,body > "$RUNNER_TEMP/issue.json"
+          # `gh issue view --json` does NOT expose the issue TYPE field, so fetch
+          # via the REST API (which carries `.type.name`). Body/title/url still
+          # come from the same JSON. Issue Types are an ORG-level feature; a repo
+          # without them configured returns `.type == null` (⇒ no --flow ⇒ the
+          # engine uses the .bot/config.yaml `flow:` default).
+          gh api "repos/$REPO/issues/$RAW" > "$RUNNER_TEMP/issue.json"
+          # The REST issues endpoint resolves PR numbers too (PRs are issues in
+          # the REST model), unlike `gh issue view <pr-number>` which errored.
+          # Keep rejecting PR numbers cleanly: real issues have `.pull_request == null`.
+          [ "$(jq -r '.pull_request // "null"' "$RUNNER_TEMP/issue.json")" = "null" ] \
+            || { echo "::error::#$RAW is a pull request, not an issue"; exit 1; }
           jq -r '.body // ""' "$RUNNER_TEMP/issue.json" > "$RUNNER_TEMP/issue_body.txt"
           TITLE="$(jq -r '.title // ""' "$RUNNER_TEMP/issue.json")"
-          URL="$(jq -r '.url // ""' "$RUNNER_TEMP/issue.json")"
+          URL="$(jq -r '.html_url // ""' "$RUNNER_TEMP/issue.json")"
           {
             echo "ISSUE_NUMBER=$RAW"
             echo "ISSUE_URL=$URL"
           } >> "$GITHUB_ENV"
           echo "issue_number=$RAW" >> "$GITHUB_OUTPUT"
+          # Derive the author flow from the issue's TYPE (read LIVE here, so a type
+          # set AFTER this fetch is not seen — set the type BEFORE `engineer-bot`).
+          # The type→flow MAPPING is pinned (not "use the type name as the flow")
+          # so an arbitrary custom org type can never select an engine flow:
+          #   Bug ⇒ bug-fix (red→green TDD)   Feature ⇒ enhancement (small-change)
+          # Any other type (incl. Task) or no type ⇒ emit nothing ⇒ the author
+          # step omits --flow ⇒ the engine uses .bot/config.yaml `flow:`.
+          TYPE="$(jq -r '.type.name // ""' "$RUNNER_TEMP/issue.json")"
+          case "$TYPE" in
+            Bug)     echo "flow=bug-fix"     >> "$GITHUB_OUTPUT" ;;
+            Feature) echo "flow=enhancement" >> "$GITHUB_OUTPUT" ;;
+          esac
           DELIM="GHEOF_$(date +%s%N)${RANDOM}"
           if printf '%s' "$TITLE" | grep -qF "$DELIM"; then
             echo "::error::title delimiter collision — refusing to write \$GITHUB_ENV"; exit 1
           fi
           { echo "ISSUE_TITLE<<$DELIM"; printf '%s\n' "$TITLE"; echo "$DELIM"; } >> "$GITHUB_ENV"
 
-      - name: Run author (bug-fix)
+      - name: Run author
         id: author
         # Run from RUNNER_TEMP so the engine-rendered prompt's context file
         # (issue_body.txt, resolved against cwd) is read from there and the
         # checkout stays clean — publish's leftover check fails on any untracked
         # path in the repo. TEST_REPO_ROOT points the agent's working tree (and
         # the .bot/ lookup) at the checkout; ISSUE_NUMBER/TITLE/URL come from
-        # $GITHUB_ENV (the bot config's author.env_tokens). Flow comes from
-        # .bot/config.yaml (`flow: bug-fix`), so no --flow is passed.
+        # $GITHUB_ENV (the bot config's author.env_tokens).
+        #
+        # The author FLOW is chosen from the issue TYPE by the ctx step above
+        # (Bug ⇒ bug-fix, Feature ⇒ enhancement). We pass --flow ONLY when that
+        # step derived one: an empty --flow would be rejected by the CLI's
+        # `choices`, and omitting it lets the engine fall back to the
+        # .bot/config.yaml `flow:` default (no/other type, or type-set-late case).
         working-directory: ${{ runner.temp }}
         env:
           MODEL_ENDPOINT: https://${{ secrets.DATABRICKS_HOST }}/serving-endpoints/databricks-claude-opus-4-8/invocations
           DATABRICKS_TOKEN: ${{ secrets.DATABRICKS_TOKEN }}
           TEST_REPO_ROOT: ${{ github.workspace }}
           RUNNER_TEMP: ${{ runner.temp }}
-        run: >-
-          python -m databricks_bot_engine.engineer_bot.run --phase author
-          --system-prompt "$GITHUB_WORKSPACE/.bot/prompts/engineer/system.md"
-          --user-prompt "$GITHUB_WORKSPACE/.bot/prompts/engineer/user.md"
+          FLOW: ${{ steps.ctx.outputs.flow }}
+        run: |
+          args=(
+            --phase author
+            --system-prompt "$GITHUB_WORKSPACE/.bot/prompts/engineer/system.md"
+            --user-prompt "$GITHUB_WORKSPACE/.bot/prompts/engineer/user.md"
+          )
+          [ -n "$FLOW" ] && args+=(--flow "$FLOW")
+          python -m databricks_bot_engine.engineer_bot.run "${args[@]}"
 
       - name: Open / update fix PR
         id: publish

.github/workflows/reviewer-bot-followup.yml

@@ -77,7 +77,7 @@ jobs:
         with:
           app-id: ${{ secrets.REVIEW_BOT_APP_ID }}
           private-key: ${{ secrets.REVIEW_BOT_APP_PRIVATE_KEY }}
-          engine-ref: b6205fb502566d617a456ccf3c37f3e4e3072ccd
+          engine-ref: d24ca2171d191a652a67f4f43995f0959c9a5791
 
       - name: Run reviewer follow-up
         env:

.github/workflows/reviewer-bot.yml

@@ -82,7 +82,7 @@ jobs:
         with:
           app-id: ${{ secrets.REVIEW_BOT_APP_ID }}
           private-key: ${{ secrets.REVIEW_BOT_APP_PRIVATE_KEY }}
-          engine-ref: b6205fb502566d617a456ccf3c37f3e4e3072ccd
+          engine-ref: d24ca2171d191a652a67f4f43995f0959c9a5791
 
       - name: Resolve trigger inputs
         id: inputs