Skip to content

Commit 8bb4b16

Browse files
chore(bots): drop hardcoded flow-aware templates from .bot/config.yaml
Post-#110 the engine resolves branch_prefix / pr_title_template / commit_message_template per-flow, and its bug-fix defaults are byte-identical to what we hardcoded (branch `ai/bugfix-issue-`, title/commit `fix: …`). Omitting them is behavior-preserving for our bug-fix flow AND future-proofs other flows (a task/Feature run gets the engine's `feat:` templates instead of a misleading `fix:` prefix). pr_body_template stays (no engine default); flow: bug-fix unchanged. Also fix a stale comment in engineer-bot-followup.yml (checkout step referenced the removed bot-run composite). (Engine pin d24ca21 + Type-based flow selection already on this branch.) Signed-off-by: Eric Wang <e.wang@databricks.com> Co-authored-by: Isaac Signed-off-by: eric-wang-1990 <e.wang@databricks.com>
1 parent ecf0cf4 commit 8bb4b16

2 files changed

Lines changed: 11 additions & 5 deletions

File tree

.bot/config.yaml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,25 @@
44
# .bot/prompts/review/system.md); only the engineer-bot is config-driven.
55
name: databricks_sql_python_bugfix
66
marker_namespace: engineer-bot-python
7-
branch_prefix: ai/bugfix-issue-
87
bot_login_prefix: peco-engineer-bot
98
max_replies_per_thread: 5
109

10+
# branch_prefix / pr_title_template / commit_message_template are OMITTED: they
11+
# are flow-aware templates, and the engine's per-flow defaults already match what
12+
# we'd hardcode (bug-fix ⇒ branch `ai/bugfix-issue-`, title/commit `fix: …`).
13+
# Omitting them keeps that behavior AND future-proofs other flows — a task/Feature
14+
# run gets the engine's `feat:` templates instead of a misleading `fix:` prefix.
15+
# Add a string (all flows) or a {flow: template} map here only to override.
16+
1117
# safe_path denylist. Only the always-on hard-denied prefixes apply here
1218
# (.git/ and .gitleaksignore), seeded by the engine regardless — so this key is
1319
# omitted. Everything else under the repo root is writable; the safeguard is the
1420
# human PR-review gate, not a tool-layer block. Reviewers MUST scrutinize any
1521
# agent-authored diff reaching .github/, .bot/, or pyproject.toml. To hard-block
1622
# a path at the tool layer, add it under `denied_subpaths:` (repo-relative).
1723

18-
# Filled from the tracking ISSUE the maintainer labelled.
19-
pr_title_template: "fix: {issue_title} (#{issue_number})"
20-
commit_message_template: "fix: resolve #{issue_number}"
24+
# Filled from the tracking ISSUE the maintainer labelled. (pr_body_template has no
25+
# engine default, so it stays required here.)
2126
pr_body_template: |-
2227
## Summary
2328

.github/workflows/engineer-bot-followup.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ jobs:
7777
steps:
7878
# Checkout FIRST (remote action) so the local `./` composites resolve.
7979
# Check out the PR head BRANCH (not the merge ref) so fixups push back to
80-
# it; bot-run re-establishes the authenticated push remote.
80+
# it. persist-credentials:false; the run step below sets an authenticated
81+
# push remote from the minted App token.
8182
- name: Checkout PR head branch
8283
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
8384
with:

0 commit comments

Comments
 (0)