Commit 1de4ab7
committed
fix(bots): accept CONTRIBUTOR in engineer-followup comment-path gate
A maintainer with PRIVATE org membership is reported as
`author_association: CONTRIBUTOR` in the pull_request_review_comment webhook
payload (even though REST shows MEMBER). The followup gate only accepted
OWNER/MEMBER/COLLABORATOR, so such a maintainer's review comments SILENTLY failed
the gate — the job skipped with no error and the bot never engaged.
Observed on #868: a review comment (MEMBER per REST) triggered a followup run
that skipped, because the payload association was CONTRIBUTOR (membership private).
Add CONTRIBUTOR. Low risk: this path already requires a non-fork, OPEN,
`engineer-bot`-labeled PR (a maintainer-applied opt-in). Mirrors the engine fix
(databricks/databricks-bot-engine#120).
Signed-off-by: eric-wang-1990 <e.wang@databricks.com>
Co-authored-by: Isaac1 parent e23254d commit 1de4ab7
1 file changed
Lines changed: 10 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | | - | |
38 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
39 | 45 | | |
40 | 46 | | |
41 | 47 | | |
| |||
47 | 53 | | |
48 | 54 | | |
49 | 55 | | |
50 | | - | |
| 56 | + | |
51 | 57 | | |
52 | 58 | | |
53 | 59 | | |
| |||
0 commit comments