From cd1e6f2e9884597149246fc710d68b1e50c32711 Mon Sep 17 00:00:00 2001 From: m-this <52073029+m-this@users.noreply.github.com> Date: Mon, 2 Nov 2026 13:46:34 +0100 Subject: [PATCH] fix(frankenphp): point pkg-config at the buildroot on Windows - caddy-cbrotli pulls brotli through `#cgo pkg-config`, and the Windows go build never set PKG_CONFIG_PATH - so a build that resolves brotli stops at `Package libbrotlicommon was not found` --- src/Package/Target/php/frankenphp.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Package/Target/php/frankenphp.php b/src/Package/Target/php/frankenphp.php index eed182c7f..be77e615e 100644 --- a/src/Package/Target/php/frankenphp.php +++ b/src/Package/Target/php/frankenphp.php @@ -333,6 +333,8 @@ public function buildFrankenphpForWindows(TargetPackage $package, PackageInstall 'PATH' => $clang_dir . ';' . getenv('PATH'), 'CGO_CFLAGS' => clean_spaces($cgo_cflags), 'CGO_LDFLAGS' => $cgo_ldflags, + // caddy-cbrotli finds brotli through #cgo pkg-config. + 'PKG_CONFIG_PATH' => BUILD_LIB_PATH . '\pkgconfig', ]; InteractiveTerm::setMessage('Building frankenphp: ' . ConsoleColor::yellow('embedding Windows metadata'));