Skip to content

Commit 463bf75

Browse files
committed
.clang-tidy: disabled modernize-use-auto for now
test.cpp: fixed `misc-include-cleaner` clang-tidy warning .clang-tidy: disabled some warnings only fixable when targeting newer C++ standards make it possibly to actually override the C++ standard in CMake
1 parent 37c7feb commit 463bf75

3 files changed

Lines changed: 14 additions & 1 deletion

File tree

.clang-tidy

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,15 @@ Checks: >
3232
-modernize-avoid-c-arrays,
3333
-modernize-loop-convert,
3434
-modernize-pass-by-value,
35+
-modernize-use-auto,
36+
-modernize-use-designated-initializers,
3537
-modernize-use-nodiscard,
38+
-modernize-use-ranges,
39+
-modernize-use-starts-ends-with,
3640
-modernize-use-trailing-return-type,
3741
-readability-avoid-nested-conditional-operator,
3842
-readability-braces-around-statements,
43+
-readability-container-contains,
3944
-readability-function-cognitive-complexity,
4045
-readability-function-size,
4146
-readability-implicit-bool-conversion,

CMakeLists.txt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
11
cmake_minimum_required (VERSION 3.10)
22
project (simplecpp LANGUAGES CXX)
33

4-
set(CMAKE_CXX_STANDARD 11)
4+
set(CMAKE_CXX_STANDARD 11 CACHE STRING "C++ standard to use")
55
set(CMAKE_CXX_STANDARD_REQUIRED ON)
66

7+
if(CMAKE_CXX_STANDARD LESS 11)
8+
message(FATAL_ERROR "C++ standard was set to ${CMAKE_CXX_STANDARD} but 11 is required as a minimum")
9+
endif()
10+
711
include(CheckCXXCompilerFlag)
812

913
if (WIN32)

test.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@
1818
#include <utility>
1919
#include <vector>
2020

21+
#ifdef __cpp_lib_string_view
22+
#include <string_view>
23+
#endif
24+
2125
#ifndef SIMPLECPP_TEST_SOURCE_DIR
2226
#error "SIMPLECPP_TEST_SOURCE_DIR is not defined."
2327
#endif

0 commit comments

Comments
 (0)