test

Author: ludviggunne

gui/test/xmlreportv2/testxmlreportv2.cpp

@@ -21,7 +21,9 @@
 #include "erroritem.h"
 #include "xmlreportv2.h"
 
+#include <QFile>
 #include <QList>
+#include <QTemporaryDir>
 #include <QtTest>
 
 void TestXmlReportV2::readXml() const
@@ -53,4 +55,39 @@ void TestXmlReportV2::readXml() const
     QCOMPARE(item2.message, QString("Mismatching allocation and deallocation: k"));
 }
 
+void TestXmlReportV2::writeXmlEscaping() const
+{
+    QTemporaryDir dir;
+    const QString path = dir.path() + "/results.xml";
+
+    ErrorItem item;
+    item.errorId = "id";
+    item.severity = Severity::style;
+    item.summary = "\"x\" & <y> &quot;";
+    item.message = item.summary;
+    QErrorPathItem loc;
+    loc.file = "a&b.cpp";
+    loc.line = 1;
+    item.errorPath << loc;
+    {
+        XmlReportV2 report(path, QString());
+        QVERIFY(report.create());
+        report.writeHeader();
+        report.writeError(item);
+        report.writeFooter();
+    }
+
+    QFile file(path);
+    QVERIFY(file.open(QIODevice::ReadOnly));
+    QVERIFY(file.readAll().contains("msg=\"&quot;x&quot; &amp; &lt;y&gt; &amp;quot;\""));
+
+    XmlReportV2 report(path, QString());
+    QVERIFY(report.open());
+    const QList<ErrorItem> errors = report.read();
+    QCOMPARE(errors.size(), 1);
+    QCOMPARE(errors[0].summary, item.summary);
+    QCOMPARE(errors[0].message, item.message);
+    QCOMPARE(errors[0].errorPath[0].file, loc.file);
+}
+
 QTEST_MAIN(TestXmlReportV2)

gui/test/xmlreportv2/testxmlreportv2.h

@@ -23,4 +23,5 @@ class TestXmlReportV2 : public QObject {
 
 private slots:
     void readXml() const;
+    void writeXmlEscaping() const;
 };