Skip to content
This repository was archived by the owner on Mar 27, 2019. It is now read-only.

Added an error incase the component.json file is missing the "name" attribute#241

Closed
vicapow wants to merge 1 commit into
componentjs:masterfrom
vicapow:master
Closed

Added an error incase the component.json file is missing the "name" attribute#241
vicapow wants to merge 1 commit into
componentjs:masterfrom
vicapow:master

Conversation

@vicapow

@vicapow vicapow commented Jan 23, 2013

Copy link
Copy Markdown

otherwise, the build process seems to run fine but build.js will have

    require.register("undefined/index.js", function(exports, require, module){

Comment thread bin/component-build

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we handle this recursively (in component/builder.js), not just the root conf, and maybe something like <path-to-component.json> "name" missing

@vicapow

vicapow commented Jan 23, 2013

Copy link
Copy Markdown
Author

okay. to do this I have to edit the component-builder package but I can't seem to find it on github. where can I find the repo?

@vicapow

vicapow commented Jan 23, 2013

Copy link
Copy Markdown
Author

ah! nm. here it is. https://github.com/component/builder.js

@vicapow

vicapow commented Jan 23, 2013

Copy link
Copy Markdown
Author

submitted a pull request to component/builder.js

componentjs/builder.js#65

@vicapow vicapow closed this Jan 23, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants