Disable automatic sentry cron monitoring even if sentry_sdk is installed

[coredumperror]

Bug Description

If your project has sentry_sdk installed for its own use, django-crontask's cron monitoring cannot be disabled by any means known to me, even if you don't install it with the optional [sentry] dependency.

Expected Behavior

It should be possible to disable crontask's internal cron monitoring, in order to roll one's own monitoring code. Especially since crontask doesn't let the user set any of the advanced cron monitor configuration that sentry_sdk provides.

I'd make a PR for this, but it feels like the "right" solution is to detect whether the [sentry] optional dependency was installed, and I'm not sure how to do that, or if that's even possible. An alternative would be a Django setting, e.g. CRONTASK["ENABLE_SENTRY_MONITORING"], which would default to True.

Version

1.2.0

[codingjoe]

Hi @coredumperror,

Yes, currently there isn't a great way to disable the monitoring. I am hesitant to use settings; I'd prefer an argument for the cron decorator, something like:

@cron("* * * * *", sentry_monitor_config=False)
@task
def some_task(): ...

Where the default None will be as is, False will disable reporting, and any other value will be a custom config.

What do you think?

Cheers,
Joe

[coredumperror]

Hmmm, I'm not super into using two different "Falsey" values to mean different things, but I suppose that's the most pythonic way to do it. I would probably do it with sentry_monitor_config being the default config dict, but that's discouraged in Python. Though I guess if you could make the default value an immutable dict, that would be pythonic...

Either way, it looks like you already implemented this. I'm sure that method will work fine.