Skip to content

Commit ee0e7d3

Browse files
DavertMikclaude
andcommitted
ci: run WebDriver tests on Chrome 140 for BiDi download events
Chrome 131 (selenium/standalone-chrome:4.27) never emits browsingContext.downloadWillBegin, so seeFileDownloaded cannot detect downloads there. Chrome 140 (4.35) does. Document the requirement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 07b9ce4 commit ee0e7d3

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

‎.github/workflows/webdriver.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
node-version: [22.x]
2727

2828
steps:
29-
- run: docker run -d --net=host --shm-size=2g selenium/standalone-chrome:4.27
29+
- run: docker run -d --net=host --shm-size=2g selenium/standalone-chrome:4.35
3030
- uses: actions/checkout@v6
3131
- name: Use Node.js ${{ matrix.node-version }}
3232
uses: actions/setup-node@v6

‎lib/helper/WebDriver.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2216,7 +2216,8 @@ class WebDriver extends Helper {
22162216
/**
22172217
* {{> seeFileDownloaded }}
22182218
*
2219-
* Requires `bidiProtocol` enabled. Files are saved by the browser into its own download directory.
2219+
* Requires `bidiProtocol` enabled and a browser that emits BiDi `browsingContext.downloadWillBegin` (verified on Chrome 140; Chrome 131 does not emit it).
2220+
* Files are saved by the browser into its own download directory.
22202221
*/
22212222
async seeFileDownloaded(fileName, sec = null) {
22222223
const waitTimeout = sec ? sec * 1000 : this.options.waitForTimeout

0 commit comments

Comments
 (0)