From 550bca6bdc1b71ce47d43b60bc8c9a345f7f50a4 Mon Sep 17 00:00:00 2001 From: mehmetkr-31 Date: Sun, 9 Aug 2026 22:55:36 +0300 Subject: [PATCH] ci: run the finalize-release shell tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `.github/scripts/test-finalize-release.sh` covers the release finalizer's tag and version parsing, and nothing invokes it — not CI, not the Makefile, not another script: $ grep -rn "test-finalize-release" .github/ Makefile \ | grep -v "^.github/scripts/test-finalize-release.sh" (no matches) Add a `make test-finalize-release` target and a standalone CI job that calls it. No toolchain and no network, so it runs in parallel with everything else and finishes in seconds. The target mirrors the `test-arcup` pattern in #247, which covers the other orphaned suite (`arcup/test_arcup.sh`) more thoroughly than an earlier revision of this branch did. Scoped down to the finalize-release half so the two compose instead of colliding: #247 anchors its job after `proto` and its target before `test-all`, this one anchors before `docker-build` and after `test-all`, so the diffs do not overlap. `test-all` deliberately left alone — it is a single line both PRs would otherwise touch. Happy to add this target to it in a follow-up once #247 lands. Closes #248 Co-Authored-By: Claude Opus 5 --- .github/workflows/ci.yml | 13 +++++++++++++ Makefile | 5 +++++ 2 files changed, 18 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b655f8fa..abc24d0c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -244,6 +244,19 @@ jobs: - name: Run Foundry tests run: forge test -vvv --gas-report + # --------------------------------------------------------------------------- + # Release finalizer: shell unit tests (standalone, no deps) + # --------------------------------------------------------------------------- + + release-finalizer: + name: Release Finalizer + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 + + - name: Run finalize-release shell tests + run: make test-finalize-release + # --------------------------------------------------------------------------- # Docker Images # --------------------------------------------------------------------------- diff --git a/Makefile b/Makefile index f7c48922..ef0db0dc 100644 --- a/Makefile +++ b/Makefile @@ -141,6 +141,11 @@ test-all: test-it test-unit-contract ## Run all tests @echo running all tests... make smoke LAUNCH_ARGS="--frozen --healthy-retry=130" +.PHONY: test-finalize-release +test-finalize-release: ## Run release finalizer shell tests + @echo running finalize-release tests... + @bash .github/scripts/test-finalize-release.sh + .PHONY: cov-unit cov-unit: genesis ## Run unit tests with coverage rm -f $(COV_FILE)