fix: bump Docker subnet base to avoid conflicts with common VPS networks#117
Open
oxatik wants to merge 1 commit into
Open
fix: bump Docker subnet base to avoid conflicts with common VPS networks#117oxatik wants to merge 1 commit into
oxatik wants to merge 1 commit into
Conversation
SUBNET_INDEX_BASE was set to 21, causing arc_testnet_default to claim 172.21.0.0/16 which conflicts with networks commonly found on VPS environments (docker_default at 172.20, monitoring leftovers at 172.21). Changes: - Bump SUBNET_INDEX_BASE from 21 to 23 in subnets.rs - Update hardcoded blockscout subnet from 172.20 to 172.22 in templates - Update unit tests to reflect new base index Fixes: make testnet failing with 'invalid pool request: Pool overlaps with other one on this address space'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
make testnetfails with:failed to create network arc_testnet_blockscout: invalid pool request:
Pool overlaps with other one on this address space
SUBNET_INDEX_BASE = 21 causes Arc to claim 172.21.0.0/16 and 172.20.0.0/16,
which are commonly occupied on VPS environments by:
Fix
Tested
Verified
make testnetruns successfully on Ubuntu 22.04 VPS withexisting Docker networks occupying 172.17–172.21.