From 4719ff9d0f50ead873eef2abad40aee0ea9d7d05 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Armando=20Rodr=C3=ADguez?= <127134616+armando-rodriguez-cko@users.noreply.github.com> Date: Thu, 16 Jul 2026 11:59:12 +0200 Subject: [PATCH 1/2] fix(forward): update secrets collection path to /secrets The forward secrets collection endpoints (create, list) moved from /forward/secrets to /secrets, while the per-item endpoint remains at /forward/secrets/{name}. Reflects the incomplete rename in the swagger spec. --- lib/checkout_sdk/forward/create_secret_request.rb | 2 +- lib/checkout_sdk/forward/forward_client.rb | 4 ++-- spec/checkout_sdk/forward/forward_secrets_spec.rb | 10 +++++----- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/checkout_sdk/forward/create_secret_request.rb b/lib/checkout_sdk/forward/create_secret_request.rb index 7747c43..3600ef1 100644 --- a/lib/checkout_sdk/forward/create_secret_request.rb +++ b/lib/checkout_sdk/forward/create_secret_request.rb @@ -2,7 +2,7 @@ module CheckoutSdk module Forward - # Request body for POST /forward/secrets. + # Request body for POST /secrets. # # @!attribute name # @return [String] Secret name (1-64 alphanumeric chars). diff --git a/lib/checkout_sdk/forward/forward_client.rb b/lib/checkout_sdk/forward/forward_client.rb index 8fc769b..c0aee8d 100644 --- a/lib/checkout_sdk/forward/forward_client.rb +++ b/lib/checkout_sdk/forward/forward_client.rb @@ -25,13 +25,13 @@ def get(forward_id) # @param [Hash, CreateSecretRequest] create_secret_request def create_secret(create_secret_request) - api_client.invoke_post(build_path(FORWARD, SECRETS), + api_client.invoke_post(build_path(SECRETS), sdk_authorization, create_secret_request) end def get_secrets - api_client.invoke_get(build_path(FORWARD, SECRETS), sdk_authorization) + api_client.invoke_get(build_path(SECRETS), sdk_authorization) end # @param [String] name diff --git a/spec/checkout_sdk/forward/forward_secrets_spec.rb b/spec/checkout_sdk/forward/forward_secrets_spec.rb index 8d90975..e2bacf7 100644 --- a/spec/checkout_sdk/forward/forward_secrets_spec.rb +++ b/spec/checkout_sdk/forward/forward_secrets_spec.rb @@ -10,27 +10,27 @@ end describe '#create_secret' do - it 'POSTs typed DTO to forward/secrets' do + it 'POSTs typed DTO to secrets' do req = CheckoutSdk::Forward::CreateSecretRequest.new req.name = 'sk_test' req.value = 'secret' expect(api_client_mock).to receive(:invoke_post) - .with('forward/secrets', 'secret_key', req).and_return('r') + .with('secrets', 'secret_key', req).and_return('r') expect(client.create_secret(req)).to eq('r') end it 'also accepts a raw Hash' do h = { 'name' => 's', 'value' => 'v' } expect(api_client_mock).to receive(:invoke_post) - .with('forward/secrets', 'secret_key', h).and_return('r') + .with('secrets', 'secret_key', h).and_return('r') expect(client.create_secret(h)).to eq('r') end end describe '#get_secrets' do - it 'GETs forward/secrets' do + it 'GETs secrets' do expect(api_client_mock).to receive(:invoke_get) - .with('forward/secrets', 'secret_key').and_return('r') + .with('secrets', 'secret_key').and_return('r') expect(client.get_secrets).to eq('r') end end From 8e6a4eb044340b9678f83214ce8558becd4cc477 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Armando=20Rodr=C3=ADguez?= <127134616+armando-rodriguez-cko@users.noreply.github.com> Date: Thu, 23 Jul 2026 19:20:50 +0200 Subject: [PATCH 2/2] fix(forward): move secret item path to /secrets/{name} (INT-1666) Swagger 2026-07-20 completed the rename: PATCH/DELETE moved from /forward/secrets/{name} to /secrets/{name}. Update update_secret/delete_secret, the request doc comment and the specs to drop the /forward prefix. --- lib/checkout_sdk/forward/forward_client.rb | 4 ++-- lib/checkout_sdk/forward/update_secret_request.rb | 2 +- spec/checkout_sdk/forward/forward_secrets_spec.rb | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/checkout_sdk/forward/forward_client.rb b/lib/checkout_sdk/forward/forward_client.rb index c0aee8d..c19d76c 100644 --- a/lib/checkout_sdk/forward/forward_client.rb +++ b/lib/checkout_sdk/forward/forward_client.rb @@ -37,14 +37,14 @@ def get_secrets # @param [String] name # @param [Hash, UpdateSecretRequest] update_secret_request def update_secret(name, update_secret_request) - api_client.invoke_patch(build_path(FORWARD, SECRETS, name), + api_client.invoke_patch(build_path(SECRETS, name), sdk_authorization, update_secret_request) end # @param [String] name def delete_secret(name) - api_client.invoke_delete(build_path(FORWARD, SECRETS, name), + api_client.invoke_delete(build_path(SECRETS, name), sdk_authorization) end end diff --git a/lib/checkout_sdk/forward/update_secret_request.rb b/lib/checkout_sdk/forward/update_secret_request.rb index 033e18a..bbb2716 100644 --- a/lib/checkout_sdk/forward/update_secret_request.rb +++ b/lib/checkout_sdk/forward/update_secret_request.rb @@ -2,7 +2,7 @@ module CheckoutSdk module Forward - # Request body for PATCH /forward/secrets/{name}. + # Request body for PATCH /secrets/{name}. # # @!attribute value # @return [String] New plaintext secret value (max 8KB). diff --git a/spec/checkout_sdk/forward/forward_secrets_spec.rb b/spec/checkout_sdk/forward/forward_secrets_spec.rb index e2bacf7..6c5f7cc 100644 --- a/spec/checkout_sdk/forward/forward_secrets_spec.rb +++ b/spec/checkout_sdk/forward/forward_secrets_spec.rb @@ -36,18 +36,18 @@ end describe '#update_secret' do - it 'PATCHes typed DTO to forward/secrets/{name}' do + it 'PATCHes typed DTO to secrets/{name}' do req = CheckoutSdk::Forward::UpdateSecretRequest.new expect(api_client_mock).to receive(:invoke_patch) - .with('forward/secrets/my_name', 'secret_key', req).and_return('r') + .with('secrets/my_name', 'secret_key', req).and_return('r') expect(client.update_secret('my_name', req)).to eq('r') end end describe '#delete_secret' do - it 'DELETEs forward/secrets/{name}' do + it 'DELETEs secrets/{name}' do expect(api_client_mock).to receive(:invoke_delete) - .with('forward/secrets/my_name', 'secret_key').and_return('r') + .with('secrets/my_name', 'secret_key').and_return('r') expect(client.delete_secret('my_name')).to eq('r') end end