From 8d90b54aec8a9de20d794a136872fab868a99ffc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kr=C3=A6n=20Hansen?= Date: Fri, 17 Jul 2026 22:31:37 +0200 Subject: [PATCH] ci: pin CMake on macOS test-ios and test-ferric-apple-triplets These two jobs build the weak-node-api Apple framework via cmake-rn on macos-latest but never pinned CMake, so they hit the same 4.2.x FRAMEWORK-vs-HEADERS-file-set error that broke unit-tests (#374) and weak-node-api-tests (#375): CMake Error: The file set "HEADERS" is incompatible with the "FRAMEWORK" target "weak-node-api". test-ios fails downstream ("Expected an XCFramework at weak-node-api/build/Release/weak-node-api.xcframework") because the framework never builds. Both run on pushes to main, so they keep main red. Pin CMake to the project's 4.1.2 on both, matching the other jobs. Interim workaround; proper CMakeLists fix tracked in #376. Co-Authored-By: Claude Opus 4.8 (1M context) Claude-Session: https://claude.ai/code/session_01UCN2h9xbyn4yhxfVZyMzAm --- .github/workflows/check.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 4f8a519e..2c85f58f 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -168,6 +168,11 @@ jobs: with: packages: tools platform-tools ndk;${{ env.NDK_VERSION }} - run: rustup target add x86_64-linux-android aarch64-linux-android armv7-linux-androideabi i686-linux-android aarch64-apple-ios-sim + # macOS runners ship a newer CMake than the project supports; pin it to match the version used elsewhere in CI + - name: Install compatible CMake version + uses: jwlawson/actions-setup-cmake@v2 + with: + cmake-version: ${{ env.CMAKE_VERSION }} - run: npm ci - run: npm run bootstrap env: @@ -340,6 +345,11 @@ jobs: distribution: "temurin" - run: rustup target add x86_64-apple-darwin x86_64-apple-ios aarch64-apple-ios aarch64-apple-ios-sim - run: rustup toolchain install nightly --component rust-src + # macOS runners ship a newer CMake than the project supports; pin it to match the version used elsewhere in CI + - name: Install compatible CMake version + uses: jwlawson/actions-setup-cmake@v2 + with: + cmake-version: ${{ env.CMAKE_VERSION }} - run: npm ci - run: npm run build - name: Build weak-node-api for all Apple architectures