Skip to content

Troubleshoot "dangling pointer" warning in iterator_interface.t.cpp #15

Description

@camio

This warning shows up in the CI job. It was originally pointed out by #13 (review)

/home/runner/work/iterator_interface/iterator_interface/src/beman/iterator_interface26/iterator_interface.t.cpp:5:
/home/runner/work/iterator_interface/iterator_interface/src/beman/iterator_interface26/iterator_interface.t.cpp: In member function ‘virtual void beman::iterator_interface26::IteratorTest_OperatorArrow_Test::TestBody()’:
/home/runner/work/iterator_interface/iterator_interface/src/beman/iterator_interface26/iterator_interface.t.cpp:117:20: warning: using a dangling pointer to an unnamed temporary [-Wdangling-pointer=]
  117 |     ASSERT_EQ(ai->f(), 3);
      |               ~~~~~^~
In file included from /home/runner/work/iterator_interface/iterator_interface/include/beman/iterator_interface26/iterator_interface.hpp:8,
                 from /home/runner/work/iterator_interface/iterator_interface/src/beman/iterator_interface26/iterator_interface.t.cpp:2:
/home/runner/work/iterator_interface/iterator_interface/include/beman/iterator_interface26/detail/stl_interfaces/iterator_interface.hpp:559:59: note: unnamed temporary defined here
  559 |           return detail::make_pointer<pointer, reference>(*derived());
      |                                                           ^~~~~~~~~~

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions