Repository navigation
Commit 760cdc8
committed
fix: CI runs on release PRs without a close and reopen
Release Please opened and updated its PR with GITHUB_TOKEN. GitHub holds the
pull_request run such an event creates until it expires, so the required
All checks passed never reported, and every release needed someone to close
and reopen the PR after its last update.
The workflow now mints a token from an org-owned GitHub App
(actions/create-github-app-token, scoped to contents and pull-requests
write, the same permissions the job's GITHUB_TOKEN has) and hands it to
Release Please, so its PR events start CI like anyone else's. The App is
configured once per org: RELEASE_PLEASE_APP_CLIENT_ID as a variable,
RELEASE_PLEASE_APP_PRIVATE_KEY as a secret. Until then the workflow falls
back to GITHUB_TOKEN and warns, so a new library still releases the way it
does today. setup_repo.py warns when a repository cannot see the two names.
Closes #121 parent df3262d commit 760cdc8
4 files changed
Lines changed: 63 additions & 0 deletions
File tree
- scripts
- template/.github/workflows
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| 54 | + | |
| 55 | + | |
54 | 56 | | |
55 | 57 | | |
56 | 58 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
81 | 100 | | |
82 | 101 | | |
83 | 102 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
| |||
111 | 113 | | |
112 | 114 | | |
113 | 115 | | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
114 | 132 | | |
115 | 133 | | |
116 | 134 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
15 | 38 | | |
16 | 39 | | |
| 40 | + | |
17 | 41 | | |
18 | 42 | | |
0 commit comments