Add test for improving robustness.

Author: beacoder

python_agent_harness/tui.py

@@ -517,12 +517,17 @@ def _build_history_rows(self) -> list[Any]:
             elif m.role == "assistant":
                 body = m.text()
                 collapsed_reasoning = False
-                if m.reasoning:
+                if isinstance(m.reasoning, str) and m.reasoning:
                     stripped = _strip_reasoning(body, m.reasoning)
                     if stripped != body:
                         body = stripped
                         collapsed_reasoning = True
                 body = _tail_lines(_strip_final_check(body), 12)
+                if collapsed_reasoning:
+                    # the reasoning streamed live while it was being
+                    # produced; once it is done it collapses to a marker
+                    # so it doesn't eat the visible-row budget
+                    rows.append(Text("💭 ...", style="dim"))
                 if m.tool_calls:
                     for tc in m.tool_calls:
                         args = tc.arguments
@@ -538,11 +543,6 @@ def _build_history_rows(self) -> list[Any]:
                             params = ""
                         label = f"🤖 {tc.name}({params})" if params else f"🤖 {tc.name}"
                         rows.append(Text(label, style="cyan"))
-                if collapsed_reasoning:
-                    # the reasoning streamed live while it was being
-                    # produced; once it is done it collapses to a marker
-                    # so it doesn't eat the visible-row budget
-                    rows.append(Text("💭 ...", style="dim"))
                 if body.strip():
                     rows.append(Markdown(f"**assistant:** {body}"))
             elif m.role == "tool":

tests/test_client.py

@@ -1,10 +1,18 @@
 """Client streaming tests against the in-process fake OpenAI server."""
 
+import os
+import sys
 import unittest
 
 from python_agent_harness.client import Client
+from python_agent_harness.models import Message
 
-from fake_openai_server import serve
+# `discover -s tests` puts the tests dir on sys.path, but a direct
+# `-m unittest tests.test_client` invocation does not — make the
+# sibling helper importable either way.
+sys.path.insert(0, os.path.dirname(__file__))
+
+from fake_openai_server import serve  # noqa: E402
 
 
 def make_client() -> Client:
@@ -22,9 +30,7 @@ def test_reasoning_content_streamed_and_captured(self):
         c = make_client()
         deltas: list[str] = []
         msg, usage = c.chat(
-            [__import__("python_agent_harness.models", fromlist=["Message"]).Message(
-                role="user", content="hi"
-            )],
+            [Message(role="user", content="hi")],
             on_delta=deltas.append,
         )
         self.assertEqual("".join(deltas), "thinking hardHello world")

tests/test_tui.py

@@ -241,6 +241,43 @@ def test_reasoning_collapsed_marker_shows_even_without_answer(self):
         self.assertIn("💭 ...", out)
         self.assertNotIn("pensive thoughts", out)
 
+    def test_reasoning_marker_before_tool_call_label(self):
+        """For a reasoned tool call the marker comes first: reasoning
+        happened before the tool invocation, so it renders above the
+        tool label."""
+        tui, buf = make_tui()
+        tui.session.last_messages = [
+            Message(role="user", content="read the file"),
+            Message(
+                role="assistant", content="let me check the path first",
+                reasoning="let me check the path first",
+                tool_calls=[ToolCall(id="1", name="Read", arguments="{}")],
+            ),
+            Message(role="tool", content="file contents", tool_call_id="1", name="Read"),
+        ]
+        tui.console.print(tui._render_conversation())
+        out = buf.getvalue()
+        self.assertIn("💭 ...", out)
+        self.assertIn("🤖 Read", out)
+        self.assertLess(out.index("💭 ..."), out.index("🤖 Read"))
+        self.assertNotIn("let me check", out)
+
+    def test_non_string_reasoning_does_not_crash(self):
+        """A malformed (non-string) reasoning value must not raise —
+        display falls back to the raw content."""
+        tui, buf = make_tui()
+        tui.session.last_messages = [
+            Message(role="user", content="go"),
+            Message(
+                role="assistant", content="full text here",
+                reasoning=["not", "a", "string"],
+            ),
+        ]
+        tui.console.print(tui._render_conversation())
+        out = buf.getvalue()
+        self.assertIn("full text here", out)
+        self.assertNotIn("💭 ...", out)
+
     def test_strip_reasoning(self):
         """_strip_reasoning removes the leading reasoning prefix and
         leaves non-matching text untouched."""