Fix title generation issue.

Author: beacoder

python_agent_harness/agent.py

@@ -130,7 +130,11 @@ def _inject_pending_prompts(self) -> None:
             if self.session.plan_mode.is_plan and not self.harness_injected:
                 self.messages.insert(
                     len(self.messages),
-                    Message(role="user", content=self.session.plan_mode.plan_reminder()),
+                    Message(
+                        role="user",
+                        content=self.session.plan_mode.plan_reminder(),
+                        injected=True,
+                    ),
                 )
                 self.harness_injected = True
             return
@@ -147,7 +151,9 @@ def _inject_pending_prompts(self) -> None:
             if last.role == "user" and isinstance(last.content, str) and not last.tool_call_id:
                 insert_at = len(self.messages) - 1
         for i, text in enumerate(prompts):
-            self.messages.insert(insert_at + i, Message(role="user", content=text))
+            self.messages.insert(
+                insert_at + i, Message(role="user", content=text, injected=True)
+            )
 
     # ------------------------------------------------------------------
     # compaction
@@ -362,6 +368,11 @@ def run(self) -> str | None:
                     # file — the next turn's save would overwrite it
                     # without ever containing it.
                     session.auto_save(salvaged, self.system)
+                    # Elisp parity: the title is generated on the first
+                    # save, not only on clean completion — an
+                    # interrupted session still gets a meaningful name
+                    # (one-shot; no-op when already titled/pending).
+                    session.generate_session_title()
                 else:
                     # Loop finished: give the session a meaningful title
                     # from the first real user message (one-shot; no-op
@@ -449,7 +460,7 @@ def safe_delta(text: str) -> None:
                 pending=bool(self.pending),
             ):
                 self.messages.append(
-                    Message(role="user", content=config.NUDGE_MESSAGE)
+                    Message(role="user", content=config.NUDGE_MESSAGE, injected=True)
                 )
                 continue
             if self.error:

python_agent_harness/agent_session.py

@@ -387,12 +387,14 @@ def _mode_prompts(self) -> dict[str, str]:
     def remember_user_text(self, messages: list) -> None:
         """Remember the last real user message for session-title generation.
 
-        Skips harness-injected nudges so a title is never generated from
-        "Review the original user request and the Task Completion Rules…".
+        Skips harness-injected messages (nudges, plan/build-switch
+        reminders, queued mode prompts — flagged ``injected``) so a
+        title is never generated from "Review the original user request
+        and the Task Completion Rules…" or a mode-switch reminder.
         """
         nudge = config.NUDGE_MESSAGE
         for m in reversed(messages):
-            if m.role == "user" and m.text() != nudge:
+            if m.role == "user" and not m.injected and m.text() != nudge:
                 self.store.remember_first_user_message(m.text())
                 break
 
@@ -411,6 +413,13 @@ def generate_session_title(self) -> None:
         Mirrors gptel-agent-harness--generate-session-title: one-shot per
         session (guarded by store.title / title_pending); on success the
         session file is renamed to <title>_<TS>.md.
+
+        Reasoning models answer with a reasoning preamble; the client
+        merges it ahead of the real answer, so it is stripped here or
+        the first 50 chars of the reasoning would become the session
+        name.  The session temperature is passed so the title request
+        matches the buffer settings (elisp parity) instead of the API
+        default.
         """
         store = self.store
         if store.title or store.title_pending:
@@ -425,9 +434,18 @@ def generate_session_title(self) -> None:
 
             system = read_prompt_file("title.txt")
             resp, _ = self.client.chat_sync(
-                [Msg(role="user", content=first)], system=system
+                [Msg(role="user", content=first)],
+                system=system,
+                temperature=self.temperature,
             )
             title = resp.text()
+            if resp.reasoning:
+                r = resp.reasoning
+                if title.startswith(r):
+                    title = title[len(r):]
+                else:
+                    title = title.replace(r, "")
+                title = title.strip()
             if title:
                 store.apply_title(title)
                 if self.store.title:

python_agent_harness/models.py

@@ -41,6 +41,7 @@ class Message:
     tool_call_id: str | None = None
     reasoning: str | None = None
     name: str | None = None
+    injected: bool = False  # harness-injected (nudge/plan/build-switch), not user input
 
     def to_api(self) -> dict[str, Any]:
         d: dict[str, Any] = {"role": self.role}

tests/test_agent.py

@@ -994,6 +994,38 @@ def tracking_chat_sync(messages, system=None, temperature=None,
         AgentLoop(session, messages=[Message(role="user", content="hi there")]).run()
         self.assertEqual(len(session.client.chat_sync_calls), 1)
 
+    def test_title_strips_reasoning_and_uses_session_temperature(self):
+        """Reasoning content merged by the client must not leak into the
+        title (it would become the first 50 chars of the session name),
+        and the title request must use the session temperature."""
+        session = RecordingSession()
+        session.tools_enabled = False
+        session.client.script = ["bye"]
+        session.client.chat_sync_calls = []
+
+        def chat_sync(messages, system=None, temperature=None,
+                      max_tokens=None, reasoning_effort=None):
+            session.client.chat_sync_calls.append(temperature)
+            return (
+                Message(
+                    role="assistant",
+                    content=("We need to generate a title for the conversation. "
+                             "Adding MCP support to agent harness"),
+                    reasoning="We need to generate a title for the conversation.",
+                ),
+                Usage(),
+            )
+
+        session.client.chat_sync = chat_sync
+        with mock.patch(
+            "python_agent_harness.prompts.read_prompt_file",
+            return_value="TITLE-PROMPT",
+        ):
+            loop = AgentLoop(session, messages=[Message(role="user", content="add mcp")])
+            loop.run()
+        self.assertEqual(session.store.title, "Adding-MCP-support-to-agent-harness")
+        self.assertEqual(session.client.chat_sync_calls, [session.temperature])
+
     def test_no_title_for_empty_first_message(self):
         session = RecordingSession()
         session.tools_enabled = False

tests/test_subagent_isolation.py

@@ -134,6 +134,34 @@ def test_nudge_not_used_as_title_source(self):
         ])
         self.assertEqual(s.store.first_user_message(), "real request")
 
+    def test_injected_prompts_not_used_as_title_source(self):
+        """Harness-injected messages (nudge, plan/build-switch reminders,
+        queued mode prompts) must never become the first-user message
+        used for session-title generation."""
+        s = make_session(RecClient([]))
+        s.remember_user_text([
+            Message(role="user", content="real request"),
+            Message(role="assistant", content="ok"),
+            Message(
+                role="user",
+                content="<system-reminder>\nYour operational mode has changed "
+                        "from plan to build.\n</system-reminder>",
+                injected=True,
+            ),
+        ])
+        self.assertEqual(s.store.first_user_message(), "real request")
+
+    def test_only_injected_messages_yield_no_title_source(self):
+        """When every user message is harness-injected there is no real
+        first-user message to title from."""
+        s = make_session(RecClient([]))
+        s.remember_user_text([
+            Message(role="user", content="plan reminder", injected=True),
+            Message(role="assistant", content="ok"),
+            Message(role="user", content="nudge", injected=True),
+        ])
+        self.assertIsNone(s.store.first_user_message())
+
     def test_subagent_does_not_touch_shared_context_accounting(self):
         """The sub-agent's rounds must not update the shared context
         ratio or calibration factor: its payload (fresh context) is