Skip to content

Preserve workspace context in generated manifest-trust commands #2187

Description

@codeforester

Goal

Make generated manifest-trust commands self-contained for the workspace they came from.

Background

basectl workspace onboarding --workspace <path> --manifest <path> emits a per-repository trust command from workspace_onboarding.py as basectl trust allow <project> --manifest-sha256 <digest>. The command omits --workspace, even though trust resolution accepts that option to find the named project.

When the workspace is not the default workspace.root or the BASE_HOME parent, and the user copies the generated command from another directory, the command can fail to find the project or resolve a same-named project in a different workspace. Other generated workspace commands include explicit workspace or path context, but the trust guidance does not.

Scope

  • Workspace onboarding trust guidance
  • Trust status and blocked-command guidance that uses the same command formatter
  • Tests and documentation for explicit non-default workspaces

Acceptance Criteria

  • Onboarding text and JSON trust commands include sufficient explicit workspace and manifest context to resolve the intended project.
  • Trust status and blocked-command guidance remain valid when the originating command used an explicit workspace.
  • Tests execute generated commands from a non-default workspace and cover same-named projects in separate workspaces.
  • Default-workspace invocation and manifest digest enforcement retain their current behavior.

Validation

  • Focused workspace onboarding and trust tests
  • An end-to-end fixture using --workspace from outside the workspace directory
  • env -u BASE_HOME ./bin/base-test
  • git diff --check

Non-Goals

  • No change to manifest trust policy or the meaning of a manifest digest.
  • No automatic trust approval.

Project Fields

  • Status: Backlog
  • Priority: P2
  • Area: Workspace
  • Initiative: Workspace Handling
  • Size: S
  • Milestone: v1.10.0

Agent Assignment

  • Human first; the command output contract should be confirmed before implementation.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething is not working

Type

No type

Projects

  • Status
    In Progress

Relationships

None yet

Development

No branches or pull requests

Issue actions