Audit: adversarial SQL-generation edge cases

[smiggleworth]

Purpose

Audit task, not a bug report — produces a scenario list, doesn't fix anything.

Closed issues #12 ("compileKeyedSql corrupts string literals containing :name-shaped text") and #13 ("literal() emits invalid SQL for non-finite numbers") show this category has real yield in SQL generation specifically.

Procedure

Construct and test adversarial SQL-generation inputs:

• Values containing text that looks like the library's own bind-parameter syntax (re-verify compileKeyedSql corrupts string literals containing :name-shaped text #12's fix against variants: escaped colons, colons inside already-quoted strings, colons in JSON-typed column values)
• Non-finite/edge numeric literals beyond NaN/Infinity (re-verify literal() emits invalid SQL for non-finite numbers (NaN/Infinity) #13): -0, very large BigInt-range integers, numbers requiring more precision than IEEE-754 doubles provide
• User-supplied LIKE/ILIKE patterns containing wildcard characters, once No helper for escaping LIKE/ILIKE wildcard characters in user-supplied search input #26's escape helper exists — confirm it's actually used correctly in a realistic query
• Identifiers (table/column names) containing characters requiring quoting/escaping
• A WHERE clause built from a fully empty condition set (zero filters applied) — confirm it doesn't silently produce WHERE 1=1-equivalent behavior unless explicitly intended

Definition of Done

• Table: scenario | ✅ test exists and passes / 🔗 gap filed.
• compileKeyedSql corrupts string literals containing :name-shaped text #12, literal() emits invalid SQL for non-finite numbers (NaN/Infinity) #13 explicitly re-verified with the expanded variant list, not assumed still fixed.
• All items above covered.
• No row left unmarked.

[smiggleworth]

Audit matrix (PR #38):

Scenario	Result
#12: placeholders inside strings, escaped-colon text, casts, and JSON-shaped bound values	✅ regression passes
#13: NaN and infinities	✅ existing rejection tests pass
-0 and Number.MAX_SAFE_INTEGER literals	✅ exact compilation tests pass
Beyond-safe-integer precision	🔗 #39 filed
Realistic escaped LIKE on SQLite	✅ adapter test passes
ILIKE compilation and PostgreSQL-only contract	✅ SQL/schema tests pass
Quotes/reserved words inside identifiers	✅ expanded quoting test passes
Empty condition set	✅ explicitly compiles to invalid () rather than an implicit match-all predicate

No row is unmarked; the one unresolved precision policy is tracked in #39.