From 4b17568c2c64bebceaf4785a2062ecf04b7dea59 Mon Sep 17 00:00:00 2001 From: Fabricio Duarte Date: Thu, 3 Aug 2023 16:11:14 -0300 Subject: [PATCH 1/2] Infer template settings in the deploy VM wizard --- ui/src/views/compute/DeployVM.vue | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/ui/src/views/compute/DeployVM.vue b/ui/src/views/compute/DeployVM.vue index bb94c87db740..63ab690a1adb 100644 --- a/ui/src/views/compute/DeployVM.vue +++ b/ui/src/views/compute/DeployVM.vue @@ -1789,11 +1789,17 @@ export default { if (template) { var size = template.size / (1024 * 1024 * 1024) || 0 // bytes to GB this.dataPreFill.minrootdisksize = Math.ceil(size) - this.defaultBootType = this.template?.details?.UEFI ? 'UEFI' : '' - this.fetchBootModes(this.defaultBootType) - this.defaultBootMode = this.template?.details?.UEFI - this.updateTemplateLinkedUserData(this.template.userdataid) - this.userdataDefaultOverridePolicy = this.template.userdatapolicy + this.updateTemplateLinkedUserData(template.userdataid) + this.userdataDefaultOverridePolicy = template.userdatapolicy + this.form.dynamicscalingenabled = template.isdynamicallyscalable + this.defaultBootType = template.details?.UEFI ? 'UEFI' : 'BIOS' + this.form.boottype = this.defaultBootType + this.fetchBootModes(this.form.boottype) + this.defaultBootMode = template.details?.UEFI || this.options.bootModes?.[0]?.id || undefined + this.form.bootmode = this.defaultBootMode + this.form.iothreadsenabled = template.details?.iothreads ? template.details.iothreads === 'enabled' : null + this.form.iodriverpolicy = template.details?.['io.policy'] + this.form.keyboard = template.details?.keyboard } } else if (name === 'isoid') { this.templateConfigurations = [] From b8fa50664b8b5c869367fa811794e6467ba79f45 Mon Sep 17 00:00:00 2001 From: Fabricio Duarte Date: Wed, 23 Aug 2023 16:21:05 -0300 Subject: [PATCH 2/2] Change how the UI infers iothreadsenabled --- ui/src/views/compute/DeployVM.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/src/views/compute/DeployVM.vue b/ui/src/views/compute/DeployVM.vue index 63ab690a1adb..80bb9960dbf7 100644 --- a/ui/src/views/compute/DeployVM.vue +++ b/ui/src/views/compute/DeployVM.vue @@ -1797,7 +1797,7 @@ export default { this.fetchBootModes(this.form.boottype) this.defaultBootMode = template.details?.UEFI || this.options.bootModes?.[0]?.id || undefined this.form.bootmode = this.defaultBootMode - this.form.iothreadsenabled = template.details?.iothreads ? template.details.iothreads === 'enabled' : null + this.form.iothreadsenabled = template.details && Object.prototype.hasOwnProperty.call(template.details, 'iothreads') this.form.iodriverpolicy = template.details?.['io.policy'] this.form.keyboard = template.details?.keyboard }