Isolated network is shutdown even when there are running VMs on it

[weizhouapache]

in some cases, the isolated network is shutdown even when there running VMs on it. due to it

• the VR is stopped
• the vlan is released

As a workaround, to avoid the issue, user has to update the network to persistent, t

update network_offerings set is_persistent = 1 where traffic_type='Guest' and guest_type='Isolated';

The issue is that, the nics_count in op_networks table is changed to 0, which is wrong sometimes.
We should add check on running/migrating/stopping VMs as well, before shutting down an isolated network, which is similar as

cloudstack/server/src/main/java/com/cloud/network/NetworkModelImpl.java

Lines 2564 to 2567 in 3d7281d

	if (_nicDao.countNicsForStartingVms(networkId) > 0) {
	s_logger.debug("Network id=" + networkId + " is not ready for GC as it has vms that are Starting at the moment");
	return false;
	}

ISSUE TYPE

• Bug Report

COMPONENT NAME

CLOUDSTACK VERSION

4.18

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

[zap51]

I thought of reporting this as we've been affected multiple times on v4.16.1.0 as well.

[shwstppr]

@weizhouapache can you please provide some reproduction steps to verify the PR?

[weizhouapache]

@weizhouapache can you please provide some reproduction steps to verify the PR?

@shwstppr
To simulate the wrong value of nics_count, update the op_networks.nics_count for an isolated network to 0, then wait for the GC..

[shwstppr]

Linked PR is merged #8204
Closing this