From 1f3e54976a4bbea5b5efa2caff132ef2e6e7837d Mon Sep 17 00:00:00 2001 From: aoirint Date: Sun, 8 Nov 2026 02:08:30 +0900 Subject: [PATCH] chore(skills): update shared skills to d7e4e238 Co-authored-by: Codex --- .../commit-message-quality-check/SKILL.md | 4 ++- .agents/skills/github-workflow/SKILL.md | 8 +++--- .../references/remote-commit.md | 6 ++++- .agents/skills/prose-quality-check/SKILL.md | 6 +++-- .../references/status-wording.md | 5 ++++ THIRD_PARTY_NOTICES.md | 4 +-- apm.lock.yaml | 26 +++++++++---------- apm.yml | 2 +- 8 files changed, 38 insertions(+), 23 deletions(-) diff --git a/.agents/skills/commit-message-quality-check/SKILL.md b/.agents/skills/commit-message-quality-check/SKILL.md index 0bdcd25..5bf4fc5 100644 --- a/.agents/skills/commit-message-quality-check/SKILL.md +++ b/.agents/skills/commit-message-quality-check/SKILL.md @@ -25,7 +25,9 @@ Reference: ## Workflow 1. Read the proposed message and, when available, the staged diff or - commit diff it describes. + commit diff it describes. Use `prose-quality-check` for the complete subject + and body, including wording reused from templates, earlier attempts, or a + PR. Format and payload parity do not establish wording quality. 2. For a GitHub squash-merge message, require the exact canonical PR title and number suffix in the subject and verify it is passed to the merge operation. Before any squash merge or other remote commit creation, use diff --git a/.agents/skills/github-workflow/SKILL.md b/.agents/skills/github-workflow/SKILL.md index b018333..dc14f58 100644 --- a/.agents/skills/github-workflow/SKILL.md +++ b/.agents/skills/github-workflow/SKILL.md @@ -116,9 +116,11 @@ create, update, upload, push, or release operation. ### Pull requests 1. Identify the artifact: title, body, review, reply, thread note, or squash - merge. For titles, enforce - `[optional scope][optional !]: ` and use - `commit-message-quality-check` for type and breaking-change notation. + merge. Before creating or updating it, use `prose-quality-check` for its + full text, including PR descriptions and wording reused from templates or + earlier attempts. For titles, enforce + `[optional scope][optional !]: ` with + `commit-message-quality-check`. 2. Before diagnosing an automated dependency or update pull request, compare its proposed state with the current integration branch's authoritative manifests, lock graph, and relevant published artifact. Treat the bot branch diff --git a/.agents/skills/github-workflow/references/remote-commit.md b/.agents/skills/github-workflow/references/remote-commit.md index 693fd41..e267009 100644 --- a/.agents/skills/github-workflow/references/remote-commit.md +++ b/.agents/skills/github-workflow/references/remote-commit.md @@ -23,7 +23,11 @@ their own workflows; they do not require merge preparation. private-resource identifiers or existence disclosures to a public or potentially public destination. 3. For a GitHub PR squash merge, obtain the canonical PR title and number from - GitHub. Require the subject to be exactly ` (#)`. + GitHub and review its wording with `commit-message-quality-check` before + freezing the merge payload. If it needs correction, update the PR title + within the authorized scope and read it back first; do not silently diverge + the squash subject from the PR title. Require the subject to be exactly + ` (#)`. Pass that exact value through the merge command's `--subject` option; a candidate file or CLI default is insufficient. 4. Resolve the exact PR head SHA and pass it with `--match-head-commit` when diff --git a/.agents/skills/prose-quality-check/SKILL.md b/.agents/skills/prose-quality-check/SKILL.md index 3359d80..22b8700 100644 --- a/.agents/skills/prose-quality-check/SKILL.md +++ b/.agents/skills/prose-quality-check/SKILL.md @@ -3,7 +3,8 @@ name: prose-quality-check description: >- Review or revise explanatory prose for readability, local structure, audience fit, self-contained context, and preserved nuance. Use for wording - in documentation, comments, release notes, issues, pull requests, changelogs, handoff notes, + in documentation, comments, release notes, issues, pull requests, commit messages, + changelogs, handoff notes, and Agent Skills after the document's purpose and factual ownership are known. Use domain-architecture-docs-workflow instead for repository-wide document maps, canonical ownership, technical evidence, coverage, or migration. @@ -122,7 +123,8 @@ For the rationale and limits of external guidance, consult history or readers need it to update usage, interpret a release, or avoid a concrete transition risk. 3. Assess status and process wording by the information it adds in context. - This applies to body text, headings, names, filenames, and version labels. + This applies to body text, headings, PR titles, commit subjects, names, + filenames, and version labels. - Treat "verified," "reviewed," "approved," "adopted," "adapted," and equivalents in other languages as review cues, not banned words or interchangeable states. Omit a label that adds no useful distinction, diff --git a/.agents/skills/prose-quality-check/references/status-wording.md b/.agents/skills/prose-quality-check/references/status-wording.md index 8d5cd76..544a243 100644 --- a/.agents/skills/prose-quality-check/references/status-wording.md +++ b/.agents/skills/prose-quality-check/references/status-wording.md @@ -25,6 +25,11 @@ not the presence of a particular word. Use the version or proposed change, or state the pending decision when readers need it. Preserve an actual approval of the same revision when supported and relevant. +- A PR title or commit subject such as "update reviewed dependencies" usually + needs only "update dependencies." Put relevant review evidence in the body + or review record rather than decorating the change summary. Retain status + when changing it is the work itself, such as "mark release as approved," + and preserve required `Reviewed-by` trailers. - "Get approval before publishing" needs an approver if readers cannot tell whose decision is required. "Ask the user to review the draft. Publish only after approval" already identifies the approver; repeating "by the user" diff --git a/THIRD_PARTY_NOTICES.md b/THIRD_PARTY_NOTICES.md index 5482b4f..6e918fd 100644 --- a/THIRD_PARTY_NOTICES.md +++ b/THIRD_PARTY_NOTICES.md @@ -27,9 +27,9 @@ that are present in that checkout. - Source: [aoirint/skills](https://github.com/aoirint/skills), selected from `.apm/skills/` - Pinned commit: - [`1bbdf247da61492e8c1531f341aae400a04b9503`](https://github.com/aoirint/skills/tree/1bbdf247da61492e8c1531f341aae400a04b9503) + [`d7e4e238f6aa4f80b1be13194a0e291bc18aef0f`](https://github.com/aoirint/skills/tree/d7e4e238f6aa4f80b1be13194a0e291bc18aef0f) - Deployed paths: `.agents/skills/{apm-workflow,changelog-workflow,code-quality-check,commit-message-quality-check,docker-quality-check,git-worktree-workflow,github-workflow,gitignore-workflow,prose-quality-check,python-quality-check,release-note-workflow,security-check}/` -- License: [MIT](https://github.com/aoirint/skills/blob/1bbdf247da61492e8c1531f341aae400a04b9503/LICENSE) +- License: [MIT](https://github.com/aoirint/skills/blob/d7e4e238f6aa4f80b1be13194a0e291bc18aef0f/LICENSE) - Copyright: Copyright (c) 2026 aoirint - Cooldown: the maintainer requested immediate adoption of this exact direct diff --git a/apm.lock.yaml b/apm.lock.yaml index 80a54ea..70e30c4 100644 --- a/apm.lock.yaml +++ b/apm.lock.yaml @@ -4,8 +4,8 @@ dependencies: - repo_url: aoirint/skills name: skills host: github.com - resolved_commit: 1bbdf247da61492e8c1531f341aae400a04b9503 - resolved_ref: 1bbdf247da61492e8c1531f341aae400a04b9503 + resolved_commit: d7e4e238f6aa4f80b1be13194a0e291bc18aef0f + resolved_ref: d7e4e238f6aa4f80b1be13194a0e291bc18aef0f version: 0.0.0 package_type: apm_package deployed_files: @@ -122,7 +122,7 @@ dependencies: .agents/skills/code-quality-check/agents/openai.yaml: sha256:69a8a75579e3b47dc69a176417b97441adf81bc54984d3f6bc114e47a68bc9b3 .agents/skills/code-quality-check/references/avoiding-overengineering.md: sha256:51d42dc39ad47c4f3b908caa0b1fad8835acc516fc5ce6c917733dd410201342 .agents/skills/commit-message-quality-check/README.md: sha256:c23949080d05f47cce728410ca3190225397aa41ac2015c6f02ee478ec412a24 - .agents/skills/commit-message-quality-check/SKILL.md: sha256:cbe89b115e778b2417abf5fb15d98b2d1403c3ea0c99bf5ce9a0a65bef0cd6d7 + .agents/skills/commit-message-quality-check/SKILL.md: sha256:7b238a28221ed66fbbcdf22533403434f615eaed6a0153f5b94cbb290bb2c1cb .agents/skills/commit-message-quality-check/agents/openai.yaml: sha256:faffd948a0989dcfc87dcd3b0580c4a7003d01ef436e66dab9f280df57de652c .agents/skills/docker-quality-check/README.md: sha256:912a73d3de06babc6eed1ecdaf275139ae465797083dc5427affb54d00c57bf0 .agents/skills/docker-quality-check/SKILL.md: sha256:85b24dafab008013de4edada0ab17defd1bd06ac879b3a0342648620b4e56cce @@ -138,22 +138,22 @@ dependencies: .agents/skills/git-worktree-workflow/SKILL.md: sha256:cb69640580964636669f5f60c0d97a4f1e6c7b20d3466695ffa35ab2efcca450 .agents/skills/git-worktree-workflow/agents/openai.yaml: sha256:3eb9da73e7a041e77d82f0d5c3a8c67e914575cff8651b71d077db30fe3da99a .agents/skills/github-workflow/README.md: sha256:5d23c667c4b4aedfdad8110690ac0a08cb9f91b91b6e75b8769a12f497324bae - .agents/skills/github-workflow/SKILL.md: sha256:e48d27f4c7f0fa5ec0efe944994fcad8eb2083e586bfbf720dda19bb3941acc1 + .agents/skills/github-workflow/SKILL.md: sha256:27ab6a9e3ce9a330084410978b8b77695bd8c1414cbb392f77b90938c62a097b .agents/skills/github-workflow/agents/openai.yaml: sha256:1f792d6b510760ad131a4b4d077dfc84da1cdee4c30efc8e47d3e92aac939e6c .agents/skills/github-workflow/references/fallback-pr-body.md: sha256:b98239e7d4cdddd8e267ab155f4e4c38fcc514526d9a32f13fcd5b21a1c07eb2 - .agents/skills/github-workflow/references/remote-commit.md: sha256:0bd592cc388a3e78279a02ee3ba8b78f3eeda3c5591e315b9f9408657c42c5ec + .agents/skills/github-workflow/references/remote-commit.md: sha256:df8b01a9457f672f9a463c6c7432b125944fc74dd000a2fa8357ee1ba2183882 .agents/skills/github-workflow/references/repository-settings.md: sha256:4a7ac9d7281c203d84f4ba7ddad6940218194ed3e365ab1c3ff1d1b1519f87e6 .agents/skills/github-workflow/scripts/check_llm_disclosure.py: sha256:bc9c5cbd8efa77095eac42e53da714ed8dff86fa3b0e7870fc3e7eca1ca36e20 .agents/skills/gitignore-workflow/README.md: sha256:0de188ebcdd40ea1aec701410e1c2182049b66bc4ec4d83a3bf55685b4267d47 .agents/skills/gitignore-workflow/SKILL.md: sha256:2ef38f42e418c10e0ba7632e3ba37614df97044dfa8847ad1338e6c4c896c089 .agents/skills/gitignore-workflow/agents/openai.yaml: sha256:f6a9b176003028588ff4c1d9ee4e23c625892d00b65086bf4b6b26a3f896030d .agents/skills/prose-quality-check/README.md: sha256:0e1c7df4ddf1875dc36643dc6547a07f03e7fae79031b7a51e21f2ed367b9e81 - .agents/skills/prose-quality-check/SKILL.md: sha256:80470e0ff754f1db845bcff8123e39bcba7ab68b6d2705bd9dce775851b3d718 + .agents/skills/prose-quality-check/SKILL.md: sha256:29c458b2c62e61348fa39ab626661db6117de64fb12d8b32179a9acf61dd63ec .agents/skills/prose-quality-check/agents/openai.yaml: sha256:a0abf6489b64a09c4322c23e453912ecdc88a3dcf1131ee39d2367e8a2d865e0 .agents/skills/prose-quality-check/assets/markdownlint-cli2.yaml: sha256:1044e29915fe15e9083f808d1170c84cfc0b848123c0da435cabb9512d39c203 .agents/skills/prose-quality-check/references/durable-context.md: sha256:027cc12a9d479890c4a6a88d223c619b2568370aeb6ff37fabb351af85f1dd28 .agents/skills/prose-quality-check/references/handoff-notes.md: sha256:15470b6bb5ad5ad5e618392d7ae1a3939c0c4e63b2f630196f3d4b6ca56c39f7 - .agents/skills/prose-quality-check/references/status-wording.md: sha256:3831cad93369c01130ec10084a644e7e86a60760494a302535b9083e8a0064db + .agents/skills/prose-quality-check/references/status-wording.md: sha256:6b1778b7da38392f493944751d75b2c1659efc307382874baeb2e3083f06db2c .agents/skills/prose-quality-check/references/writing-guides.md: sha256:40264bc89a19402ef0b8eaf4401dbd8e8213612c47f600b5d9a79cdf5ec5415d .agents/skills/python-quality-check/README.md: sha256:20a23003a24a8caf2f03dd5a06bed99c81cf93ab53fe5a196c6a67ab59c53b0e .agents/skills/python-quality-check/SKILL.md: sha256:f32a4b7f394e73c3d7ed56cd8c525cc679010573d8586776dbb54b1aff1c6491 @@ -178,7 +178,7 @@ dependencies: .agents/skills/security-check/references/artifact-inspection.md: sha256:9842555f4789e77e6cf3d22b000116497207ecf6fa5587f2b1fe0dc20e7dffda .agents/skills/security-check/references/distributed-software-licensing.md: sha256:dce7c9fbfe665eb875388ab732b63b0226a5fd4592b12a62c42b6d1372c0d025 .agents/skills/security-check/references/external-code-execution.md: sha256:03d666ef02095acc8b6d5e03d1bb8378f8b38ce01c6f006d2f7934fcfb6bfe4b - content_hash: sha256:196cc31549849300ef96c80a2f2f50b4b142946fd70ac448e85a2acc2b3afe30 + content_hash: sha256:2f3bf8cc2605e293287f70172a3e0bad0cd55bde3c95f19f620f53aeafda7389 skill_subset: - apm-workflow - changelog-workflow @@ -436,7 +436,7 @@ deployments: owners: - aoirint/skills active_owner: aoirint/skills - content_hash: sha256:cbe89b115e778b2417abf5fb15d98b2d1403c3ea0c99bf5ce9a0a65bef0cd6d7 + content_hash: sha256:7b238a28221ed66fbbcdf22533403434f615eaed6a0153f5b94cbb290bb2c1cb - kind: project-relative target: codex value: .agents/skills/commit-message-quality-check/agents/openai.yaml @@ -607,7 +607,7 @@ deployments: owners: - aoirint/skills active_owner: aoirint/skills - content_hash: sha256:e48d27f4c7f0fa5ec0efe944994fcad8eb2083e586bfbf720dda19bb3941acc1 + content_hash: sha256:27ab6a9e3ce9a330084410978b8b77695bd8c1414cbb392f77b90938c62a097b - kind: project-relative target: codex value: .agents/skills/github-workflow/agents/openai.yaml @@ -634,7 +634,7 @@ deployments: owners: - aoirint/skills active_owner: aoirint/skills - content_hash: sha256:0bd592cc388a3e78279a02ee3ba8b78f3eeda3c5591e315b9f9408657c42c5ec + content_hash: sha256:df8b01a9457f672f9a463c6c7432b125944fc74dd000a2fa8357ee1ba2183882 - kind: project-relative target: codex value: .agents/skills/github-workflow/references/repository-settings.md @@ -715,7 +715,7 @@ deployments: owners: - aoirint/skills active_owner: aoirint/skills - content_hash: sha256:80470e0ff754f1db845bcff8123e39bcba7ab68b6d2705bd9dce775851b3d718 + content_hash: sha256:29c458b2c62e61348fa39ab626661db6117de64fb12d8b32179a9acf61dd63ec - kind: project-relative target: codex value: .agents/skills/prose-quality-check/agents/openai.yaml @@ -760,7 +760,7 @@ deployments: owners: - aoirint/skills active_owner: aoirint/skills - content_hash: sha256:3831cad93369c01130ec10084a644e7e86a60760494a302535b9083e8a0064db + content_hash: sha256:6b1778b7da38392f493944751d75b2c1659efc307382874baeb2e3083f06db2c - kind: project-relative target: codex value: .agents/skills/prose-quality-check/references/writing-guides.md diff --git a/apm.yml b/apm.yml index 2b0ee41..1a7fc9c 100644 --- a/apm.yml +++ b/apm.yml @@ -8,7 +8,7 @@ targets: dependencies: apm: - git: aoirint/skills - ref: 1bbdf247da61492e8c1531f341aae400a04b9503 + ref: d7e4e238f6aa4f80b1be13194a0e291bc18aef0f skills: - apm-workflow - changelog-workflow