fixup! test: use TEST_TMPDIR as fallback for E2E temporary directory

Author: alan-agius4

tests/e2e/tests/misc/create-angular.ts

@@ -1,12 +1,13 @@
 import { equal } from 'node:assert';
-import { join, resolve } from 'node:path';
+import { join } from 'node:path';
 import { expectFileToExist, readFile, rimraf } from '../../utils/fs';
 import { getActivePackageManager } from '../../utils/packages';
 import { silentBun, silentNpm, silentPnpm, silentYarn } from '../../utils/process';
+import { mktempd } from '../../utils/utils';
 
 export default async function () {
   const currentDirectory = process.cwd();
-  const newDirectory = resolve('../');
+  const newDirectory = await mktempd('create-angular-test-');
   const projectName = 'test-project-create';
 
   try {

tests/e2e/utils/process.ts

@@ -441,19 +441,13 @@ export function silentGit(...args: string[]) {
  * registry (not the test runner or standard global node_modules).
  */
 export async function launchTestProcess(entry: string, ...args: any[]): Promise<void> {
-  // NOTE: do NOT use the bazel TEST_TMPDIR. When sandboxing is not enabled the
-  // TEST_TMPDIR is not sandboxed and has symlinks into the src dir in a
-  // parent directory. Symlinks into the src dir will include package.json,
-  // .git and other files/folders that may effect e2e tests.
-
   const tempRoot: string = getGlobalVariable('tmp-root');
-  const TEMP = process.env.TEMP ?? process.env.TMPDIR ?? tempRoot;
 
   // Extract explicit environment variables for the test process.
   const env: NodeJS.ProcessEnv = {
-    TEMP,
-    TMPDIR: TEMP,
-    HOME: TEMP,
+    TEMP: tempRoot,
+    TMPDIR: tempRoot,
+    HOME: tempRoot,
 
     // Use BAZEL_TARGET as a metadata variable to show it is a
     // process managed by bazel
@@ -469,7 +463,7 @@ export async function launchTestProcess(entry: string, ...args: any[]): Promise<
   // non angular-cli paths such as /usr/bin for generic commands.
   env.PATH = process.env
     .PATH!.split(delimiter)
-    .filter((p) => p.startsWith(tempRoot) || p.startsWith(TEMP) || !p.includes('angular-cli'))
+    .filter((p) => p.startsWith(tempRoot) || !p.includes('angular-cli'))
     .join(delimiter);
 
   const testProcessArgs = [

tests/e2e/utils/utils.ts

@@ -21,7 +21,7 @@ export function expectToFail(fn: () => Promise<any>, errorMessage?: string): Pro
 export async function mktempd(prefix: string, tempRoot?: string): Promise<string> {
   return realpath(
     await mkdtemp(
-      path.join(tempRoot ?? process.env.E2E_TEMP ?? process.env.TEST_TMPDIR ?? tmpdir(), prefix),
+      path.join(tempRoot || process.env.E2E_TEMP || process.env.TEST_TMPDIR || tmpdir(), prefix),
     ),
   );
 }