Skip to content

![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) #37

Description

@EddyTheCo

medium

Using ASSERT_* macros inside a lambda that returns void (like this callback) will only exit the lambda, not the entire test case. If the assertion fails, the rest of the test in the main thread will continue to execute, potentially leading to confusing results or crashes if subsequent code depends on the assertion. Use EXPECT_* instead, or a mechanism to propagate the failure to the main thread.

                EXPECT_FALSE(technologies.empty())

Originally posted by @gemini-code-assist[bot] in #36 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions