Skip to content

Commit 20f3793

Browse files
committed
ci: add job-level timeout-minutes to all storyboard jobs for consistency
Per pre-PR DX review: adding timeout-minutes: 15 to only the storyboard job while leaving peer jobs unguarded creates a confusing asymmetry for contributors. Add timeout-minutes to all four storyboard jobs: - storyboard (seller_agent): 15 min (setup ~5m, suite ~5m, 5m slack) - storyboard-v3-reference-seller: 20 min (additional Postgres + JS mock-server boot; slightly tighter on cold cache) - storyboard-multi-platform-seller: 15 min - storyboard-sales-proposal-mode: 15 min
1 parent e3ff2e8 commit 20f3793

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -510,6 +510,7 @@ jobs:
510510
storyboard-v3-reference-seller:
511511
name: AdCP storyboard runner — v3 reference seller (translator)
512512
runs-on: ubuntu-latest
513+
timeout-minutes: 20
513514
# Required as of @adcp/sdk@6.7.0 (sales-guaranteed mock-server
514515
# canonicalized; closes #449). Storyboard run + traffic-counter
515516
# assertions gate every PR's translator-pattern conformance.
@@ -747,6 +748,7 @@ jobs:
747748
storyboard-multi-platform-seller:
748749
name: AdCP storyboard runner — examples/multi_platform_seller (PlatformRouter)
749750
runs-on: ubuntu-latest
751+
timeout-minutes: 15
750752
# Multi-tenant proof: one process, two tenants, one router. Each
751753
# tenant's storyboard runs against its own subdomain
752754
# (tenant-a.localhost / tenant-b.localhost). Blocking gate — both
@@ -856,6 +858,7 @@ jobs:
856858
storyboard-sales-proposal-mode:
857859
name: AdCP storyboard runner — sales-proposal-mode (proposal_finalize)
858860
runs-on: ubuntu-latest
861+
timeout-minutes: 15
859862
# v1.5 ProposalManager finalize lifecycle proof. The mock seller
860863
# declares ``finalize=True`` + wires an ``InMemoryProposalStore``;
861864
# the framework's dispatch wiring intercepts ``refine[i].action='finalize'``

0 commit comments

Comments
 (0)