From a097b8c5e020f85d333ab22c282ab5ae768d6e48 Mon Sep 17 00:00:00 2001
From: Jeremy Hatfield <jhatfield82@gmail.com>
Date: Tue, 18 Aug 2026 02:14:34 +0000
Subject: [PATCH 1/4] chore(ci): add timeout and retry to Playwright browser
 installs to prevent job-timeout hangs

apt-get inside `playwright install --with-deps` can silently hang against
a flaky Azure apt mirror with no timeout of its own, burning the full
60-minute job timeout and surfacing as a misleading cancelled run instead
of a clear failure. Wrap all 10 Playwright browser install steps in
nick-fields/retry (10min/attempt, 3 attempts, 15s backoff), matching the
existing pattern already used in docker-build.yml.
---
 .github/workflows/e2e-tests-split.yml | 170 +++++++++++++++++---------
 1 file changed, 110 insertions(+), 60 deletions(-)

diff --git a/.github/workflows/e2e-tests-split.yml b/.github/workflows/e2e-tests-split.yml
index 3fb9611d6..29f1ce13e 100644
--- a/.github/workflows/e2e-tests-split.yml
+++ b/.github/workflows/e2e-tests-split.yml
@@ -324,12 +324,17 @@ jobs:
         run: npm ci --ignore-scripts
 
       - name: Install Playwright Chromium
-        run: |
-          echo "📦 Installing Chromium..."
-          npx playwright install --with-deps chromium
-          EXIT_CODE=$?
-          echo "✅ Install command completed (exit code: $EXIT_CODE)"
-          exit "$EXIT_CODE"
+        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
+        with:
+          timeout_minutes: 10
+          max_attempts: 3
+          retry_wait_seconds: 15
+          retry_on: error
+          warning_on_retry: true
+          command: |
+            set -euo pipefail
+            echo "📦 Installing Chromium..."
+            npx playwright install --with-deps chromium
 
       - name: Run Chromium Security Enforcement Tests
         run: |
@@ -559,20 +564,30 @@ jobs:
         run: npm ci --ignore-scripts
 
       - name: Install Playwright Chromium (required by security-tests dependency)
-        run: |
-          echo "📦 Installing Chromium (required by security-tests dependency)..."
-          npx playwright install --with-deps chromium
-          EXIT_CODE=$?
-          echo "✅ Install command completed (exit code: $EXIT_CODE)"
-          exit "$EXIT_CODE"
+        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
+        with:
+          timeout_minutes: 10
+          max_attempts: 3
+          retry_wait_seconds: 15
+          retry_on: error
+          warning_on_retry: true
+          command: |
+            set -euo pipefail
+            echo "📦 Installing Chromium (required by security-tests dependency)..."
+            npx playwright install --with-deps chromium
 
       - name: Install Playwright Firefox
-        run: |
-          echo "📦 Installing Firefox..."
-          npx playwright install --with-deps firefox
-          EXIT_CODE=$?
-          echo "✅ Install command completed (exit code: $EXIT_CODE)"
-          exit "$EXIT_CODE"
+        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
+        with:
+          timeout_minutes: 10
+          max_attempts: 3
+          retry_wait_seconds: 15
+          retry_on: error
+          warning_on_retry: true
+          command: |
+            set -euo pipefail
+            echo "📦 Installing Firefox..."
+            npx playwright install --with-deps firefox
 
       - name: Run Firefox Security Enforcement Tests
         run: |
@@ -805,20 +820,30 @@ jobs:
         run: npm ci --ignore-scripts
 
       - name: Install Playwright Chromium (required by security-tests dependency)
-        run: |
-          echo "📦 Installing Chromium (required by security-tests dependency)..."
-          npx playwright install --with-deps chromium
-          EXIT_CODE=$?
-          echo "✅ Install command completed (exit code: $EXIT_CODE)"
-          exit "$EXIT_CODE"
+        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
+        with:
+          timeout_minutes: 10
+          max_attempts: 3
+          retry_wait_seconds: 15
+          retry_on: error
+          warning_on_retry: true
+          command: |
+            set -euo pipefail
+            echo "📦 Installing Chromium (required by security-tests dependency)..."
+            npx playwright install --with-deps chromium
 
       - name: Install Playwright WebKit
-        run: |
-          echo "📦 Installing WebKit..."
-          npx playwright install --with-deps webkit
-          EXIT_CODE=$?
-          echo "✅ Install command completed (exit code: $EXIT_CODE)"
-          exit "$EXIT_CODE"
+        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
+        with:
+          timeout_minutes: 10
+          max_attempts: 3
+          retry_wait_seconds: 15
+          retry_on: error
+          warning_on_retry: true
+          command: |
+            set -euo pipefail
+            echo "📦 Installing WebKit..."
+            npx playwright install --with-deps webkit
 
       - name: Run WebKit Security Enforcement Tests
         run: |
@@ -1078,12 +1103,17 @@ jobs:
         run: npm ci --ignore-scripts
 
       - name: Install Playwright Chromium
-        run: |
-          echo "📦 Installing Chromium..."
-          npx playwright install --with-deps chromium
-          EXIT_CODE=$?
-          echo "✅ Install command completed (exit code: $EXIT_CODE)"
-          exit "$EXIT_CODE"
+        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
+        with:
+          timeout_minutes: 10
+          max_attempts: 3
+          retry_wait_seconds: 15
+          retry_on: error
+          warning_on_retry: true
+          command: |
+            set -euo pipefail
+            echo "📦 Installing Chromium..."
+            npx playwright install --with-deps chromium
 
       - name: Run Chromium Non-Security Tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
         run: |
@@ -1316,20 +1346,30 @@ jobs:
         run: npm ci --ignore-scripts
 
       - name: Install Playwright Chromium (required by security-tests dependency)
-        run: |
-          echo "📦 Installing Chromium (required by security-tests dependency)..."
-          npx playwright install --with-deps chromium
-          EXIT_CODE=$?
-          echo "✅ Install command completed (exit code: $EXIT_CODE)"
-          exit "$EXIT_CODE"
+        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
+        with:
+          timeout_minutes: 10
+          max_attempts: 3
+          retry_wait_seconds: 15
+          retry_on: error
+          warning_on_retry: true
+          command: |
+            set -euo pipefail
+            echo "📦 Installing Chromium (required by security-tests dependency)..."
+            npx playwright install --with-deps chromium
 
       - name: Install Playwright Firefox
-        run: |
-          echo "📦 Installing Firefox..."
-          npx playwright install --with-deps firefox
-          EXIT_CODE=$?
-          echo "✅ Install command completed (exit code: $EXIT_CODE)"
-          exit "$EXIT_CODE"
+        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
+        with:
+          timeout_minutes: 10
+          max_attempts: 3
+          retry_wait_seconds: 15
+          retry_on: error
+          warning_on_retry: true
+          command: |
+            set -euo pipefail
+            echo "📦 Installing Firefox..."
+            npx playwright install --with-deps firefox
 
       - name: Run Firefox Non-Security Tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
         run: |
@@ -1562,20 +1602,30 @@ jobs:
         run: npm ci --ignore-scripts
 
       - name: Install Playwright Chromium (required by security-tests dependency)
-        run: |
-          echo "📦 Installing Chromium (required by security-tests dependency)..."
-          npx playwright install --with-deps chromium
-          EXIT_CODE=$?
-          echo "✅ Install command completed (exit code: $EXIT_CODE)"
-          exit "$EXIT_CODE"
+        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
+        with:
+          timeout_minutes: 10
+          max_attempts: 3
+          retry_wait_seconds: 15
+          retry_on: error
+          warning_on_retry: true
+          command: |
+            set -euo pipefail
+            echo "📦 Installing Chromium (required by security-tests dependency)..."
+            npx playwright install --with-deps chromium
 
       - name: Install Playwright WebKit
-        run: |
-          echo "📦 Installing WebKit..."
-          npx playwright install --with-deps webkit
-          EXIT_CODE=$?
-          echo "✅ Install command completed (exit code: $EXIT_CODE)"
-          exit "$EXIT_CODE"
+        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
+        with:
+          timeout_minutes: 10
+          max_attempts: 3
+          retry_wait_seconds: 15
+          retry_on: error
+          warning_on_retry: true
+          command: |
+            set -euo pipefail
+            echo "📦 Installing WebKit..."
+            npx playwright install --with-deps webkit
 
       - name: Run WebKit Non-Security Tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
         run: |

From f98431a419911112ee0925705407d93dbd19b0f7 Mon Sep 17 00:00:00 2001
From: Jeremy Hatfield <jhatfield82@gmail.com>
Date: Tue, 18 Aug 2026 02:49:14 +0000
Subject: [PATCH 2/4] fix(ci): replace nick-fields/retry with a bash timeout
 loop for Playwright installs

nick-fields/retry's timeout handling calls process.kill() on the child
process tree from its own Node process. `playwright install --with-deps`
internally elevates part of that tree to root via sudo to run apt-get, so
when the action's 10-minute timeout fires, the kill fails with EPERM
(cross-UID kill) and throws unhandled instead of retrying. The step died
on attempt 1 and never reached attempt 2 or 3.

Replaced all 10 occurrences with a plain bash retry loop using coreutils
`timeout`, which signals its own direct child and isn't subject to the
EPERM bug class. Matches the existing bash retry-loop idiom already used
in codecov-upload.yml and quality-checks.yml.
---
 .github/workflows/e2e-tests-split.yml | 240 ++++++++++++++------------
 1 file changed, 130 insertions(+), 110 deletions(-)

diff --git a/.github/workflows/e2e-tests-split.yml b/.github/workflows/e2e-tests-split.yml
index 29f1ce13e..5f42fe116 100644
--- a/.github/workflows/e2e-tests-split.yml
+++ b/.github/workflows/e2e-tests-split.yml
@@ -324,17 +324,19 @@ jobs:
         run: npm ci --ignore-scripts
 
       - name: Install Playwright Chromium
-        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
-        with:
-          timeout_minutes: 10
-          max_attempts: 3
-          retry_wait_seconds: 15
-          retry_on: error
-          warning_on_retry: true
-          command: |
-            set -euo pipefail
-            echo "📦 Installing Chromium..."
-            npx playwright install --with-deps chromium
+        run: |
+          set -uo pipefail
+          echo "📦 Installing Chromium..."
+          for attempt in 1 2 3; do
+            timeout 10m npx playwright install --with-deps chromium && break
+            if [ "$attempt" -lt 3 ]; then
+              echo "Attempt ${attempt}/3 failed; retrying in 15s..." >&2
+              sleep 15
+            else
+              echo "ERROR: Playwright chromium install failed after 3 attempts" >&2
+              exit 1
+            fi
+          done
 
       - name: Run Chromium Security Enforcement Tests
         run: |
@@ -564,30 +566,34 @@ jobs:
         run: npm ci --ignore-scripts
 
       - name: Install Playwright Chromium (required by security-tests dependency)
-        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
-        with:
-          timeout_minutes: 10
-          max_attempts: 3
-          retry_wait_seconds: 15
-          retry_on: error
-          warning_on_retry: true
-          command: |
-            set -euo pipefail
-            echo "📦 Installing Chromium (required by security-tests dependency)..."
-            npx playwright install --with-deps chromium
+        run: |
+          set -uo pipefail
+          echo "📦 Installing Chromium (required by security-tests dependency)..."
+          for attempt in 1 2 3; do
+            timeout 10m npx playwright install --with-deps chromium && break
+            if [ "$attempt" -lt 3 ]; then
+              echo "Attempt ${attempt}/3 failed; retrying in 15s..." >&2
+              sleep 15
+            else
+              echo "ERROR: Playwright chromium install failed after 3 attempts" >&2
+              exit 1
+            fi
+          done
 
       - name: Install Playwright Firefox
-        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
-        with:
-          timeout_minutes: 10
-          max_attempts: 3
-          retry_wait_seconds: 15
-          retry_on: error
-          warning_on_retry: true
-          command: |
-            set -euo pipefail
-            echo "📦 Installing Firefox..."
-            npx playwright install --with-deps firefox
+        run: |
+          set -uo pipefail
+          echo "📦 Installing Firefox..."
+          for attempt in 1 2 3; do
+            timeout 10m npx playwright install --with-deps firefox && break
+            if [ "$attempt" -lt 3 ]; then
+              echo "Attempt ${attempt}/3 failed; retrying in 15s..." >&2
+              sleep 15
+            else
+              echo "ERROR: Playwright firefox install failed after 3 attempts" >&2
+              exit 1
+            fi
+          done
 
       - name: Run Firefox Security Enforcement Tests
         run: |
@@ -820,30 +826,34 @@ jobs:
         run: npm ci --ignore-scripts
 
       - name: Install Playwright Chromium (required by security-tests dependency)
-        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
-        with:
-          timeout_minutes: 10
-          max_attempts: 3
-          retry_wait_seconds: 15
-          retry_on: error
-          warning_on_retry: true
-          command: |
-            set -euo pipefail
-            echo "📦 Installing Chromium (required by security-tests dependency)..."
-            npx playwright install --with-deps chromium
+        run: |
+          set -uo pipefail
+          echo "📦 Installing Chromium (required by security-tests dependency)..."
+          for attempt in 1 2 3; do
+            timeout 10m npx playwright install --with-deps chromium && break
+            if [ "$attempt" -lt 3 ]; then
+              echo "Attempt ${attempt}/3 failed; retrying in 15s..." >&2
+              sleep 15
+            else
+              echo "ERROR: Playwright chromium install failed after 3 attempts" >&2
+              exit 1
+            fi
+          done
 
       - name: Install Playwright WebKit
-        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
-        with:
-          timeout_minutes: 10
-          max_attempts: 3
-          retry_wait_seconds: 15
-          retry_on: error
-          warning_on_retry: true
-          command: |
-            set -euo pipefail
-            echo "📦 Installing WebKit..."
-            npx playwright install --with-deps webkit
+        run: |
+          set -uo pipefail
+          echo "📦 Installing WebKit..."
+          for attempt in 1 2 3; do
+            timeout 10m npx playwright install --with-deps webkit && break
+            if [ "$attempt" -lt 3 ]; then
+              echo "Attempt ${attempt}/3 failed; retrying in 15s..." >&2
+              sleep 15
+            else
+              echo "ERROR: Playwright webkit install failed after 3 attempts" >&2
+              exit 1
+            fi
+          done
 
       - name: Run WebKit Security Enforcement Tests
         run: |
@@ -1103,17 +1113,19 @@ jobs:
         run: npm ci --ignore-scripts
 
       - name: Install Playwright Chromium
-        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
-        with:
-          timeout_minutes: 10
-          max_attempts: 3
-          retry_wait_seconds: 15
-          retry_on: error
-          warning_on_retry: true
-          command: |
-            set -euo pipefail
-            echo "📦 Installing Chromium..."
-            npx playwright install --with-deps chromium
+        run: |
+          set -uo pipefail
+          echo "📦 Installing Chromium..."
+          for attempt in 1 2 3; do
+            timeout 10m npx playwright install --with-deps chromium && break
+            if [ "$attempt" -lt 3 ]; then
+              echo "Attempt ${attempt}/3 failed; retrying in 15s..." >&2
+              sleep 15
+            else
+              echo "ERROR: Playwright chromium install failed after 3 attempts" >&2
+              exit 1
+            fi
+          done
 
       - name: Run Chromium Non-Security Tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
         run: |
@@ -1346,30 +1358,34 @@ jobs:
         run: npm ci --ignore-scripts
 
       - name: Install Playwright Chromium (required by security-tests dependency)
-        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
-        with:
-          timeout_minutes: 10
-          max_attempts: 3
-          retry_wait_seconds: 15
-          retry_on: error
-          warning_on_retry: true
-          command: |
-            set -euo pipefail
-            echo "📦 Installing Chromium (required by security-tests dependency)..."
-            npx playwright install --with-deps chromium
+        run: |
+          set -uo pipefail
+          echo "📦 Installing Chromium (required by security-tests dependency)..."
+          for attempt in 1 2 3; do
+            timeout 10m npx playwright install --with-deps chromium && break
+            if [ "$attempt" -lt 3 ]; then
+              echo "Attempt ${attempt}/3 failed; retrying in 15s..." >&2
+              sleep 15
+            else
+              echo "ERROR: Playwright chromium install failed after 3 attempts" >&2
+              exit 1
+            fi
+          done
 
       - name: Install Playwright Firefox
-        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
-        with:
-          timeout_minutes: 10
-          max_attempts: 3
-          retry_wait_seconds: 15
-          retry_on: error
-          warning_on_retry: true
-          command: |
-            set -euo pipefail
-            echo "📦 Installing Firefox..."
-            npx playwright install --with-deps firefox
+        run: |
+          set -uo pipefail
+          echo "📦 Installing Firefox..."
+          for attempt in 1 2 3; do
+            timeout 10m npx playwright install --with-deps firefox && break
+            if [ "$attempt" -lt 3 ]; then
+              echo "Attempt ${attempt}/3 failed; retrying in 15s..." >&2
+              sleep 15
+            else
+              echo "ERROR: Playwright firefox install failed after 3 attempts" >&2
+              exit 1
+            fi
+          done
 
       - name: Run Firefox Non-Security Tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
         run: |
@@ -1602,30 +1618,34 @@ jobs:
         run: npm ci --ignore-scripts
 
       - name: Install Playwright Chromium (required by security-tests dependency)
-        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
-        with:
-          timeout_minutes: 10
-          max_attempts: 3
-          retry_wait_seconds: 15
-          retry_on: error
-          warning_on_retry: true
-          command: |
-            set -euo pipefail
-            echo "📦 Installing Chromium (required by security-tests dependency)..."
-            npx playwright install --with-deps chromium
+        run: |
+          set -uo pipefail
+          echo "📦 Installing Chromium (required by security-tests dependency)..."
+          for attempt in 1 2 3; do
+            timeout 10m npx playwright install --with-deps chromium && break
+            if [ "$attempt" -lt 3 ]; then
+              echo "Attempt ${attempt}/3 failed; retrying in 15s..." >&2
+              sleep 15
+            else
+              echo "ERROR: Playwright chromium install failed after 3 attempts" >&2
+              exit 1
+            fi
+          done
 
       - name: Install Playwright WebKit
-        uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4.0.0
-        with:
-          timeout_minutes: 10
-          max_attempts: 3
-          retry_wait_seconds: 15
-          retry_on: error
-          warning_on_retry: true
-          command: |
-            set -euo pipefail
-            echo "📦 Installing WebKit..."
-            npx playwright install --with-deps webkit
+        run: |
+          set -uo pipefail
+          echo "📦 Installing WebKit..."
+          for attempt in 1 2 3; do
+            timeout 10m npx playwright install --with-deps webkit && break
+            if [ "$attempt" -lt 3 ]; then
+              echo "Attempt ${attempt}/3 failed; retrying in 15s..." >&2
+              sleep 15
+            else
+              echo "ERROR: Playwright webkit install failed after 3 attempts" >&2
+              exit 1
+            fi
+          done
 
       - name: Run WebKit Non-Security Tests (Shard ${{ matrix.shard }}/${{ matrix.total-shards }})
         run: |

From 4a3f8f03a89c621e81d929e13949d098d2cb702e Mon Sep 17 00:00:00 2001
From: Jeremy Hatfield <jhatfield82@gmail.com>
Date: Tue, 18 Aug 2026 12:09:56 +0000
Subject: [PATCH 3/4] fix(frontend): associate Input labels with their controls
 via auto-generated id

frontend/src/components/ui/Input.tsx rendered <label htmlFor={props.id}>
next to <input {...props} />, but 115 of 118 call sites never pass an id
prop, so the label was never programmatically associated with its
control (WCAG 1.3.1/3.3.2). Browsers fall back to the placeholder text
as the accessible name instead, which also broke Playwright's
getByLabel() matching against these fields.

Auto-generate a stable id via React.useId() when the caller doesn't
supply one, so every <Input label=.../> usage gets a properly
associated label/control pair without changing behavior for call sites
that already pass an explicit id.
---
 frontend/src/components/ui/Input.tsx              | 11 ++++++++++-
 .../src/components/ui/__tests__/Input.test.tsx    | 15 +++++++++++++++
 2 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/frontend/src/components/ui/Input.tsx b/frontend/src/components/ui/Input.tsx
index aa2eabb93..650385c05 100644
--- a/frontend/src/components/ui/Input.tsx
+++ b/frontend/src/components/ui/Input.tsx
@@ -24,18 +24,26 @@ const Input = React.forwardRef<HTMLInputElement, InputProps>(
       className,
       type,
       disabled,
+      id,
       ...props
     },
     ref
   ) => {
     const [showPassword, setShowPassword] = React.useState(false)
     const isPassword = type === 'password'
+    // Auto-generate a stable id when the caller doesn't supply one, so the
+    // label is always programmatically associated with its control (WCAG
+    // 1.3.1 / 3.3.2). `id` is destructured out explicitly above — not left
+    // inside `...props` — so this fallback can't be silently overridden by
+    // a stray `id: undefined` reaching the spread below in prop order.
+    const generatedId = React.useId()
+    const inputId = id ?? generatedId
 
     return (
       <div className="w-full">
         {label && (
           <label
-            htmlFor={props.id}
+            htmlFor={inputId}
             className="block text-sm font-medium text-content-secondary mb-1.5"
           >
             {label}
@@ -49,6 +57,7 @@ const Input = React.forwardRef<HTMLInputElement, InputProps>(
           )}
           <input
             ref={ref}
+            id={inputId}
             type={isPassword ? (showPassword ? 'text' : 'password') : type}
             disabled={disabled}
             aria-describedby={error && errorTestId ? errorTestId : undefined}
diff --git a/frontend/src/components/ui/__tests__/Input.test.tsx b/frontend/src/components/ui/__tests__/Input.test.tsx
index d66074bad..a78a49d5f 100644
--- a/frontend/src/components/ui/__tests__/Input.test.tsx
+++ b/frontend/src/components/ui/__tests__/Input.test.tsx
@@ -24,6 +24,21 @@ describe('Input', () => {
     expect(label).toHaveAttribute('for', 'email-input')
   })
 
+  it('associates label with input via auto-generated id when no id is passed', () => {
+    render(<Input label="Email" />)
+
+    const input = screen.getByLabelText('Email')
+    expect(input).toBeInTheDocument()
+    expect(input.tagName).toBe('INPUT')
+  })
+
+  it('uses the explicit id when provided, not the generated one', () => {
+    render(<Input label="Email" id="custom-email-id" />)
+
+    const input = screen.getByLabelText('Email')
+    expect(input).toHaveAttribute('id', 'custom-email-id')
+  })
+
   it('renders with error state and message', () => {
     render(
       <Input

From f2db3d479461fde2c5533b5784786e7719d81eff Mon Sep 17 00:00:00 2001
From: Jeremy Hatfield <jhatfield82@gmail.com>
Date: Tue, 18 Aug 2026 12:16:35 +0000
Subject: [PATCH 4/4] fix(e2e): restore domcontentloaded navigation wait
 dropped by a 2026-07-28 refactor

gotoTolerant/reloadTolerant in tests/utils/wait-helpers.ts used
waitUntil: 'commit', silently downgraded from waitUntil: 'domcontentloaded'
during a 2026-07-28 refactor (7503c01a) that extracted these helpers from
navigateToLogin()'s previously RCA-verified-working inline implementation
(d537476f). 'commit' fires on Firefox's earliest possible navigation
signal, which Firefox can fail to emit at all for some goto()/reload()
calls -- leaving Playwright's frame-navigation tracker believing a
navigation is still pending and blocking the *next* locator-based wait
on the page for a second full timeout, even though the page had already
rendered correctly. Five subsequent fix attempts patched around this
symptom without tracing it back to the regression.

Trace-level evidence (docs/plans/current_spec.md) confirms this exact
mechanism caused PR #1259's "E2E Firefox (Shard 4/4)" job to fail on
tests/settings/user-lifecycle.spec.ts STEP 4: reloadTolerant() burned
its full 15s timeout with a swallowed TimeoutError, then the following
expect(emailInput).toBeVisible() burned another full 15s blocked on the
phantom pending navigation without ever querying the DOM.

Restores 'domcontentloaded', the value proven correct by the original
2026-07-26 RCA and already used by 100+ other call sites in this suite.
Verified with 3x repeat-each on the target spec (zero flakes, was 3/3
failures before) plus blast-radius checks on every other consumer of
these helpers (user-management.spec.ts full file, long-running-operations.spec.ts
grep-scoped) -- all pass.
---
 tests/utils/wait-helpers.ts | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/tests/utils/wait-helpers.ts b/tests/utils/wait-helpers.ts
index c65030a53..a50b5577b 100644
--- a/tests/utils/wait-helpers.ts
+++ b/tests/utils/wait-helpers.ts
@@ -1330,7 +1330,18 @@ export async function gotoTolerant(
 ): Promise<void> {
   const { timeout = 15000 } = options;
 
-  await page.goto(url, { waitUntil: 'commit', timeout }).catch((error: unknown) => {
+  // waitUntil: 'domcontentloaded', NOT 'commit' — see commit 7503c01a and
+  // docs/reports/qa_report_2026-07-26_shard4-reload-hang.md. 'commit' fires
+  // on Firefox's earliest possible navigation signal, which this repo's own
+  // trace evidence (docs/plans/current_spec.md, PR #1259 RCA) shows Firefox
+  // can fail to emit at all for some goto()/reload() calls, leaving
+  // Playwright's frame-navigation tracker stuck and blocking every
+  // subsequent locator-based wait on the page for a second full timeout.
+  // 'domcontentloaded' is the value already used by 100+ other call sites
+  // in this suite (including tests/settings/navigation-settle-regression.spec.ts,
+  // which codifies this exact failure shape) and is the value this helper's
+  // predecessor code used before it was silently dropped during extraction.
+  await page.goto(url, { waitUntil: 'domcontentloaded', timeout }).catch((error: unknown) => {
     if (!isExpectedNavigationRace(error)) {
       throw error;
     }
@@ -1355,7 +1366,9 @@ export async function reloadTolerant(
 ): Promise<void> {
   const { timeout = 15000 } = options;
 
-  await page.reload({ waitUntil: 'commit', timeout }).catch((error: unknown) => {
+  // See gotoTolerant's comment above — same 'commit' → 'domcontentloaded'
+  // fix, for the same reason.
+  await page.reload({ waitUntil: 'domcontentloaded', timeout }).catch((error: unknown) => {
     if (!isExpectedNavigationRace(error)) {
       throw error;
     }