Stream chooser live#469
Merged
Merged
Conversation
soreau
force-pushed
the
stream-chooser-live
branch
7 times, most recently
from
83ced14 to
b380f11
Compare
Collaborator
|
Testing comes up great, code looks good! |
soreau
force-pushed
the
stream-chooser-live
branch
from
e47c8aa to
300ce9e
Compare
Member
Author
@trigg Thanks for testing! I have updated from shm to dmabuf which changes many things. In theory, it should use less resources. Please let me know if it works well enough for you. |
Collaborator
|
LGTM |
Collaborator
|
There is a segfault on close, otherwise everything is good here. I'll be looking in to that later |
Member
Author
It has already been fixed with the latest commit. |
Collaborator
Colours certainly look mixed on my case :D
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement live window previews. Requires latest wf-copy-capture plugin.