From b9dbe1221d4a1db8deb6a7bf504595699d323661 Mon Sep 17 00:00:00 2001 From: Rhys Sullivan <39114868+RhysSullivan@users.noreply.github.com> Date: Wed, 29 Jul 2026 14:24:15 -0700 Subject: [PATCH] Drop the definition.name narrowing from the artifact migration --- .changeset/lucky-hats-attack.md | 5 +++++ apps/cloud/drizzle/0013_curly_rocket_racer.sql | 1 - apps/cloud/drizzle/meta/0013_snapshot.json | 2 +- apps/cloud/drizzle/meta/0014_snapshot.json | 2 +- apps/cloud/drizzle/meta/0015_snapshot.json | 2 +- apps/cloud/src/db/executor-schema.ts | 2 +- packages/core/sdk/src/core-schema.ts | 7 ++++++- 7 files changed, 15 insertions(+), 6 deletions(-) create mode 100644 .changeset/lucky-hats-attack.md diff --git a/.changeset/lucky-hats-attack.md b/.changeset/lucky-hats-attack.md new file mode 100644 index 000000000..e409a42b4 --- /dev/null +++ b/.changeset/lucky-hats-attack.md @@ -0,0 +1,5 @@ +--- +"executor": patch +--- + +**Fix: the artifact migration no longer narrows `definition.name` to varchar(255), which failed on existing long definition names** diff --git a/apps/cloud/drizzle/0013_curly_rocket_racer.sql b/apps/cloud/drizzle/0013_curly_rocket_racer.sql index 022df47b9..8f6004e5c 100644 --- a/apps/cloud/drizzle/0013_curly_rocket_racer.sql +++ b/apps/cloud/drizzle/0013_curly_rocket_racer.sql @@ -11,5 +11,4 @@ CREATE TABLE "artifact" ( "subject" varchar(255) NOT NULL ); --> statement-breakpoint -ALTER TABLE "definition" ALTER COLUMN "name" SET DATA TYPE varchar(255);--> statement-breakpoint CREATE UNIQUE INDEX "artifact_uidx" ON "artifact" USING btree ("tenant","owner","subject","id"); \ No newline at end of file diff --git a/apps/cloud/drizzle/meta/0013_snapshot.json b/apps/cloud/drizzle/meta/0013_snapshot.json index 0947b138c..62eff6ef9 100644 --- a/apps/cloud/drizzle/meta/0013_snapshot.json +++ b/apps/cloud/drizzle/meta/0013_snapshot.json @@ -515,7 +515,7 @@ }, "name": { "name": "name", - "type": "varchar(255)", + "type": "text", "primaryKey": false, "notNull": true }, diff --git a/apps/cloud/drizzle/meta/0014_snapshot.json b/apps/cloud/drizzle/meta/0014_snapshot.json index 6d3345469..c52059579 100644 --- a/apps/cloud/drizzle/meta/0014_snapshot.json +++ b/apps/cloud/drizzle/meta/0014_snapshot.json @@ -521,7 +521,7 @@ }, "name": { "name": "name", - "type": "varchar(255)", + "type": "text", "primaryKey": false, "notNull": true }, diff --git a/apps/cloud/drizzle/meta/0015_snapshot.json b/apps/cloud/drizzle/meta/0015_snapshot.json index 8aaf1637b..b9904b865 100644 --- a/apps/cloud/drizzle/meta/0015_snapshot.json +++ b/apps/cloud/drizzle/meta/0015_snapshot.json @@ -527,7 +527,7 @@ }, "name": { "name": "name", - "type": "varchar(255)", + "type": "text", "primaryKey": false, "notNull": true }, diff --git a/apps/cloud/src/db/executor-schema.ts b/apps/cloud/src/db/executor-schema.ts index e95ffab26..e23d30d07 100644 --- a/apps/cloud/src/db/executor-schema.ts +++ b/apps/cloud/src/db/executor-schema.ts @@ -181,7 +181,7 @@ export const definition = pgTable( integration: varchar("integration", { length: 255 }).notNull(), connection: varchar("connection", { length: 255 }).notNull(), plugin_id: text("plugin_id").notNull(), - name: varchar("name", { length: 255 }).notNull(), + name: text("name").notNull(), schema: json("schema").notNull(), created_at: timestamp("created_at").notNull(), row_id: varchar("row_id", { length: 255 }) diff --git a/packages/core/sdk/src/core-schema.ts b/packages/core/sdk/src/core-schema.ts index 25dc78129..b03adf5df 100644 --- a/packages/core/sdk/src/core-schema.ts +++ b/packages/core/sdk/src/core-schema.ts @@ -336,7 +336,12 @@ export const coreTables = defineTables({ integration: keyColumn("integration"), connection: keyColumn("connection"), plugin_id: textColumn("plugin_id"), - name: keyColumn("name"), + // text, NOT keyColumn: $def names exceed 255 chars in production (deep + // OpenAPI component paths), and the live cloud column has been TEXT + // since the baseline was patched for it. A varchar(255) here re-emits a + // narrowing ALTER on every drizzle-kit generate, which fails on real + // rows (22001) — that drift broke cloud migration 0013 once already. + name: textColumn("name"), schema: jsonColumn("schema"), created_at: dateColumn("created_at"), },